Permalink
Browse files

Fixed double `onChange` event triggering from <TextInput> on iOS

Summary:
The problem was recently introduced in the last refactoring of the Text module.
There are two problem actually:
(1) Compare this current code with stable version.
In the stable version the event is only triggered here:
https://github.com/facebook/react-native/blob/0.52-stable/Libraries/Text/RCTTextField.m#L132-L140
In the new version the event is triggered in two places (which is obviously wrong).

(2) Executing `[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange:...]` and _onChange() actually do the same thing.
Historically, the single-line <TextInput> used the first approach and multi-line used second one. When we unify the logic, mixed both of them, which was apparenly wrong.
So, we have to remove another call of `[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange:...]`.
The the future we have to completly remove usage of `_eventDispatcher` from this component.

Depends on D6854770.

Reviewed By: fkgozali

Differential Revision: D6869678

fbshipit-source-id: 6705ee8dda2681ae184ef6716238cc8b62efeff1
  • Loading branch information...
shergin authored and facebook-github-bot committed Feb 1, 2018
1 parent 7492860 commit d7fa81f18110f0dc0f310a5c066d9a30020ca830
Showing with 0 additions and 12 deletions.
  1. +0 −12 Libraries/Text/TextInput/RCTBaseTextInputView.m
@@ -286,12 +286,6 @@ - (BOOL)textInputShouldChangeTextInRange:(NSRange)range replacementText:(NSStrin
});
}
[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange
reactTag:self.reactTag
text:backedTextInputView.attributedText.string
key:nil
eventCount:_nativeEventCount];
return YES;
}
@@ -324,12 +318,6 @@ - (void)textInputDidChange
@"eventCount": @(_nativeEventCount),
});
}
[_eventDispatcher sendTextEventWithType:RCTTextEventTypeChange
reactTag:self.reactTag
text:backedTextInputView.attributedText.string
key:nil
eventCount:_nativeEventCount];
}
- (void)textInputDidChangeSelection

0 comments on commit d7fa81f

Please sign in to comment.