From ebf5aeab280f2ebc439ec39d25c48fdf1980cf73 Mon Sep 17 00:00:00 2001
From: Jean Lauliac <jeanlauliac@fb.com>
Date: Fri, 20 Jul 2018 09:17:21 -0700
Subject: [PATCH] BREAKING: metro: rename 'unbundle' to 'ram bundle'

Summary:
@public

Let's get rid of the "unbundle" terminology and instead use "RAM bundle", short for "Random Access Bundle" format. THIS IS A BREAKING CHANGE FOR OSS, as the command becomes `ram-bundle` instead of `unbundle`. It realy shouldn't be a command to start with (only a "format" specifier for the `bundle` command), but I don't want to do that change at this point.

Reviewed By: davidaurelio

Differential Revision: D8894433

fbshipit-source-id: 5565f9ae94c7c2d7f6b25f95ae45b64f27f6aec8
---
 local-cli/bundle/ramBundle.js | 34 ++++++++++++++++++++++++++++++++++
 local-cli/bundle/unbundle.js  | 23 ++++++++++-------------
 local-cli/commands.js         |  1 +
 3 files changed, 45 insertions(+), 13 deletions(-)
 create mode 100644 local-cli/bundle/ramBundle.js

diff --git a/local-cli/bundle/ramBundle.js b/local-cli/bundle/ramBundle.js
new file mode 100644
index 00000000000000..1d85ba3c4c3292
--- /dev/null
+++ b/local-cli/bundle/ramBundle.js
@@ -0,0 +1,34 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+'use strict';
+
+const bundleWithOutput = require('./bundle').withOutput;
+const bundleCommandLineArgs = require('./bundleCommandLineArgs');
+const outputUnbundle = require('metro/src/shared/output/unbundle');
+
+/**
+ * Builds the bundle starting to look for dependencies at the given entry path.
+ */
+function ramBundle(argv, config, args) {
+  return bundleWithOutput(argv, config, args, outputUnbundle);
+}
+
+module.exports = {
+  name: 'ram-bundle',
+  description:
+    'builds javascript as a "Random Access Module" bundle for offline use',
+  func: ramBundle,
+  options: bundleCommandLineArgs.concat({
+    command: '--indexed-ram-bundle',
+    description:
+      'Force the "Indexed RAM" bundle file format, even when building for android',
+    default: false,
+  }),
+};
diff --git a/local-cli/bundle/unbundle.js b/local-cli/bundle/unbundle.js
index da4a4f70d6a8e5..dfc7fa2483b1ac 100644
--- a/local-cli/bundle/unbundle.js
+++ b/local-cli/bundle/unbundle.js
@@ -9,25 +9,22 @@
 
 'use strict';
 
-const bundleWithOutput = require('./bundle').withOutput;
 const bundleCommandLineArgs = require('./bundleCommandLineArgs');
-const outputUnbundle = require('metro/src/shared/output/unbundle');
-
-/**
- * Builds the bundle starting to look for dependencies at the given entry path.
- */
-function unbundle(argv, config, args) {
-  return bundleWithOutput(argv, config, args, outputUnbundle);
-}
 
 module.exports = {
   name: 'unbundle',
-  description: 'builds javascript as "unbundle" for offline use',
-  func: unbundle,
+  description: 'Deprecated. Renamed to `ram-bundle`.',
+  func: () => {
+    throw new Error(
+      'The `unbundle` command has been renamed `ram-bundle` to better ' +
+        'represent the actual functionality. `ram` mean "Random Access ' +
+        'Module", this particular format of bundle. Functionality remained ' +
+        'unchanged.',
+    );
+  },
   options: bundleCommandLineArgs.concat({
     command: '--indexed-unbundle',
-    description:
-      'Force indexed unbundle file format, even when building for android',
+    description: 'Deprecated. Renamed to `--indexed-ram-bundle`.',
     default: false,
   }),
 };
diff --git a/local-cli/commands.js b/local-cli/commands.js
index f75207bd3bc5cb..2a704aa5d4465f 100644
--- a/local-cli/commands.js
+++ b/local-cli/commands.js
@@ -42,6 +42,7 @@ const documentedCommands = [
   require('./library/library'),
   require('./bundle/bundle'),
   require('./bundle/unbundle'),
+  require('./bundle/ramBundle'),
   require('./eject/eject'),
   require('./link/link'),
   require('./link/unlink'),