Browse files

Better doc for 'data:' uri scheme & mandatory size

It is quite confusing that the 'data:' uri scheme is not documented, but working.
It is very useful when getting e.g. an icon from a REST call.

Also, the mandatory size style for network & data images should be mentioned here, not only in the image guide.

Thank you for sending the PR!

If you changed any code, please provide us with clear instructions on how you verified your changes work. In other words, a test plan is *required*. Bonus points for screenshots and videos!

Please read the Contribution Guidelines at to learn more about contributing to React Native.

Happy contributing!
Closes #14826

Differential Revision: D5401671

Pulled By: hramos

fbshipit-source-id: 8f1f28a94095eeaccae9234e059e0983ba3556b2
  • Loading branch information...
harry-g authored and facebook-github-bot committed Jul 11, 2017
1 parent 8ea6cea commit ec8118b63704ab23a122047d4e22d0fba416afe5
Showing with 8 additions and 2 deletions.
  1. +8 −2 Libraries/Image/Image.ios.js
@@ -35,8 +35,10 @@ const ImageViewManager = NativeModules.ImageViewManager;
* including network images, static resources, temporary local images, and
* images from local disk, such as the camera roll.
* This example shows both fetching and displaying an image from local
* storage as well as one from network.
* This example shows fetching and displaying an image from local storage
* as well as one from network and even from data provided in the `'data:'` uri scheme.
* > Note that for network and data images, you will need to manually specify the dimensions of your image!
* ```ReactNativeWebPlayer
* import React, { Component } from 'react';
@@ -53,6 +55,10 @@ const ImageViewManager = NativeModules.ImageViewManager;
* style={{width: 50, height: 50}}
* source={{uri: ''}}
* />
* <Image
* style={{width: 66, height: 58}}
* />
* </View>
* );
* }

0 comments on commit ec8118b

Please sign in to comment.