Browse files

Make sure refreshControl shows up on initial render if specified

[this commit](2e1707d) which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render.

The problem is, the [previous beginRefreshing method](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeL51) was renamed to `beginRefreshingProgramatically` and the old call was left in one place [here](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeR47).

Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix.

I have tested this locally in my app, can provide a video if needed.


 [IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified
Closes #17727

Differential Revision: D6827402

Pulled By: shergin

fbshipit-source-id: 25849244e87af54f25d636b6ade7adcf88958980
  • Loading branch information...
vonovak authored and facebook-github-bot committed Jan 29, 2018
1 parent 2fef1ba commit ed5872e2cca955ee407e87e37e13c7fed182199a
Showing with 1 addition and 1 deletion.
  1. +1 −1 React/Views/RCTRefreshControl.m
@@ -44,7 +44,7 @@ - (void)layoutSubviews
// If the control is refreshing when mounted we need to call
// beginRefreshing in layoutSubview or it doesn't work.
if (_currentRefreshingState && _isInitialRender) {
[self beginRefreshing];
[self beginRefreshingProgrammatically];
_isInitialRender = false;

0 comments on commit ed5872e

Please sign in to comment.