Please sign in to comment.
Deprecating/removing `setFrame`, `setLeftTop`, and co.
Summary: Motivation: * `RCTShadowView`'s `frame` property actually represents computed layout of the view. We must not use it as a setter for yoga node styles; * Using `frame` and `setLeftTop` in existing way actually works only for view with absolute positioning, so it is super rare and special case; * Internally, setting `frame` only make sense to `RootView`, and in that case there we always must not change `origin` we are introducing `setSize` method. Changes: * `[-RCTShadowView setFrame:]` was removed, `frame` property is readonly now; * `[-RCTShadowView setLeftTop:]` was removed; no replacement provided; * `[-RCTShadowView size]` read-write property was added; * `[-RCTUIManager setFrame:forView:]` was deprecated, use (just introduced) `setSize:forView:` instead; * `[-RCTUIManager setSize:forView:]` was added. If you are still need some of removed methods, you are probably doing something wrong. Consider using `setIntrinsicContentSize`-family methods, `setSize`-family methods, or (in the worst case) accessing `yogaNode` directly. Reviewed By: javache Differential Revision: D4491384 fbshipit-source-id: 56dd84567324c5a86e4c870a41c38322dc1224d2
- Loading branch information...
Showing with 62 additions and 38 deletions.