Skip to content
Permalink
Branch: master
Commits on Mar 16, 2019
  1. Fabric: working podspecs & works in RNTester (#23803)

    ericlewis authored and facebook-github-bot committed Mar 16, 2019
    Summary:
    This is the couple of hacks I used after I finished #23802 in order to get fabric working on RNTester. This is inspired from prior work by kmagiera.
    
    The goal of this PR is to show others what I’m struggling with, and to eventually merge it sans hacks.
    
    - Yarn Install
    - Uncomment the commented out pods in RNTester's pod file
    - Open RNTesterPods workspace
    - Run App
    
    - this is only for pods, the non-pod RNTester will no longer work until updated with fabric too.
    - `SurfaceHostingView` & `SurfaceHostingProxyRootView` both try to start the surface immediately, this leads to a race condition due to the javascript not having loaded yet, the hack here is:
       1. Swizzle the `start` method on `RCTFabricSurface` to no-op when called.
       2. Add observer for `RCTJavaScriptDidLoadNotification`
       3. Call private method `_startAllSurfaces` on `_surfacePresenter` in AppDelegate when we receive `RCTJavaScriptDidLoadNotification`.
    
    [General] [Added] - Use Fabric in RNTester
    Pull Request resolved: #23803
    
    Reviewed By: shergin, mdvacca
    
    Differential Revision: D14450726
    
    Pulled By: fkgozali
    
    fbshipit-source-id: 8ae2d48634fecb60db539aaf0a2c89ba1f572c27
Commits on Mar 15, 2019
  1. TurboModules: add podspec (#23927)

    ericlewis authored and facebook-github-bot committed Mar 15, 2019
    Summary:
    Add's a podspec to allow linking / building turbomodules.
    
    [iOS] [Added] - podspec for turbomodules
    Pull Request resolved: #23927
    
    Reviewed By: mdvacca, RSNara
    
    Differential Revision: D14474598
    
    Pulled By: fkgozali
    
    fbshipit-source-id: afafce0f0af31469a3ef91616575b3b0f36055bc
Commits on Mar 14, 2019
  1. Move RCTTest & takeSnapshot to RNTester (#23721)

    ericlewis authored and facebook-github-bot committed Mar 14, 2019
    Summary:
    Part of: #23313.
    
    This moves the `RCTTest` lib from `Libraries/RCTTest` to `RNTester/RCTTest`. This also removes `takeSnapshot` from React Native, and implements it as a standalone module in RNTester called `ScreenshotManager`.
    
    [General] [Removed] - RCTTest & ReactNative.takeSnapshot
    Pull Request resolved: #23721
    
    Differential Revision: D14434796
    
    Pulled By: PeteTheHeat
    
    fbshipit-source-id: d6e103a0ea0b6702701cdb5ce8449163ca4628ce
  2. Fabric: support line-through for text components (#23911)

    ericlewis authored and facebook-github-bot committed Mar 14, 2019
    Summary:
    While the proper typographical terminology is [Strikethrough](https://en.wikipedia.org/wiki/Strikethrough), we should still support `line-through` as it goes through a deprecation phase.
    
    [iOS] [Added] - line-through support for fabric text components
    Pull Request resolved: #23911
    
    Differential Revision: D14460610
    
    Pulled By: shergin
    
    fbshipit-source-id: 0dae41b765f21d166ea3618c463ebe1330607b30
  3. Fix semi-transparent backgrounds on Text components (#23872)

    ericlewis authored and facebook-github-bot committed Mar 14, 2019
    Summary:
    Fix #23849. When setting a semi-transparent background on text, it becomes obvious that we are drawing the background color twice. Since background color is handled by the view, we should not need to draw the glyph background color too.
    
    | Before        | After   |
    | ------------- |-------------|
    |<img src="https://i.imgur.com/8JGpKTC.png" width="300">     | <img src="https://imgur.com/qjKU9Ze.png" width="300">
    
    [iOS] [Fixed] - Semi-transparent backgrounds on text
    Pull Request resolved: #23872
    
    Differential Revision: D14430501
    
    Pulled By: shergin
    
    fbshipit-source-id: 19743415b2d20a3b941b1c80bd7b47144e929458
  4. Fabric: support building for 32bit archs (#23915)

    ericlewis authored and facebook-github-bot committed Mar 14, 2019
    Summary:
    Adds support for building on 32bit platforms, unlocking release mode for Xcode 💯
    
    [General] [Added] - Fabric: 32bit support
    Pull Request resolved: #23915
    
    Differential Revision: D14460600
    
    Pulled By: shergin
    
    fbshipit-source-id: ebc487546aac05d3272ae095ac321ef58f2271f6
Commits on Mar 13, 2019
  1. Silence Xcode warning (#23880)

    ericlewis authored and facebook-github-bot committed Mar 13, 2019
    Summary:
    Fixes a warning in React Xcode proj. Should be a trivial change.
    
    [iOS] [Fixed] - uncaptured lambda warning
    Pull Request resolved: #23880
    
    Differential Revision: D14435848
    
    Pulled By: cpojer
    
    fbshipit-source-id: 83c126c7401ac32b769ff17172f4f4ae576bd771
  2. Enable inline requires for RNTester (#23881)

    ericlewis authored and facebook-github-bot committed Mar 13, 2019
    Summary:
    Turns on inline requires feature for RNTester! 🏎
    
    [General] [Added] - Inline requires for RNTester
    Pull Request resolved: #23881
    
    Differential Revision: D14435862
    
    Pulled By: cpojer
    
    fbshipit-source-id: b75541d359937326178129371b6db0305731fceb
  3. Fabric: fix border memory leaks (#23815)

    ericlewis authored and facebook-github-bot committed Mar 13, 2019
    Summary:
    This fixes a few memory leaks in fabrics handling of colors for borders, when using CGColorRef's we must be diligent about releasing the memory back.
    
    [iOS] [Fixed] - Border style memory leaks
    Pull Request resolved: #23815
    
    Differential Revision: D14431250
    
    Pulled By: shergin
    
    fbshipit-source-id: dc663c633ae24809cb4841800d31a6ac6eeb8aa5
  4. Fabric: fix startSurfaceWithSurfaceId typo (#23876)

    ericlewis authored and facebook-github-bot committed Mar 13, 2019
    Summary:
    Fixes a trivial typo in `startSurfaceWithSurfaceId` method.
    
    [iOS] [Fixed] - Typo in startSurfaceWithSurfaceId
    Pull Request resolved: #23876
    
    Differential Revision: D14435111
    
    Pulled By: shergin
    
    fbshipit-source-id: 252f60cc0eec6e355fcaf0f64cb987afd8d5ec72
Commits on Mar 1, 2019
  1. Fix crash when calling substring() on a string containing emoji. (#23609

    ericlewis authored and facebook-github-bot committed Mar 1, 2019
    )
    
    Summary:
    Fixes #23459. It is not legal to write the character array of a std::string, and can result in undefined behavior.
    
    [General] [Fixed] - Crash when substring intersects with emoji
    Pull Request resolved: #23609
    
    Differential Revision: D14198159
    
    Pulled By: mdvacca
    
    fbshipit-source-id: 71060b1b99ddab89793c98c09f99ec9974479e62
Commits on Feb 25, 2019
  1. Call super if shouldDisableScrollInteraction false (#23647)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    Allow iOS to handle `touchesShouldCancelInContentView` on RCTScrollView if we aren't disabling the scroll interaction.
    
    [iOS] [Changed] - RCTScrollView allows iOS to handle touchesShouldCancelInContentView
    Pull Request resolved: #23647
    
    Differential Revision: D14214248
    
    Pulled By: hramos
    
    fbshipit-source-id: 6e1bab3085aed6cabb93fb5dc988afe3911817e8
  2. Fix xcode warnings (#23648)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    Fixes yet more Xcode warnings.
    
    [iOS] [Fixed] - Xcode warnings
    Pull Request resolved: #23648
    
    Differential Revision: D14214231
    
    Pulled By: hramos
    
    fbshipit-source-id: 050ab8519ca77941894b650b1c56bfcbe86e2c69
  3. Fix unused param warnings (#23642)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    Fixes unused warnings in RNTesterUnitTests.
    
    [iOS] [Fixed] - Fixes unused warnings in RNTesterUnitTests.
    Pull Request resolved: #23642
    
    Differential Revision: D14212036
    
    Pulled By: hramos
    
    fbshipit-source-id: 4c7ab2b0d6129267fc62dff7d8bcb394acd670ab
  4. Update openUrl (#23640)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    Fix deprecation with openUrl, handles feedback in #17011.
    
    [iOS] [Fixed] - openUrl deprecation
    Pull Request resolved: #23640
    
    Differential Revision: D14211015
    
    Pulled By: hramos
    
    fbshipit-source-id: 9c8fa9f61aaa14542af9456dc39f6bfabd6a1405
  5. Fix deadstore in RCTSpringAnimation (#23643)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    Fixes an unused storage of variable.
    
    [iOS] [Fixed] - Fix deadstore in RCTSpringAnimation
    Pull Request resolved: #23643
    
    Differential Revision: D14211089
    
    Pulled By: hramos
    
    fbshipit-source-id: 640d46be25f03d766698f6e85490c7d1a6a019fc
  6. Fix image scaling (#23641)

    ericlewis authored and facebook-github-bot committed Feb 25, 2019
    Summary:
    An updated version of: #22009, this compares the correct image size.
    
    [iOS] [Fixed] - Compare network image sizes correctly
    Pull Request resolved: #23641
    
    Differential Revision: D14210991
    
    Pulled By: hramos
    
    fbshipit-source-id: 079053ef4a8f0e62da6eead9afc8de9285b35966
Commits on Feb 22, 2019
  1. Toggle secureTextEntry cursor spacing (#23524)

    ericlewis authored and facebook-github-bot committed Feb 22, 2019
    Summary:
    This is a fix for #5859, based on the feedback in #18587. Instead of using `didSetProps` it uses a setter. I will also note that setting to `nil` no longer works (crashes) so setting it to a blank string then back to the original works fine.
    
    [iOS] [Fixed] - Toggling secureTextEntry correctly places cursor.
    Pull Request resolved: #23524
    
    Differential Revision: D14143028
    
    Pulled By: cpojer
    
    fbshipit-source-id: 5f3203d56b1329eb7359465f8ab50eb4f4fa5507
  2. Fix RNTester warnings (#23584)

    ericlewis authored and facebook-github-bot committed Feb 22, 2019
    Summary:
    Part of #22609. This brings the warning count down to 0 for the RNTester target, also adds a fancy new icon!
    
    [General] [Fixed] - All RNTester warnings fixed
    Pull Request resolved: #23584
    
    Differential Revision: D14181197
    
    Pulled By: cpojer
    
    fbshipit-source-id: 4377a55cee6a2d87a7926f1c34663b8a070aef88
  3. Refactor CameraRollView to not rely on ListView (#23517)

    ericlewis authored and facebook-github-bot committed Feb 22, 2019
    Summary:
    CameraRollView was the last remaining code in RN to use ListView, this refactor changes it to FlatList.
    
    [General] [Fixed] - CameraRollView in RNTester uses FlatList instead of ListView
    Pull Request resolved: #23517
    
    Differential Revision: D14126509
    
    Pulled By: cpojer
    
    fbshipit-source-id: b2aa03758e7c56493fb5fc59a7a0fc452b98fbc3
Commits on Feb 21, 2019
  1. Update ws dependency (#23520)

    ericlewis authored and facebook-github-bot committed Feb 21, 2019
    Summary:
    Our `ws` dependency is super outdated, and is [insecure](https://www.npmjs.com/advisories/550). It is used for the websocket example code in RNTester. This PR updates the dependency, and removes undefined console.logs.
    
    [General] [Security] - Updates ws dependency to 6.4.1
    Pull Request resolved: #23520
    
    Differential Revision: D14147596
    
    Pulled By: cpojer
    
    fbshipit-source-id: a03041f613a84bf019d8d0a8c5028d6657b5d89a
  2. Enable js e2e tests (#23571)

    ericlewis authored and facebook-github-bot committed Feb 21, 2019
    Summary:
    Part of #23561. Small refactor to use 1 marker for the different tests, as it doesn't matter where it is- so long as we can detect it.
    
    [General] [Fixed] - turn on JS e2e tests
    Pull Request resolved: #23571
    
    Differential Revision: D14172069
    
    Pulled By: hramos
    
    fbshipit-source-id: cdde369a09d3528d05fec01d015613b3397714e6
  3. Fix iOS e2e test (#23566)

    ericlewis authored and facebook-github-bot committed Feb 21, 2019
    Summary:
    As part of #23561 this is an attempt at fixing iOS.
    
    [iOS] [Fixed] - e2e test
    Pull Request resolved: #23566
    
    Differential Revision: D14162780
    
    Pulled By: cpojer
    
    fbshipit-source-id: b55d32e30f88370100f7fbddf9dfb208280844f4
  4. Fix xcode warnings (#23565)

    ericlewis authored and facebook-github-bot committed Feb 21, 2019
    Summary:
    As part of #22609, this fixes yet more warnings.
    - Adding more __unused to params.
    - Refactors `isPackagerRunning` to use NSURLSession.
    - Turns off suspicious comma warnings
    
    [iOS] [Fixed] - Xcode Warnings
    Pull Request resolved: #23565
    
    Differential Revision: D14161151
    
    Pulled By: cpojer
    
    fbshipit-source-id: 339874711eca718fc6151e84737ccc975225d736
  5. Allow compiler optimization (#23536)

    ericlewis authored and facebook-github-bot committed Feb 21, 2019
    Summary:
    Fixes a warning thrown by Xcode & allow RVO to be performed.
    
    [iOS] [Fixed] - Fix Xcode warnings
    Pull Request resolved: #23536
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D14142973
    
    Pulled By: hramos
    
    fbshipit-source-id: e23050aed811127a3b4f73aa8a74472e4cc8e98c
Commits on Feb 20, 2019
  1. Fix 50 xcode warnings (#23553)

    ericlewis authored and facebook-github-bot committed Feb 20, 2019
    Summary:
    This PR reduces the number of warnings in React from 68 to 18. Mostly by marking unused variables. RNTester's warnings are more than halved.
    
    [iOS] [Fixed] - Xcode warnings
    Pull Request resolved: #23553
    
    Differential Revision: D14151339
    
    Pulled By: hramos
    
    fbshipit-source-id: 8255330bf910a69a4c03051d91d7b0de3fadf2d1
  2. fix getPhotos params on RNTester XHR example. (#23548)

    ericlewis authored and facebook-github-bot committed Feb 20, 2019
    Summary:
    Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params.
    
    ss: https://i.imgur.com/JLThyrF.png
    
    [iOS] [Fixed] - RNTester XHR Example crash
    Pull Request resolved: #23548
    
    Differential Revision: D14151304
    
    Pulled By: hramos
    
    fbshipit-source-id: 7ff02c7fe32f09aecd50bc7df9f37b7cd2851b1c
  3. helpful error on canOpenURL for missing scheme (#23535)

    ericlewis authored and facebook-github-bot committed Feb 20, 2019
    Summary:
    iOS 9 introduced a whitelist for schemes that apps are allowed to open / check against, the current behavior of React Native is to simple return `NO` when a scheme is missing from that whitelist. It would be more helpful to throw an error with a suggested fix for the problem:
    ```
    Unable to open URL: asos://checkout, add asos to LSApplicationQueriesSchemes in Info.plist.
    ```
    
    [iOS] [Changed] - canOpenURL throws when custom scheme isn't in LSApplicationQueriesSchemes.
    Pull Request resolved: #23535
    
    Differential Revision: D14143005
    
    Pulled By: cpojer
    
    fbshipit-source-id: 4ead5f073690e627b4a4bbe3fa5a6cb5af46b589
  4. Fabric: Fix dangling brace (#23540)

    ericlewis authored and facebook-github-bot committed Feb 20, 2019
    Summary:
    This pull request fixes a dangling brace, causing Xcode to be unable to build RCTFabricSample.
    
    [General] [Fixed] - Fabric: Xcode build issue
    Pull Request resolved: #23540
    
    Differential Revision: D14142990
    
    Pulled By: hramos
    
    fbshipit-source-id: d6c2313d831e2ea5d22c77543814b86bfe8a1d53
  5. Fix testScrollViewExample flakiness (#23541)

    ericlewis authored and facebook-github-bot committed Feb 20, 2019
    Summary:
    Sometimes images are slow to load, and they are quite heavy. This converts the ScrollViewExample to a list of simple text items, similar to the append example inside of it.
    
    What it looks like: https://i.imgur.com/jt083Iv.png
    
    [iOS] [Fixed] - Fix testScrollViewExample flakiness
    Pull Request resolved: #23541
    
    Differential Revision: D14142947
    
    Pulled By: hramos
    
    fbshipit-source-id: c897a4caa5374ef67e3d67306e3124c29b969565
You can’t perform that action at this time.