Permalink
Switch branches/tags
Commits on Oct 10, 2018
  1. Update to Detox 9 (#21570)

    kelset authored and facebook-github-bot committed Oct 10, 2018
    Summary:
    Updating to Detox 9 - this should help with better Xcode 10 support, and should fix #21539.
    
    I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx) for the android native dependencies.
    
    Release Notes:
    
    [INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4
    
    Pull Request resolved: #21570
    
    Reviewed By: TheSavior
    
    Differential Revision: D10242373
    
    Pulled By: RSNara
    
    fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c
Commits on Sep 7, 2018
  1. Change the number of days to kill stales from 3 to 7 (#21015)

    kelset authored and facebook-github-bot committed Sep 7, 2018
    Summary:
    Basically, saw this commit this morning and had a chance to discuss it with matthargett and AndrewJack and overall I agree with their criticism about 3 days being too little time for people to react to it.
    Pull Request resolved: #21015
    
    Differential Revision: D9721393
    
    Pulled By: hramos
    
    fbshipit-source-id: 524c0b87987a8b76fa8d5e223fb5ed5a56a8c648
Commits on Jul 31, 2018
  1. Update Discussion template (#20469)

    kelset authored and facebook-github-bot committed Jul 31, 2018
    Summary:
    Quick PR to point the users to the new dedicated repo.
    Pull Request resolved: #20469
    
    Differential Revision: D9082493
    
    Pulled By: hramos
    
    fbshipit-source-id: b1e0a2a38adcc3920596ded251e95545f88502f7
Commits on Nov 29, 2017
  1. Update Performance.md

    kelset authored and facebook-github-bot committed Nov 29, 2017
    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Removing the `react-addons-perf` reference since now RN relies on React 16, and it's not [supported anymore](https://reactjs.org/docs/perf.html).
    
    Nothing to test.
    
    [DOCS] [BUGFIX] [Performance.md] removing old reference in the doc.
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #17004
    
    Differential Revision: D6434107
    
    Pulled By: hramos
    
    fbshipit-source-id: 7080c8054072ffb3e2ea58dcb89997585a5d5833