Skip to content
Permalink
Branch: master
Commits on May 16, 2019
  1. Adding @nullable into Fabric UI Manager

    mdvacca authored and facebook-github-bot committed May 16, 2019
    Summary: cleanup diff to add Nullable annotations into Fabric UI Manager classes
    
    Reviewed By: shergin
    
    Differential Revision: D15365295
    
    fbshipit-source-id: b9d39addd5b71377389a7687ea3176cd4359c5ba
Commits on May 10, 2019
  1. Ensures constraintSurfaceLayout is executed before 'JS run applicatio…

    mdvacca authored and facebook-github-bot committed May 10, 2019
    …n' starts
    
    Summary:
    This diff ensures the method scheduler.constraintSurfaceLayout is executed before the JS run application start.
    This is necessary to properly set the pointScaleFactor for the Root before running JS.
    
    This is a workaround to fix a bug when the pointScaleFactor changes over time for the rootShadowNode. The bug is easily reproducible when rendering the "fabric" indicator on Fabric screens. During the first render of a Fabric screen this method was called before "JS run application" starts, and the Fabric indicator was render correctly.
    Beacuse of timing of measure APIS, the second time a Fabric screen is rendered the method is called after the "JS run application process started", as a consecuence the Fabric indicator is not rendered correctlly (the pointScaleFactor is incorrectly assigned into the layout metrics of the Fabric indicator text).
    
    We still need to analyze why the pointScaleFactor is not correctly assigned when it is set after the "JS run application process started", but this will be part of another diff.
    
    Reviewed By: shergin
    
    Differential Revision: D15303554
    
    fbshipit-source-id: 7d985cefee20fd40dbe04166c1a1358b3f3ddc85
  2. Include pointScaleFactor into the equality method of LayoutMetrics

    mdvacca authored and facebook-github-bot committed May 10, 2019
    Summary:
    Previously the pointScaleFactor field was not being compared properly in LayoutMetrics equality method.
    This diff fixes that
    
    Reviewed By: shergin
    
    Differential Revision: D15303555
    
    fbshipit-source-id: 8863e9e1fbad15b43400afc32b97bf6d252cbe55
Commits on May 9, 2019
  1. Replace abort() with assert() when a prop-value is not found during p…

    mdvacca authored and facebook-github-bot committed May 9, 2019
    …arsing
    
    Summary: This diff replaces usage of abort() with assert() when a prop-value is not found during parsing of prop values
    
    Reviewed By: shergin
    
    Differential Revision: D14563338
    
    fbshipit-source-id: c799420e6b49df35e1d7ccdbd4bc4845067d33cc
Commits on May 4, 2019
  1. Eager initialize more Fabric classes

    mdvacca authored and facebook-github-bot committed May 4, 2019
    Summary:
    This diff forces the eager initialization of some additional classes into FabricJSIModuleProvider.loadClasses().
    This is a "hack" that will be removed in the near future
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D15208977
    
    fbshipit-source-id: 2e2c7856839b6c6888452800ef6da7f269e46735
Commits on May 3, 2019
  1. Refactor Virtualized List to not use findNodeHandle when calling meas…

    mdvacca authored and facebook-github-bot committed May 3, 2019
    …ureLayout
    
    Summary:
    In fabric, the measureLayout method expects 'node ref' instead of 'node handle'.
    Node refs are supported by the current production version of RN and for Fabric, no changes should be expected in the current production version of RN
    
    Reviewed By: TheSavior
    
    Differential Revision: D15103116
    
    fbshipit-source-id: cde94f61eaf6aa52ae4bd6f89082d18141d0da28
  2. React sync for revisions 8e25ed2...ec6691a

    mdvacca authored and facebook-github-bot committed May 3, 2019
    Summary:
    This sync includes the following changes:
    - **[ec6691a68](facebook/react@ec6691a )**: Event API: remove isTargetDirectlyWithinEventComponent (#15546) //<Dominic Gannaway>//
    - **[a6e30001f](facebook/react@a6e3000 )**: Delete duplicate Focus.js (#15540) //<Dominic Gannaway>//
    - **[f7993d547](facebook/react@f7993d5 )**: Delete duplicate Hover.js (#15539) //<Dominic Gannaway>//
    - **[c8ee10037](facebook/react@c8ee100 )**: Delete duplicate Swipe.js (#15541) //<Dominic Gannaway>//
    - **[494716c9b](facebook/react@494716c )**: Delete duplicate Drag.js (#15537) //<Dominic Gannaway>//
    - **[377846fef](facebook/react@377846f )**: Delete duplicate Press.js (#15538) //<Dominic Gannaway>//
    - **[379515e83](facebook/react@379515e )**: Follow up to 15535 (#15536) //<Dominic Gannaway>//
    - **[bd88982fb](facebook/react@bd88982 )**: Event API: use `capture` for all event listeners using experimental responder system (#15526) //<Dominic Gannaway>//
    - **[72ca3c60e](facebook/react@72ca3c6 )**: Bump scheduler version to 0.14.0 (#15395) //<Andrew Clark>//
    - **[7882c41f6](facebook/react@7882c41 )**: Use lowercase entry points for event modules (#15535) //<Andrew Clark>//
    - **[43c4e5f34](facebook/react@43c4e5f )**: Add method for forcing a lower framerate //<Nathan Schloss>//
    - **[1b752f191](facebook/react@1b752f1 )**: Fixed potential interaction tracing leak in Suspense thennable memoization (#15531) //<Brian Vaughn>//
    - **[12e5a13cf](facebook/react@12e5a13 )**: [React Native] Inline calls to FabricUIManager in shared code (#15490) //<Eli White>//
    - **[2cca18728](facebook/react@2cca187 )**: React Events: add onFocusVisibleChange to Focus (#15516) //<Nicolas Gallagher>//
    - **[cc5a49379](facebook/react@cc5a493 )**: React Events: FocusScope tweaks and docs (#15515) //<Nicolas Gallagher>//
    - **[796c67a25](facebook/react@796c67a )**: Event API: responder event types should not re-register on EventComponent update (#15514) //<Dominic Gannaway>//
    - **[c4d1dcb53](facebook/react@c4d1dcb )**: React Events: core API documentation followup (#15506) //<Dominic Gannaway>//
    - **[41ef1961c](facebook/react@41ef196 )**: Update TopLevelEventTypes.js (#15511) //<Dan Nate>//
    - **[7a482af5d](facebook/react@7a482af )**: Event API: Fix bug where Press root events were not being cleared (#15507) //<Dominic Gannaway>//
    - **[a14e24efa](facebook/react@a14e24e )**: React Events: core API documentation (#15505) //<Nicolas Gallagher>//
    - **[8658611b6](facebook/react@8658611 )**: Event API: ensure event keys are unique + add validation (#15501) //<Dominic Gannaway>//
    - **[d9839740e](facebook/react@d983974 )**: React events: remove unused types (#15503) //<Nicolas Gallagher>//
    - **[0b3431170](facebook/react@0b34311 )**: React events: fix press end event dispatching (#15500) //<Nicolas Gallagher>//
    - **[d1f667acc](facebook/react@d1f667a )**: Event API: follow up fixes for FocusScope + context changes (#15496) //<Dominic Gannaway>//
    - **[c530639dd](facebook/react@c530639 )**: Minor code structure adjustments to the bundles.js file (#15079) //<Kunuk Nykjær>//
    - **[ed36df46c](facebook/react@ed36df4 )**: add --watch mode to "yarn build" (#15116) //<Alec Larson>//
    - **[793ef9b85](facebook/react@793ef9b )**: test(eslint-plugin-react-hooks): add coverage for unused custom hook (#15130) //<Redmond Tran>//
    - **[d61da9387](facebook/react@d61da93 )**: test(accumulate): add test suite for accumulate function (#15159) //<Jeffrey Berry>//
    - **[a187e9b5e](facebook/react@a187e9b )**: React Native: Allow Views to be nested inside of Text (#15464) //<Adam Comella>//
    - **[f85aadefc](facebook/react@f85aade )**: ADD: disablePictureInPicture attribute for HTML5 videos (#15334) //<Radu-Sebastian Amarie>//
    - **[1eb2b892d](facebook/react@1eb2b89 )**: give  `canUseDOM` with a possibility to be a constant (#14194) //<FUJI Goro>//
    - **[de26d6dd3](facebook/react@de26d6d )**: typo fix (#15493) //<shubham>//
    - **[64e3da286](facebook/react@64e3da2 )**: Event API: Add `FocusScope` surface (#15487) //<Dominic Gannaway>//
    - **[3f058debc](facebook/react@3f058de )**: Event API: various bug fixes (#15485) //<Dominic Gannaway>//
    - **[fb28e9048](facebook/react@fb28e90 )**: Add missing word to code comment for clarity (#15443) //<Brendan McLoughlin>//
    - **[fa2fa3564](facebook/react@fa2fa35 )**: Experimental event API: adds context.isTargetDirectlyWithinEventComponent (#15481) //<Dominic Gannaway>//
    - **[d3af2f2a5](facebook/react@d3af2f2 )**: Experimental Event API: add event component mount phase callback (#15480) //<Dominic Gannaway>//
    - **[ce126fbb2](facebook/react@ce126fb )**: Fix priority inference of next level of work (#15478) //<Andrew Clark>//
    - **[71c8759ce](facebook/react@71c8759 )**: Measure callback timeout relative to current time (#15479) //<Andrew Clark>//
    - **[9c6ff136c](facebook/react@9c6ff13 )**: Remove timeout from performance flamegraph (#15477) //<Andrew Clark>//
    - **[299a2714c](facebook/react@299a271 )**: Use stricter equality check (#15474) //<Dan Abramov>//
    - **[017d6f14b](facebook/react@017d6f1 )**: Experimental Event API: add `rootEventTypes` support to event responders (#15475) //<Dominic Gannaway>//
    - **[784ebd8fa](facebook/react@784ebd8 )**: Experimental event API: rework the propagation system for event components (#15462) //<Dominic Gannaway>//
    - **[587676900](facebook/react@5876769 )**: React events: initial implementation of disabled prop (#15458) //<Nicolas Gallagher>//
    - **[59c7aef91](facebook/react@59c7aef )**: React events: add a test for focusable descendants (#15457) //<Nicolas Gallagher>//
    - **[0a8da3391](facebook/react@0a8da33 )**: React events: README update types and remove stopPropagation prop (#15456) //<Nicolas Gallagher>//
    - **[d584fcdc6](facebook/react@d584fcd )**: React events: use passive events where possible (#15454) //<Nicolas Gallagher>//
    - **[051513bfa](facebook/react@051513b )**: React Events: consolidate logic for Press event component (#15451) //<Nicolas Gallagher>//
    - **[cdfce1ad2](facebook/react@cdfce1a )**: React events: consolidate logic of Hover event component (#15450) //<Nicolas Gallagher>//
    - **[5857c89da](facebook/react@5857c89 )**: React events: extract common helper functions (#15449) //<Nicolas Gallagher>//
    - **[0b50fb29f](facebook/react@0b50fb2 )**: Include rootEventTypes in DOMEventResponderSystem stopPropagation tests (#15433) //<Nicolas Gallagher>//
    - **[1ae409d2c](facebook/react@1ae409d )**: React events: fix nested Hover components error (#15428) //<Nicolas Gallagher>//
    - **[c73ab39c1](facebook/react@c73ab39 )**: React events: make nested Focus work as expected (#15421) //<Nicolas Gallagher>//
    - **[4221565e1](facebook/react@4221565 )**: Cancel pending commit before starting on root //<Andrew Clark>//
    - **[9ebe1768a](facebook/react@9ebe176 )**: Experimental Event API: Redesign event responder propagation (#15408) //<Dominic Gannaway>//
    - **[a30e7d992](facebook/react@a30e7d9 )**: act() tests - Reuse and properly unmount containers (#14974) //<Philipp Spiess>//
    - **[8cf963c6c](facebook/react@8cf963c )**: React events: ignore device buttons that aren't for primary interactions (#15402) //<Nicolas Gallagher>//
    - **[38bd570d4](facebook/react@38bd570 )**: Stop tracking bundle sizes (#15404) //<Andrew Clark>//
    - **[3438e5ce8](facebook/react@3438e5c )**: Experimental Event API: Add Hover onUnmount support (#15394) //<Dominic Gannaway>//
    - **[805e7f873](facebook/react@805e7f8 )**: React events: add unmounting to Focus (#15396) //<Nicolas Gallagher>//
    - **[543353a04](facebook/react@543353a )**: Experimental Event API: Remove "listener" from event objects (#15391) //<Dominic Gannaway>//
    - **[9055e31e5](facebook/react@9055e31 )**: Replace old Fiber Scheduler with new one (#15387) //<Andrew Clark>//
    - **[4e59d4f5d](facebook/react@4e59d4f )**: React events: add onHoverMove support (#15388) //<Nicolas Gallagher>//
    - **[de7590327](facebook/react@de75903 )**: Fix CI (#15393) //<Andrew Clark>//
    - **[687e4fb6f](facebook/react@687e4fb )**: Bump scheduler version to 0.14.0 //<Andrew Clark>//
    - **[45473c94c](facebook/react@45473c9 )**: React events: Press event fixes (#15386) //<Nicolas Gallagher>//
    - **[9672cf621](facebook/react@9672cf6 )**: Experimental Event API: adds `stopPropagation` by default to Press (#15384) //<Dominic Gannaway>//
    - **[a9eff329c](facebook/react@a9eff32 )**: Remove TouchHitTarget SSR logic to prevent issues with mouse events (#15381) //<Dominic Gannaway>//
    - **[c9841001b](facebook/react@c984100 )**: Experimental Event API: preventDefault handling for anchors (#15383) //<Dominic Gannaway>//
    - **[c25c59c80](facebook/react@c25c59c )**: Apply the Just Noticeable Difference to suspense timeouts (#15367) //<Sebastian Markbåge>//
    - **[3e2e930d6](facebook/react@3e2e930 )**: Fixes a Flow type merge conflict (#15378) //<Dominic Gannaway>//
    - **[7fc91f17c](facebook/react@7fc91f1 )**: React events: add onPressMove and pressRetentionOffset to Press (#15374) //<Nicolas Gallagher>//
    - **[dd9cef9fc](facebook/react@dd9cef9 )**: Experimental Event API: Add targets and responder utility method for finding targets (#15372) //<Dominic Gannaway>//
    - **[c64b33003](facebook/react@c64b330 )**: Move EventTypes to ReactTypes (#15364) //<Dominic Gannaway>//
    - **[4c78ac0b9](facebook/react@4c78ac0 )**: Track Event Time as the Start Time for Suspense (#15358) //<Sebastian Markbåge>//
    - **[875d05d55](facebook/react@875d05d )**: Include full error messages in React Native build (#15363) //<Andrew Clark>//
    - **[1b2159acc](facebook/react@1b2159a )**: [React Native] measure calls will now call FabricUIManager (#15324) //<Eli White>//
    - **[c7a959982](facebook/react@c7a9599 )**: [React Native] Add tests to paper renderer for measure, measureLayout (#15323) //<Eli White>//
    - **[aece8119c](facebook/react@aece811 )**: Refactor EventComponent logic + add onOwnershipChange callback (#15354) //<Dominic Gannaway>//
    - **[183d1f42e](facebook/react@183d1f4 )**: Fix: Measure expiration times relative to module initialization (#15357) //<Andrew Clark>//
    - **[b4bc33a58](facebook/react@b4bc33a )**: Fix areHookInputsEqual method  warning params order (#15345) //<砖家>//
    - **[29fb5862f](facebook/react@29fb586 )**: Move EventComponent state creation to complete phase + tests (#15352) //<Dominic Gannaway>//
    - **[745baf2e0](facebook/react@745baf2 )**: Provide new jsx transform target for reactjs/rfcs#107 (#15141) //<Ricky Vetter>//
    - **[81a61b1d1](facebook/react@81a61b1 )**: React events: add delay props to Press module (#15340) //<Nicolas Gallagher>//
    - **[4064ea9fa](facebook/react@4064ea9 )**: Experimental event API: Support EventComponent onUnmount responder callback (#15335) //<Dominic Gannaway>//
    - **[4fbbae8af](facebook/react@4fbbae8 )**: Add full TouchHitTarget hit slop (experimental event API) to ReactDOM (#15308) //<Dominic Gannaway>//
    - **[958b6173f](facebook/react@958b617 )**: Add delay props to Hover event module (#15325) //<Nicolas Gallagher>//
    - **[c3cc936da](facebook/react@c3cc936 )**: Add Hover,Focus,Press docs to REAMDE (#15328) //<Nicolas Gallagher>//
    - **[49595e921](facebook/react@49595e9 )**: [New Scheduler] Fix: Suspending an expired update (#15326) //<Andrew Clark>//
    - **[b93a8a9bb](facebook/react@b93a8a9 )**: Experimental event API: refactor responder modules for lifecycle inclusion (#15322) //<Dominic Gannaway>//
    - **[937d262f5](facebook/react@937d262 )**: React events: keyboard press, types, tests (#15314) //<Nicolas Gallagher>//
    - **[7a2dc4853](facebook/react@7a2dc48 )**: Allow DevTools to toggle Suspense fallbacks (#15232) //<Dan Abramov>//
    - **[43b1f74c8](facebook/react@43b1f74 )**: Alternate fix for #14198 //<Andrew Clark>//
    - **[41aa345d2](facebook/react@41aa345 )**: Fix a crash in Suspense with findDOMNode //<Dan Abramov>//
    - **[6d0effad7](facebook/react@6d0effa )**: Expose extra internals in FB build of react-dom/unstable-new-scheduler (#15311) //<Andrew Clark>//
    - **[3a44ccefe](facebook/react@3a44cce )**: Fix feature flags react-dom/unstable-new-scheduler (#15309) //<Andrew Clark>//
    - **[92a1d8fea](facebook/react@92a1d8f )**: mark react-events as private so we publish script skips it for now (#15307) //<Sunil Pai>//
    - **[e5c59359c](facebook/react@e5c5935 )**: Prevent bundling of Node polyfills when importing TestUtils/TestRenderer (#15305) //<Dan Abramov>//
    - **[73187239a](facebook/react@7318723 )**: writing unit tests in experimental event Drag API (#15297) //<Behzad Abbasi>//
    - **[89064fe68](facebook/react@89064fe )**: Adds displayName to EventComponent and EventTarget (#15268) //<Dominic Gannaway>//
    - **[fc6a9f1a1](facebook/react@fc6a9f1 )**: Add test for async event dispatching (#15300) //<Nicolas Gallagher>//
    - **[38fa84088](facebook/react@38fa840 )**: Experiemental event API - wrap async dispatched events (#15299) //<Dominic Gannaway>//
    - **[4d5cb64aa](facebook/react@4d5cb64 )**: Rewrite ReactFiberScheduler for better integration with Scheduler package (#15151) //<Andrew Clark>//
    - **[aed0e1c30](facebook/react@aed0e1c )**: await act(async () => ...) (#14853) //<Sunil Pai>//
    - **[4c75881ee](facebook/react@4c75881 )**: Remove maxDuration from tests (#15272) //<Sebastian Markbåge>//
    - **[9307932fe](facebook/react@9307932 )**: Refactor event object creation for the experimental event API (#15295) //<Dominic Gannaway>//
    - **[6a1e6b2f7](facebook/react@6a1e6b2 )**: Experimental event API: loosen EventTarget constraints and warnings (#15292) //<Dominic Gannaway>//
    - **[f243deab8](facebook/react@f243dea )**: Add tests for Press responder event module (#15290) //<Nicolas Gallagher>//
    - **[296c4393d](facebook/react@296c439 )**: Add Press event prop types and fix a check in Safari (#15288) //<Nicolas Gallagher>//
    - **[4482fdded](facebook/react@4482fdd )**: Fix host context issues around EventComponents and EventTargets (#15284) //<Dominic Gannaway>//
    - **[5ef0d1d29](facebook/react@5ef0d1d )**: Rename hover props in experimental event API and write unit tests (#15283) //<Behzad Abbasi>//
    - **[9444a5472](facebook/react@9444a54 )**: Warn on nested EventTragets in experimental event API (#15287) //<Dominic Gannaway>//
    - **[7f1f5ddc3](facebook/react@7f1f5dd )**: Rename press props in experimental event API (#15263) //<Nicolas Gallagher>//
    - **[2e02469fa](facebook/react@2e02469 )**: ReactNative's ref.measureLayout now takes a ref (#15126) //<Eli White>//
    - **[1b94fd215](facebook/react@1b94fd2 )**: Make setNativeProps a no-op with Fabric renderer (#15094) //<Eli White>//
    - **[08055a625](facebook/react@08055a6 )**: Fix Press module in experimental event API (#15262) //<Nicolas Gallagher>//
    - **[f4625f518](facebook/react@f4625f5 )**: Fix on(Long)PressChange events in experimental press event API (#15256) //<Nicolas Gallagher>//
    - **[a41b21770](facebook/react@a41b217 )**: Add additional event API responder surfaces (#15248) //<Dominic Gannaway>//
    - **[700f17be6](facebook/react@700f17b )**: Fix longpress in experimental Press event module (#15246) //<Nicolas Gallagher>//
    - **[5d336df70](facebook/react@5d336df )**: Allow for null targetFiber for root event handling (#15247) //<Dominic Gannaway>//
    - **[c6f3524df](facebook/react@c6f3524 )**: Adds React event component and React event target support to SSR renderer (#15242) //<Dominic Gannaway>//
    - **[c7a2dce50](facebook/react@c7a2dce )**: Disable JS urls at build level for www (#15230) //<Sebastian Markbåge>//
    - **[fb6b50871](facebook/react@fb6b508 )**: Update versions for 16.8.6 //<Dan Abramov>//
    - **[1cfd25668](facebook/react@1cfd256 )**: Fix circular module imports causing file size increase (#15231) //<Dominic Gannaway>//
    - **[669cafb36](facebook/react@669cafb )**: Adds experimental event component responder surfaces (#15228) //<Dominic Gannaway>//
    - **[d8cb10f11](facebook/react@d8cb10f )**: Enabled warnAboutDeprecatedLifecycles flag by default (#15186) //<Brian Vaughn>//
    - **[80f8b0d51](facebook/react@80f8b0d )**: Add part of the event responder system for experimental event API (#15179) //<Dominic Gannaway>//
    - **[5c2b2c085](facebook/react@5c2b2c0 )**: Warn about async infinite useEffect loop (#15180) //<Dan Abramov>//
    - **[8e9a013c0](facebook/react@8e9a013 )**: Release 16.8.5 //<Dan Abramov>//
    - **[f33e5790b](facebook/react@f33e579 )**: eslint-plugin-react-hooks@1.6.0 //<Dan Abramov>//
    - **[b1cccd1ed](facebook/react@b1cccd1 )**: Warn about setState directly in dep-less useEffect (#15184) //<Dan Abramov>//
    - **[78f2775ed](facebook/react@78f2775 )**: Flip event passive logic on passiveBrowserEventsSupported (#15190) //<Dominic Gannaway>//
    - **[f161ee2eb](facebook/react@f161ee2 )**: React.warn() and React.error() (#15170) //<Brian Vaughn>//
    - **[78968bb3d](facebook/react@78968bb )**: Validate useEffect without deps too (#15183) //<Dan Abramov>//
    - **[4b8e1641b](facebook/react@4b8e164 )**: Fork performWork instead of using boolean flag (#15169) //<Sebastian Markbåge>//
    - **[56035dac6](facebook/react@56035da )**: unstable_Profiler -> Profiler (#15172) //<Brian Vaughn>//
    - **[31518135c](facebook/react@3151813 )**: Strengthen nested update counter test coverage (#15166) //<Dan Abramov>//
    - **[66f280c87](facebook/react@66f280c )**: Add internal logic for listening to event responders (#15168) //<Dominic Gannaway>//
    - **[b1a56abd6](facebook/react@b1a56ab )**: Fork ReactFiberScheduler with feature flag //<Andrew Clark>//
    - **[45f571736](facebook/react@45f5717 )**: ReactFiberScheduler -> ReactFiberScheduler.old //<Andrew Clark>//
    - **[c05b4b81f](facebook/react@c05b4b8 )**: Link to useLayoutEffect gist in a warning (#15158) //<Dan Abramov>//
    - **[061d6ce3c](facebook/react@061d6ce )**: fix(react-dom): access iframe contentWindow instead of contentDocument (#15099) //<Renan Valentin>//
    - **[b83e01cad](facebook/react@b83e01c )**: Adds more scaffolding for experimental event API (#15112) //<Dominic Gannaway>//
    - **[daeda44d8](facebook/react@daeda44 )**: Follow up to 15150 (#15152) //<Dominic Gannaway>//
    - **[acd65db5b](facebook/react@acd65db )**: Deprecate module pattern (factory) components (#15145) //<Sebastian Markbåge>//
    - **[55cc921c5](facebook/react@55cc921 )**: Adds react-events package for internal testing (#15150) //<Dominic Gannaway>//
    - **[7ad738630](facebook/react@7ad7386 )**: Improve warning for invalid class contextType (#15142) //<Dan Abramov>//
    - **[1e3364e76](facebook/react@1e3364e )**: Test that we don't suspend when disabling yielding (#15143) //<Sebastian Markbåge>//
    - **[42c3c967d](facebook/react@42c3c96 )**: Compile invariant directly to throw expressions (#15071) //<Andrew Clark>//
    - **[df7b87d25](facebook/react@df7b87d )**: Warn for Context.Consumer with contextType (#14831) //<Brandon Dail>//
    - **[2b93d686e](facebook/react@2b93d68 )**: Add more info to invalid hook call error message (#15139) //<Jared Palmer>//
    - **[d926936f0](facebook/react@d926936 )**: Eager bailout optimization should always compare to latest reducer (#15124) //<Andrew Clark>//
    - **[4162f6026](facebook/react@4162f60 )**: Add feature flag to disable yielding (#15119) //<Sebastian Markbåge>//
    - **[8d60bd4dc](facebook/react@8d60bd4 )**: [Shallow] Implement setState for Hooks and remount on type change (#15120) //<Dan Abramov>//
    - **[035e4cffb](facebook/react@035e4cf )**: Change passive checker to use defineProperty (#15121) //<Dominic Gannaway>//
    - **[b283d75c1](facebook/react@b283d75 )**: Support React.memo in ReactShallowRenderer (#14816) //<Brandon Dail>//
    - **[f0621fe23](facebook/react@f0621fe )**: Use same example code for async effect warning (#15118) //<Dan Abramov>//
    - **[52c870c8d](facebook/react@52c870c )**: Fix shallow renderer not allowing hooks in forwardRef render functions (#15100) //<Sebastian Silbermann>//
    - **[f1ff4348c](facebook/react@f1ff434 )**: Don't suggest a function as its own dep (#15115) //<Dan Abramov>//
    - **[371bbf36b](facebook/react@371bbf3 )**: Add infrastructure for passive/non-passive event support for future API exploration (#15036) //<Dominic Gannaway>//
    - **[ab5fe174c](facebook/react@ab5fe17 )**: Don't set the first option as selected in select tag with `size` attribute  (#14242) //<Mateusz>//
    - **[935f60083](facebook/react@935f600 )**: eslint-plugin-react-hooks@1.5.1 //<Dan Abramov>//
    - **[0c03a4743](facebook/react@0c03a47 )**: Adds experimental event API scaffolding (#15108) //<Dominic Gannaway>//
    - **[1204c7897](facebook/react@1204c78 )**: [eslint] Wording tweaks (#15078) //<Sophie Alpert>//
    - **[9d77a317b](facebook/react@9d77a31 )**: Improve async useEffect warning (#15104) //<Dan Abramov>//
    - **[103378b1e](facebook/react@103378b )**: Warn for javascript: URLs in DOM sinks (#15047) //<Sebastian Markbåge>//
    - **[5d0c3c6c7](facebook/react@5d0c3c6 )**: [Partial Hydration] Render client-only content at normal priority (#15061) //<Sebastian Markbåge>//
    - **[6a4a261ee](facebook/react@6a4a261 )**: Test suspended children are hidden before layout in persistent mode (#15030) //<Andrew Clark>//
    - **[bc8bd24c1](facebook/react@bc8bd24 )**: Run persistent mode tests in CI (#15029) //<Andrew Clark>//
    - **[3f4852fa5](facebook/react@3f4852f )**: Run Placeholder tests in persistent mode, too (#15013) //<Andrew Clark>//
    - **[d0289c7e3](facebook/react@d0289c7 )**: eslint-plugin-react-hooks@1.5.0 //<Dan Abramov>//
    - **[03ad9c73e](facebook/react@03ad9c7 )**: [ESLint] Tweak setState updater message and add useEffect(async) warning (#15055) //<Dan Abramov>//
    - **[eb6247a9a](facebook/react@eb6247a )**: More concise messages (#15053) //<Dan Abramov>//
    - **[197703ecc](facebook/react@197703e )**: [ESLint] Add more hints to lint messages (#15046) //<Dan Abramov>//
    - **[6d2666bab](facebook/react@6d2666b )**: Fix ESLint rule crash (#15044) //<Dan Abramov>//
    - **[9b7e1d138](facebook/react@9b7e1d1 )**: [ESLint] Suggest moving inside a Hook or useCallback when bare function is a dependency (#15026) //<Dan Abramov>//
    - **[1e3b6192b](facebook/react@1e3b619 )**: Import Scheduler directly, not via host config (#14984) //<Andrew Clark>//
    - **[5d49dafac](facebook/react@5d49daf )**: Enforce deps array in useMemo and useCallback (#15025) //<Dan Abramov>//
    - **[a9aa24ed8](facebook/react@a9aa24e )**: 16.8.4 and changelog //<Brian Vaughn>//
    - **[fa5d4ee43](facebook/react@fa5d4ee )**: [ESLint] Treat functions that don't capture anything as static (#14996) //<Dan Abramov>//
    - **[fd557d453](facebook/react@fd557d4 )**: Warn on mount when deps are not an array (#15018) //<Dan Abramov>//
    - **[ce45ca9ba](facebook/react@ce45ca9 )**: Prettier //<Andrew Clark>//
    - **[757a70b25](facebook/react@757a70b )**: ReactNoop.yield -> Scheduler.yieldValue (#15008) //<Andrew Clark>//
    - **[9d756d903](facebook/react@9d756d9 )**: Revert #14756 changes to ReactFiberScheduler (#14992) //<Andrew Clark>//
    - **[f16442a10](facebook/react@f16442a )**: eslint-plugin-react-hooks@1.4.0 //<Dan Abramov>//
    - **[e1e45fb36](facebook/react@e1e45fb )**: [ESLint] Suggest to destructure props when they are only used as members (#14993) //<Dan Abramov>//
    - **[59ef28437](facebook/react@59ef284 )**: Warn about dependencies outside of render scope (#14990) //<Dan Abramov>//
    - **[df7b4768c](facebook/react@df7b476 )**: [ESLint] Deduplicate suggested dependencies (#14982) //<Dan Abramov>//
    - **[02404d793](facebook/react@02404d7 )**: Avoid dynamic dispatch for scheduler calls (#14968) //<Dan Abramov>//
    - **[bb2939ccc](facebook/react@bb2939c )**: Support editable useState hooks in DevTools (#14906) //<Brian Vaughn>//
    - **[69060e1da](facebook/react@69060e1 )**: Swap expect(ReactNoop) for expect(Scheduler) (#14971) //<Andrew Clark>//
    - **[ccb2a8a44](facebook/react@ccb2a8a )**: Replace test renderer's fake Scheduler implementation with mock build (#14970) //<Andrew Clark>//
    - **[53e787b45](facebook/react@53e787b )**: Replace noop's fake Scheduler implementation with mock Scheduler build (#14969) //<Andrew Clark>//
    - **[3ada82b74](facebook/react@3ada82b )**: Allow extraneous effect dependencies (#14967) //<Dan Abramov>//
    - **[00748c53e](facebook/react@00748c5 )**: Add new mock build of Scheduler with flush, yield API (#14964) //<Andrew Clark>//
    - **[4186952a6](facebook/react@4186952 )**: Fixed incompatibility between react-debug-tools and useContext() (#14940) //<Brian Vaughn>//
    - **[0b8efb229](facebook/react@0b8efb2 )**: Allow omitting constant primitive deps (#14959) //<Dan Abramov>//
    
    Changelog:
    [General][Changed] - React sync for revisions 8e25ed2...ec6691a
    
    Follow steps in the [React Native test plan](https://our.intern.facebook.com/intern/dex/react/test-workflows-react-native/).
    
    Reviewed By: shergin
    
    Differential Revision: D15171103
    
    fbshipit-source-id: d16b54dfd575b3a1fa38e6a132633f42c715b4fd
Commits on May 1, 2019
  1. Expose first implementation of the legacy method UIManager.measureInW…

    mdvacca authored and facebook-github-bot committed May 1, 2019
    …indow on Fabric
    
    Summary: This diff exposes the Legacy method UIManager.measureInWindow as part of Fabric
    
    Reviewed By: shergin
    
    Differential Revision: D15110795
    
    fbshipit-source-id: 2b4bf47452f7272fd3edc4e580e65ae7ec2f2622
Commits on Apr 30, 2019
  1. Expose measureLayout in UIManagerBinding.cpp

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: This diff exposes the Legacy method UIManager.measureLayout as part of Fabric
    
    Reviewed By: shergin
    
    Differential Revision: D15103117
    
    fbshipit-source-id: 4cf7ab3776f6a541cf0d6a00789420a0bb008fae
  2. Migrate VirtualizedList to use ref.measureLayout

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: This diff migrates VirtualizedList to use ref.measureLayout instead of UIManager.measureLayout, this is a pre-req to make measureLayout to work in Fabric
    
    Reviewed By: JoshuaGross, TheSavior
    
    Differential Revision: D14865762
    
    fbshipit-source-id: 45dd3374813370188c914acfc7e631075508f74a
  3. Add debug information in Mounting Manager

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: Easy diff that adds debug information in Mounting Manager
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D15076577
    
    fbshipit-source-id: 183c87c929ea7a99f0667956c33012d7dfdb246e
  4. Refactor mapping of ComponentNames in FabricUIManager

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: The map of sComponentNames ONLY contains the names of components that are different between JS and Android. This diff adds a method to unify the way we use this map.
    
    Reviewed By: shergin
    
    Differential Revision: D15076549
    
    fbshipit-source-id: 9df750dca305e55cb44037bc63f3ebb6476c8b81
  5. Add support for Modal in Android

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: This diff implements Modal for Android in Fabric
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D15069863
    
    fbshipit-source-id: 4171c9590a4a7a1f4f80cf9b08ea9a9e94b9097a
  6. Update styles of Modal container as a pre-requisite to implement Moda…

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    …l on Fabric
    
    Summary:
    This diff changes the style of the Modal container style as a pre-requisite to implement Modal on Fabric.
    In the current version of React Native the size of the View container is determined at runtime using the size of the screen. The size of this view is set overriding the Widht and Height of this Container View (using the screen size), in Fabric we can not update the size of that view, instead we set the size of the RCTModalHostView to take the size of the whole screen.
    Since the RCTModalHostView has an absolute position and it has the size of the screen, making this change should be enough to keep backward compatibility and be able to implement Modal on Fabric
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D15067616
    
    fbshipit-source-id: d7302ef3afc503adfee10e12fb6d0ebd371fb7ed
  7. Display wrong view hierarchy in Test exceptions

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: Trivial diff that adds extra logging information on Exceptions that are thrown by the FabricViewTest
    
    Reviewed By: shergin
    
    Differential Revision: D14817899
    
    fbshipit-source-id: 32e1d1fcd1292715dfcf2750d3f14c668927c8b8
  8. - Fix mounting of views when a re-order happen caused by changes in v…

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    …iewflattening
    
    Summary:
    This diff fixes a bug that is reproducible when a view is reordered in a different level of hierarchy in the react tree.
    Even if this is not supported by react, this can still happen because of viewFlattening.
    
    Reviewed By: shergin
    
    Differential Revision: D14817452
    
    fbshipit-source-id: 13425b0e6a280affe681e80b4a6daa17ee56251a
  9. Add component schema for Modal

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: This diff adds the spec for Modal components
    
    Reviewed By: rickhanlonii
    
    Differential Revision: D14886904
    
    fbshipit-source-id: 32d54c34e55c4d66338e13f34c2b6ed1e3cfbba7
  10. Ensure proper Synchronization on ReactChoreographer

    mdvacca authored and facebook-github-bot committed Apr 30, 2019
    Summary: This diff refactors the way we synchronize in ReactChoreographer using a lock object
    
    Reviewed By: ejanzer
    
    Differential Revision: D14913056
    
    fbshipit-source-id: e86c4395d5d3c3fd5b7330b72c14920b536f74ce
Commits on Apr 11, 2019
  1. Temporarly ignore exception when running animations

    mdvacca authored and facebook-github-bot committed Apr 11, 2019
    Summary: Running animations sometimes fail in Android. we are ignoring those failures temporarly
    
    Reviewed By: fkgozali
    
    Differential Revision: D14884510
    
    fbshipit-source-id: 66d6113e12b1bd67e8bcc564943b423825b4cea6
Commits on Apr 10, 2019
  1. Adding debug information in Mounting Manager

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    Summary: This diff adds extra debug information in the mounting manager
    
    Reviewed By: shergin
    
    Differential Revision: D14817456
    
    fbshipit-source-id: 5619c94eb76cdc20f5d7767f1aa4263e63f8d021
  2. - Integrate AndroidSwipeRefreshLayout component into Fabric Android

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    Summary: This diff integrates AndroidSwipeRefreshLayout component into Fabric Android
    
    Reviewed By: shergin
    
    Differential Revision: D14817453
    
    fbshipit-source-id: 348db960290fbab7bedf59d046b6ba68629447f6
  3. Force Diffing algorithm to insert views Bottom Up (from children to r…

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    …oot)
    
    Summary:
    This diff changes the way views are inserted by the diffing algorithm.
    Previously the diffing algorithm inserted views top-down, now it insert views bottom-up (same order as previous version of RN).
    
    Let say we need to create the following tree:
    ```
    
    A --> B --> C
          |
          | --> D
    
    ```
    
    Before, the diffing algorithm created the following list of instructions:
    ```
    insert(A, B, 0)
    insert(B, C, 0)
    insert(B, D, 1)
    ```
    
    After this diff, the insert instructions are going to be:
    
    ```
    insert(B, C, 0)
    insert(B, D, 1)
    insert(A, B, 0)
    ```
    
    Reviewed By: shergin
    
    Differential Revision: D14817454
    
    fbshipit-source-id: 7aac1a1e1784c53bca2747aee80a5bc8ee788e7a
  4. - Created schema for AndroidSwipeRefreshLayoutSchema

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    Summary: Created schema for AndroidSwipeRefreshLayoutSchema component
    
    Reviewed By: shergin
    
    Differential Revision: D14817451
    
    fbshipit-source-id: 22e8f71e476cd51ea61ce83f26c69ae71bbdafb5
  5. Recycle only views created by RN

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    Summary: This diff ensure that only views created by RN are taken into consideration for recycling.
    
    Reviewed By: fkgozali
    
    Differential Revision: D14874678
    
    fbshipit-source-id: ea7dd5a0f29f6acf0dce8573fc77b012395476bd
  6. Fix Lint warnings

    mdvacca authored and facebook-github-bot committed Apr 10, 2019
    Summary: Trivial reorder on buck dependencies and import in ComponentRegistry.cpp
    
    Reviewed By: shergin
    
    Differential Revision: D14779320
    
    fbshipit-source-id: df4111d4ecfb04d67c7170f0800a745656100fb4
Commits on Apr 4, 2019
  1. Implement AxialGradientView in Fabric Android

    mdvacca authored and facebook-github-bot committed Apr 4, 2019
    Summary: This diff integreates AxialGradientView in Fabric Android
    
    Reviewed By: shergin
    
    Differential Revision: D14631690
    
    fbshipit-source-id: 54785466ab4cd7251c6667c8dc12d69d9d194832
  2. Pre-allocate Fabric views even when React is running in the UI Thread

    mdvacca authored and facebook-github-bot committed Apr 4, 2019
    Summary: Before D14297477, the pre-allocation of views was ONLY necessary when react was running in the JS Thread, this is because the batch of mount items used to contain mount items for creation of views. After D14297477, views are only created during pre-allocation, that means that pre-allocation of views need to be trated the same way independently the thread where it is running.
    
    Reviewed By: shergin
    
    Differential Revision: D14714933
    
    fbshipit-source-id: 7bd19cd33b624a5b0daaafabb476bb06707eea17
Commits on Mar 31, 2019
  1. Disable view pooling

    mdvacca authored and facebook-github-bot committed Mar 31, 2019
    Summary:
    Temporarily disable View Pooling in Fabric
    
    Naming of classes will change in the near future
    
    Reviewed By: JoshuaGross
    
    Differential Revision: D14685009
    
    fbshipit-source-id: 83573dd09af0202a67d0d0aa11e37c1660c3991f
Commits on Mar 29, 2019
  1. Fix scrolling of Android Horizontal Scroll View

    mdvacca authored and facebook-github-bot committed Mar 29, 2019
    Summary:
    This diff fixes the scrolling of Android Horizontal Scroll View, the root cause was that Binding was mounting a ScrollView instead of an AndroidHorizontalScrollView component.
    This will be automatically fixed when all the View components are autogenerated.
    
    Reviewed By: shergin
    
    Differential Revision: D14594622
    
    fbshipit-source-id: 7c477ca167188ea9c473f61145461d3cf1696e17
  2. Refactor mapping of FabricComponentNames

    mdvacca authored and facebook-github-bot committed Mar 29, 2019
    Summary: Simple diff that refactors the usage of the sComponentNames to not require components to be part of the mapping when the name in JS is the same as the name in Native side.
    
    Reviewed By: shergin
    
    Differential Revision: D14594659
    
    fbshipit-source-id: d1948b27e04686fefbf9b6e2b06d4f9317b97062
  3. Add logs in mounting layer

    mdvacca authored and facebook-github-bot committed Mar 29, 2019
    Summary: Adds debug logging in FabricUIManager and the mounting layer of Fabric.
    
    Reviewed By: shergin
    
    Differential Revision: D14594521
    
    fbshipit-source-id: a5c0ee39e1bac8a340849ca3e044694cbee5427e
  4. Expose collapsable as React Prop in LayoutShadowNode

    mdvacca authored and facebook-github-bot committed Mar 29, 2019
    Summary: This diff exposes the collapsable prop as part of LayoutShadowNode, fixing the bug of the collapsable prop being filtered by JS in Fabric
    
    Reviewed By: shergin
    
    Differential Revision: D14594522
    
    fbshipit-source-id: a892ba8228e76f11232acc6fe5c8d75e991d8fc6
Commits on Mar 26, 2019
  1. Fix NoSuchElementException in ReactChoreographerDispatcher.doFrame

    mdvacca authored and facebook-github-bot committed Mar 26, 2019
    Summary: This diff fixes a NoSuchElementException that was being thrown at ReactChoreographerDispatcher.doFrame(). The root cause was a lack of syncronization in removeFrameCallback().
    
    Reviewed By: shergin
    
    Differential Revision: D14619386
    
    fbshipit-source-id: 80bc9e44866218d2a8703b3186f6958c145f260b
Commits on Mar 25, 2019
  1. Fix IllegalStateException when tapping next on Android Keyboard

    mdvacca authored and facebook-github-bot committed Mar 25, 2019
    Summary: This diff fixes an IllegalStateException that is thrown when the user click is on a edit text and tap 'Next' on the keyboard to focus on the next view, but the next view is hidden.
    
    Reviewed By: lunaleaps, mmmulani
    
    Differential Revision: D14598410
    
    fbshipit-source-id: 2999cc468ed24bedff163eedcfaec50f6ee005d6
Commits on Mar 24, 2019
  1. ReactTTRCRenderFlag component in Fabric android

    mdvacca authored and facebook-github-bot committed Mar 24, 2019
    Summary: This diff migrates ReactTTRCRenderFlag component to Fabric android
    
    Reviewed By: fkgozali
    
    Differential Revision: D14591212
    
    fbshipit-source-id: c10de2ab4a77af985853da6d3fe7a7c6a1bc7a1e
Older
You can’t perform that action at this time.