Navigator FloatFromLeft Scene Config #1100

Closed
hoodsy opened this Issue May 1, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@hoodsy
Contributor

hoodsy commented May 1, 2015

would it be possible to have a FloatFromLeft animation?

would b nice for the UX =]

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide May 1, 2015

Collaborator

I believe you could write this without needing to make changes to the core project by writing a scene config that mirrors FloatFromRight and providing it to the Navigator.

Collaborator

ide commented May 1, 2015

I believe you could write this without needing to make changes to the core project by writing a scene config that mirrors FloatFromRight and providing it to the Navigator.

@ericvicenti

This comment has been minimized.

Show comment
Hide comment
@ericvicenti

ericvicenti May 4, 2015

Contributor

Yep, you can write custom scene configs for Navigator in your app. If you think others would be interested in FloatFromLeft, you could send a pull request to the default configs file:

https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js

Contributor

ericvicenti commented May 4, 2015

Yep, you can write custom scene configs for Navigator in your app. If you think others would be interested in FloatFromLeft, you could send a pull request to the default configs file:

https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js

@ericvicenti ericvicenti changed the title from SceneConfig Animations to Navigator FloatFromLeft Scene Config May 4, 2015

@hoodsy

This comment has been minimized.

Show comment
Hide comment
@hoodsy

hoodsy May 4, 2015

Contributor

ok. thanks

Contributor

hoodsy commented May 4, 2015

ok. thanks

vjeux pushed a commit to vjeux/react-native that referenced this issue May 13, 2015

FloatFromLeft animation
Summary:
float from left animation for Navigator.SceneConfigs

#1100
@ericvicenti
@ide
Closes facebook#1249
Github Author: Logan Bernard <bernard.logan4@gmail.com>

@public

Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view

vjeux added a commit to vjeux/react-native that referenced this issue May 13, 2015

FloatFromLeft animation
Summary:
float from left animation for Navigator.SceneConfigs

#1100
@ericvicenti
@ide
Closes facebook#1249
Github Author: Logan Bernard <bernard.logan4@gmail.com>

@public

Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view

@brentvatne brentvatne closed this May 29, 2015

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.