New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stickySectionHeader is broken when rerendering #13500

Closed
nihgwu opened this Issue Apr 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@nihgwu
Contributor

nihgwu commented Apr 14, 2017

Platform: iOS
RN version: 0.44.0-rc.0

ping @janicduplessis I'm wandering if you have noticed this issue, the native implementation is removed in RN0.44, and the Native Animated version works great if the dataSource is initialized and won't be changed in the future, but if it's bean changed, the sticked header will become unstick

I remember you've made a commit to the master to resolve this kind of issue for SectionList on Android, but I haven't tried it yet, not sure if it happens on Android still

@nihgwu

This comment has been minimized.

Show comment
Hide comment
@nihgwu

nihgwu Apr 21, 2017

Contributor

ping @janicduplessis 😄

Contributor

nihgwu commented Apr 21, 2017

ping @janicduplessis 😄

nihgwu added a commit to nihgwu/react-native that referenced this issue May 10, 2017

fix stickySectionHeader re-render issue
Close #13500

I've been bothered by this issue for quite a long time, finally get some time to look into this.

I find the root cause is that after the props of the native driven node is assigned with a plain value, if you set it to a `Animated.Value` again, it's won't take any effect any more, so I make it to be a `Animated.Value` all the time

`value --> Animated.Value () --> value ()) --> Animated.Value ()`

ping @janicduplessis

nihgwu added a commit to nihgwu/react-native that referenced this issue May 10, 2017

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.