New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CameraRoll assetType is not implemented . #15154

Closed
PARAGJYOTI opened this Issue Jul 23, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@PARAGJYOTI

PARAGJYOTI commented Jul 23, 2017

Is this a bug report?

Yes

Have you read the Bugs section of the How to Contribute guide?

Yes

Environment

react-native 0.43

Platform : Android

##Description

The CameraRoll component for both android and ios should accept a param "assetType" as it's documented . But it's not even implemented in CameraRollManager.java for android .

   new GetPhotosTask(
          getReactApplicationContext(),
          first,
          after,
          groupName,
          mimeTypes,
          promise)
          .executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
  }

All other params like groupTypes or mimeTypes is there , but not "assetType" . So , the component only fetches the images , not videos even if we set assetType='All' .

Hope this issue get fixed soon .

@pull-bot

This comment has been minimized.

pull-bot commented Oct 9, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Oct 9, 2017

@hramos hramos closed this Oct 9, 2017

@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.