New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Overflow does not work and is inconsistent with iOS #17074

Closed
slorber opened this Issue Dec 5, 2017 · 22 comments

Comments

Projects
None yet
@slorber
Contributor

slorber commented Dec 5, 2017

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
Expo SDK 23 (RN 50)

Steps to Reproduce

Use this minimal Expo Snack

Expected Behavior

The children elements of the Snack should overflow their parent container (I think), or at least both platforms should handle that Snack consistently which is not the case.

Actual Behavior

The platforms are inconsistent with each others when using the exact same code.

image

image

Reproducible Demo

Use this minimal Expo Snack

Additional notes

There has been changes regarding overflow: hidden on Android that probably shipped with RN50, so it may be a regression. As far as I know it has been noticed as a regression in my app when updating from Expo22 to Expo23 (which use RN50).

I tried using zIndex, position absolute, transforms, overflow visible, collapsable=false... nothing made the inner views overflow correctly on Android.

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 5, 2017

cc @AaaChiuuu maybe you have an idea on what is happening here? By the way I'm interested by any workaround.

slorber referenced this issue Dec 5, 2017

fix overflow hidden
Reviewed By: shergin

Differential Revision: D5917111

fbshipit-source-id: e3d97f26b6aada199f700ec6659ace0d7dffd4c5
@slorber

This comment has been minimized.

Contributor

slorber commented Dec 5, 2017

@Noitidart

This comment has been minimized.

Noitidart commented Dec 5, 2017

@slorber - Expo is not up to date with RN updates usually. Is Expo using RN 50? Did the overflow hidden fix land in 50? Or is it going to land in 51?

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 6, 2017

Expo is currently using RN50 and I think this fix landed in RN50:

image

so for me it still does not work

I'm not even sure to understand what is happening here, was there recently an attempt to support overflow visible that broke overflow hidden?

@Noitidart

This comment has been minimized.

Noitidart commented Dec 6, 2017

Thanks @slorber - so that screenshot, does that mean all those tags is where this code is found? And v0.50.0-rc.0 is where it was first found?

@slorber

This comment has been minimized.

Contributor

slorber commented Dec 6, 2017

I guess :)

@faurehu

This comment has been minimized.

faurehu commented Dec 17, 2017

+1 and I've got Expo 24.0.0 and using Expo's fork with React-native 51.0.0.

@vvavepacket

This comment has been minimized.

vvavepacket commented Jan 6, 2018

+1 I am using RN 0.51.0 still same issue

@Ekhui

This comment has been minimized.

Ekhui commented Jan 26, 2018

+1 I am using RN 0.52.0 still same issue .
how did you solved it? ?

@goforwork

This comment has been minimized.

goforwork commented Feb 1, 2018

same issue,waiting solution

@nikasvan

This comment has been minimized.

nikasvan commented Feb 5, 2018

Any updates on this?

@jatarga

This comment has been minimized.

jatarga commented Feb 14, 2018

Would like to know as well.

Environment:
  OS: macOS Sierra 10.12.6
  Node: 9.3.0
  Yarn: Not Found
  npm: 5.6.0
  Watchman: 4.7.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.53.0 => 0.53.0
@react-native-bot

This comment has been minimized.

Collaborator

react-native-bot commented Feb 24, 2018

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@garan82

This comment has been minimized.

garan82 commented Feb 24, 2018

This is still an issue.

@jilb1992

This comment has been minimized.

jilb1992 commented Feb 27, 2018

Still an issue.. almost with expo i didn't try with a react native clean proyect

@slorber

This comment has been minimized.

Contributor

slorber commented Feb 27, 2018

Expo 25 is based on RN 0.52, so it won't work until SDK 26 is published. If you want to claim it's still an issue, make sure you are using RN 0.53 @garan82 @jilb1992

I haven't tested myself, can't tell

@zeh

This comment has been minimized.

zeh commented Feb 27, 2018

Just to make it clear, it is still an issue on RN 0.53.

This has been a problem for a long time. Some people say it's going to be fixed when FlatUIImplementation is implemented by default instead - I've seen "June" mentioned in this thread - but I haven't seen any official signal on that, nor have I tried manually turning FlatUIImplementation on to see if it's actually working or even a viable alternative to the current UI implementation.

@floriancargoet

This comment has been minimized.

floriancargoet commented Feb 27, 2018

I tried the provided example on a fresh RN 0.53.3 project, it is still an issue indeed.

@erikxavier

This comment has been minimized.

erikxavier commented Mar 4, 2018

Still an issue, RN 0.53.3.

Any luck with FlatUIImplementation ? How to test this ?

@DrRefactor

This comment has been minimized.

DrRefactor commented Mar 8, 2018

RN 0.53 - no luck of finding workaround for this yet, have you guys figured one out?

@NrqhEIcsRi004

This comment has been minimized.

NrqhEIcsRi004 commented May 24, 2018

Still an issue, RN 0.55.3.

@RomanISWG

This comment has been minimized.

RomanISWG commented Jun 8, 2018

same issue on RN 0.55.4

@facebook facebook locked as resolved and limited conversation to collaborators Jun 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.