Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Resolve Warnings in Xcode #22609

Closed
hramos opened this issue Dec 11, 2018 · 5 comments

Comments

@hramos
Copy link
Contributor

commented Dec 11, 2018

Xcode shows multiple warnings when either RNTester/RNTester/xcodeproj or template/ios/HelloWorld.xcodeproj/ (scaffold for new apps) is built. These warnings have accumulated over the years (#19628), and it is one of the concerns with the most reactions in a recent survey of React Native users.

This issue will track all efforts to reduce the number of warnings in our Xcode projects.

If you send a pull request that removes a warning listed in this issue, please let us know so we can take a look at your proposed change.

RNTester

Targets

Xcode breaks down the warnings by target.

  • double-conversion
  • jsi
  • third-party (folly, glog)
  • cxxreact
  • jsiexecutor
  • React
  • RCTNetwork
  • RCTImage
  • RNTester

Note that some of these warnings may originate in third party libraries. Further, these warnings may be resolved in newer versions of these libraries. As such, you may need to upgrade some of these libraries to resolve a warning. Careful testing will be needed in order to make sure no breaking changes are introduced as part of these upgrades.

Detailed list of warnings

As of this writing, Xcode 10.1 presents warnings on the following files when building RNTester:

Target: double-conversion
third-party/double-conversion-1.1.6/src/double-conversion.cc:825:10: Declaration shadows a local variable
Target: jsi
Semantic Issue Group
ReactCommon/jsi/JSCRuntime.cpp:575:22: Unused parameter 'ctx'
ReactCommon/jsi/JSCRuntime.cpp:612:22: Unused parameter 'ctx'
third-party/folly-2018.10.22.00/folly/Memory.h:51:30: Possible misuse of comma operator here
ReactCommon/jsi/JSIDynamic.cpp:6:10: In file included from ReactCommon/jsi/JSIDynamic.cpp:6:
ReactCommon/jsi/JSIDynamic.h:8:10: In file included from ReactCommon/jsi/JSIDynamic.h:8:
third-party/folly-2018.10.22.00/folly/dynamic.h:67:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:67:
third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:10: In file included from third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:
third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:10: In file included from third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:
third-party/folly-2018.10.22.00/folly/Memory.h:51:21: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/Memory.h:51:50: Possible misuse of comma operator here
ReactCommon/jsi/JSIDynamic.cpp:6:10: In file included from ReactCommon/jsi/JSIDynamic.cpp:6:
ReactCommon/jsi/JSIDynamic.h:8:10: In file included from ReactCommon/jsi/JSIDynamic.h:8:
third-party/folly-2018.10.22.00/folly/dynamic.h:67:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:67:
third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:10: In file included from third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:
third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:10: In file included from third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:
third-party/folly-2018.10.22.00/folly/Memory.h:51:40: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/FBString.h:1881:72: Possible misuse of comma operator here
ReactCommon/jsi/JSIDynamic.cpp:6:10: In file included from ReactCommon/jsi/JSIDynamic.cpp:6:
ReactCommon/jsi/JSIDynamic.h:8:10: In file included from ReactCommon/jsi/JSIDynamic.h:8:
third-party/folly-2018.10.22.00/folly/dynamic.h:717:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:717:
third-party/folly-2018.10.22.00/folly/dynamic-inl.h:21:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic-inl.h:21:
third-party/folly-2018.10.22.00/folly/Conv.h:40:10: In file included from third-party/folly-2018.10.22.00/folly/Conv.h:40:
third-party/folly-2018.10.22.00/folly/Demangle.h:19:10: In file included from third-party/folly-2018.10.22.00/folly/Demangle.h:19:
third-party/folly-2018.10.22.00/folly/FBString.h:1880:15: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/Conv.h:1184:44: Possible misuse of comma operator here
ReactCommon/jsi/JSIDynamic.cpp:6:10: In file included from ReactCommon/jsi/JSIDynamic.cpp:6:
ReactCommon/jsi/JSIDynamic.h:8:10: In file included from ReactCommon/jsi/JSIDynamic.h:8:
third-party/folly-2018.10.22.00/folly/dynamic.h:717:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:717:
third-party/folly-2018.10.22.00/folly/dynamic-inl.h:21:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic-inl.h:21:
third-party/folly-2018.10.22.00/folly/Conv.h:1184:29: Cast expression to void to silence warning
Value Conversion Issue Group
ReactCommon/jsi/JSCRuntime.cpp:821:63: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
ReactCommon/jsi/JSCRuntime.cpp:831:52: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
Target: folly
Semantic Issue Group
third-party/folly-2018.10.22.00/folly/detail/Demangle.cpp:33:23: Unused parameter 'mangled'
third-party/folly-2018.10.22.00/folly/detail/Demangle.cpp:34:18: Unused parameter 'cbref'
third-party/folly-2018.10.22.00/folly/detail/Demangle.cpp:35:17: Unused parameter 'opaque'
third-party/folly-2018.10.22.00/folly/FBString.h:1881:72: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/Demangle.cpp:17:10: In file included from third-party/folly-2018.10.22.00/folly/Demangle.cpp:17:
third-party/folly-2018.10.22.00/folly/Demangle.h:19:10: In file included from third-party/folly-2018.10.22.00/folly/Demangle.h:19:
third-party/folly-2018.10.22.00/folly/FBString.h:1880:15: Cast expression to void to silence warning
third-party/glog-0.3.5/src/utilities.cc:87:6: No previous prototype for function 'DebugWriteToString'
third-party/glog-0.3.5/src/stacktrace_x86_64-inl.h:51:66: Unused parameter 'uc'
third-party/glog-0.3.5/src/utilities.cc:351:11: In file included from third-party/glog-0.3.5/src/utilities.cc:351:
third-party/glog-0.3.5/src/stacktrace_x86_64-inl.h:51:76: Unused parameter 'opq'
third-party/glog-0.3.5/src/utilities.cc:351:11: In file included from third-party/glog-0.3.5/src/utilities.cc:351:
third-party/folly-2018.10.22.00/folly/Conv.h:1184:44: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/json_pointer.cpp:19:10: In file included from third-party/folly-2018.10.22.00/folly/json_pointer.cpp:19:
third-party/folly-2018.10.22.00/folly/String.h:27:10: In file included from third-party/folly-2018.10.22.00/folly/String.h:27:
third-party/folly-2018.10.22.00/folly/Conv.h:1184:29: Cast expression to void to silence warning
third-party/glog-0.3.5/src/vlog_is_on.cc:69:27: No previous prototype for function 'SafeFNMatch_'
third-party/glog-0.3.5/src/logging.cc:316:13: No previous prototype for function 'GetAnsiColorCode'
third-party/glog-0.3.5/src/logging.cc:1681:6: No previous prototype for function 'GetExitOnDFatal'
third-party/glog-0.3.5/src/logging.cc:1696:6: No previous prototype for function 'SetExitOnDFatal'
third-party/folly-2018.10.22.00/folly/Memory.h:51:30: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/dynamic.cpp:19:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.cpp:19:
third-party/folly-2018.10.22.00/folly/dynamic.h:67:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:67:
third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:10: In file included from third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:
third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:10: In file included from third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:
third-party/folly-2018.10.22.00/folly/Memory.h:51:21: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/Memory.h:51:50: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/dynamic.cpp:19:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.cpp:19:
third-party/folly-2018.10.22.00/folly/dynamic.h:67:10: In file included from third-party/folly-2018.10.22.00/folly/dynamic.h:67:
third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:10: In file included from third-party/folly-2018.10.22.00/folly/container/F14Map.h:38:
third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:10: In file included from third-party/folly-2018.10.22.00/folly/container/detail/F14Policy.h:23:
third-party/folly-2018.10.22.00/folly/Memory.h:51:40: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/json.cpp:462:27: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/json.cpp:462:23: Cast expression to void to silence warning
third-party/folly-2018.10.22.00/folly/json.cpp:486:39: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/json.cpp:486:10: Cast expression to void to silence warning
third-party/glog-0.3.5/exported/glog/logging.h:719:32: Comparison of integers of different signs: 'const unsigned long' and 'const long'
third-party/folly-2018.10.22.00/folly/json.cpp:16:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:16:
third-party/folly-2018.10.22.00/folly/json.h:47:10: In file included from third-party/folly-2018.10.22.00/folly/json.h:47:
third-party/folly-2018.10.22.00/folly/Range.h:47:10: In file included from third-party/folly-2018.10.22.00/folly/Range.h:47:
third-party/folly-2018.10.22.00/folly/detail/RangeCommon.h:22:10: In file included from third-party/folly-2018.10.22.00/folly/detail/RangeCommon.h:22:
third-party/glog-0.3.5/exported/glog/logging.h:706:32: Expanded from macro 'DEFINE_CHECK_OP_IMPL'
third-party/glog-0.3.5/exported/glog/logging.h:148:53: Expanded from macro 'GOOGLE_PREDICT_TRUE'
third-party/folly-2018.10.22.00/folly/json.cpp:715:7: In instantiation of function template specialization 'google::Check_LEImpl<unsigned long, long>' requested here
third-party/folly-2018.10.22.00/folly/json.cpp:831:5: In instantiation of function template specialization 'folly::json::escapeStringImpl<true>' requested here
Value Conversion Issue Group
third-party/glog-0.3.5/src/signalhandler.cc:95:50: Implicit conversion loses integer precision: 'long' to 'int'
third-party/glog-0.3.5/src/vlog_is_on.cc:52:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/vlog_is_on.cc:163:27: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const int'
third-party/glog-0.3.5/src/logging.cc:139:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:141:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:145:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:147:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:168:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:176:1: Implicit conversion loses integer precision: 'long' to 'google::int32' (aka 'int')
third-party/glog-0.3.5/src/base/commandlineflags.h:116:22: Expanded from macro 'GLOG_DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:131:32: Expanded from macro 'EnvToInt'
third-party/glog-0.3.5/src/base/commandlineflags.h:86:53: Expanded from macro 'DEFINE_int32'
third-party/glog-0.3.5/src/base/commandlineflags.h:71:44: Expanded from macro 'DEFINE_VARIABLE'
third-party/glog-0.3.5/src/logging.cc:631:33: Implicit conversion loses integer precision: 'unsigned long' to 'int'
third-party/glog-0.3.5/src/logging.cc:764:65: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
third-party/glog-0.3.5/src/logging.cc:789:33: Implicit conversion loses integer precision: 'unsigned long' to 'int'
third-party/glog-0.3.5/src/logging.cc:799:33: Implicit conversion loses integer precision: 'unsigned long' to 'int'
third-party/glog-0.3.5/src/logging.cc:1083:47: Implicit conversion loses integer precision: 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::size_type' (aka 'unsigned long') to 'const int'
third-party/glog-0.3.5/src/logging.cc:1344:19: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const int'
third-party/glog-0.3.5/src/logging.cc:1416:40: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const int'
third-party/glog-0.3.5/src/logging.cc:1517:67: Implicit conversion loses integer precision: 'unsigned long' to 'int'
third-party/glog-0.3.5/src/logging.cc:1530:67: Implicit conversion loses integer precision: 'unsigned long' to 'int'
third-party/glog-0.3.5/src/logging.cc:1897:21: Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
third-party/glog-0.3.5/src/logging.cc:1898:16: Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
third-party/glog-0.3.5/src/demangle.cc:343:18: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
Documentation Issue Group
third-party/boost_1_63_0/boost/range/iterator_range_core.hpp:867:20: Parameter 'Range' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:19:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:19:
third-party/boost_1_63_0/boost/algorithm/string/trim.hpp:19:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/trim.hpp:19:
third-party/boost_1_63_0/boost/range/as_literal.hpp:22:10: In file included from third-party/boost_1_63_0/boost/range/as_literal.hpp:22:
third-party/boost_1_63_0/boost/range/iterator_range.hpp:13:10: In file included from third-party/boost_1_63_0/boost/range/iterator_range.hpp:13:
third-party/boost_1_63_0/boost/range/iterator_range_core.hpp:867:20: Did you mean 'r'?
third-party/boost_1_63_0/boost/algorithm/string/finder.hpp:46:20: Parameter 'Comp' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:21:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:21:
third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:
third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:
third-party/boost_1_63_0/boost/algorithm/string/finder.hpp:87:20: Parameter 'Comp' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:21:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:21:
third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:
third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:
third-party/boost_1_63_0/boost/algorithm/string/finder.hpp:127:20: Parameter 'Comp' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:21:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:21:
third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:
third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:
third-party/boost_1_63_0/boost/algorithm/string/finder.hpp:233:20: Parameter 'Range' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:21:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:21:
third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/predicate.hpp:23:
third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/find.hpp:22:
third-party/boost_1_63_0/boost/algorithm/string/formatter.hpp:79:20: Parameter 'Input' not found in the function declaration
third-party/folly-2018.10.22.00/folly/json.cpp:23:10: In file included from third-party/folly-2018.10.22.00/folly/json.cpp:23:
third-party/boost_1_63_0/boost/algorithm/string.hpp:25:10: In file included from third-party/boost_1_63_0/boost/algorithm/string.hpp:25:
third-party/boost_1_63_0/boost/algorithm/string/replace.hpp:24:10: In file included from third-party/boost_1_63_0/boost/algorithm/string/replace.hpp:24:
Target: cxxreact
ReactCommon/cxxreact/JSExecutor.h:107:41: Unused parameter 'pressureLevel'
ReactCommon/cxxreact/CxxNativeModule.cpp:7:10: In file included from ReactCommon/cxxreact/CxxNativeModule.cpp:7:
ReactCommon/cxxreact/Instance.h:11:10: In file included from ReactCommon/cxxreact/Instance.h:11:
ReactCommon/cxxreact/NativeToJsBridge.h:13:10: In file included from ReactCommon/cxxreact/NativeToJsBridge.h:13:
ReactCommon/cxxreact/SystraceSection.h:42:36: Unused parameter 'name'
ReactCommon/cxxreact/CxxNativeModule.cpp:14:10: In file included from ReactCommon/cxxreact/CxxNativeModule.cpp:14:
ReactCommon/cxxreact/SystraceSection.h:42:69: Unused parameter 'args'
ReactCommon/cxxreact/CxxNativeModule.cpp:14:10: In file included from ReactCommon/cxxreact/CxxNativeModule.cpp:14:
ReactCommon/cxxreact/NativeToJsBridge.cpp:42:19: Unused parameter 'executor'
ReactCommon/cxxreact/NativeToJsBridge.cpp:67:19: Unused parameter 'executor'
ReactCommon/cxxreact/SampleCxxModule.cpp:148:43: Unused parameter 'args'
Value Conversion Issue Group
ReactCommon/cxxreact/MethodCall.cpp:56:39: Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
ReactCommon/cxxreact/SampleCxxModule.cpp:97:29: Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
ReactCommon/cxxreact/SampleCxxModule.cpp:103:29: Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
Target: jsiexecutor

Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/JSExecutor.h:107:41: Unused parameter 'pressureLevel'
ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:6:10: In file included from ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:6:
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/jsireact/JSIExecutor.h:8:10: In file included from Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/jsireact/JSIExecutor.h:8:
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/jsireact/JSINativeModules.h:11:10: In file included from Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/jsireact/JSINativeModules.h:11:
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/ModuleRegistry.h:12:10: In file included from Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/ModuleRegistry.h:12:
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/SystraceSection.h:42:36: Unused parameter 'name'
ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:11:10: In file included from ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:11:
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/SystraceSection.h:42:69: Unused parameter 'args'
ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:11:10: In file included from ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:11:
ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp:172:26: Unused parameter 'rt'

</details>

<details>
<summary>
Target: React
</summary>

Dead store Group
React/Base/RCTModuleMethod.mm:553:3: Value stored to 'index' is never read
Value Conversion Issue Group
React/Profiler/RCTProfile.m:83:34: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
React/Profiler/RCTProfile.m:85:36: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'
React/Inspector/RCTInspector.mm:83:49: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'
React/Views/RCTWKWebView.m:265:23: Implicit conversion from enumeration type 'enum WKNavigationResponsePolicy' to different enumeration type 'WKNavigationActionPolicy' (aka 'enum WKNavigationActionPolicy')
React/Views/RCTWKWebView.m:284:19: Implicit conversion from enumeration type 'enum WKNavigationResponsePolicy' to different enumeration type 'WKNavigationActionPolicy' (aka 'enum WKNavigationActionPolicy')
Deprecations Group
React/Modules/RCTStatusBarManager.m:111:29: 'setStatusBarStyle:animated:' is deprecated: first deprecated in iOS 9.0 - Use -[UIViewController preferredStatusBarStyle]
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:460:1: 'setStatusBarStyle:animated:' has been explicitly marked deprecated here
React/Modules/RCTStatusBarManager.m:123:29: 'setStatusBarHidden:withAnimation:' is deprecated: first deprecated in iOS 9.0 - Use -[UIViewController prefersStatusBarHidden]
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:464:1: 'setStatusBarHidden:withAnimation:' has been explicitly marked deprecated here
React/Base/RCTConvert.m:92:20: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:592:1: 'stringByAddingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/DevSupport/RCTInspectorDevServerHelper.mm:36:66: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:592:1: 'stringByAddingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/DevSupport/RCTInspectorDevServerHelper.mm:37:72: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:592:1: 'stringByAddingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/DevSupport/RCTInspectorDevServerHelper.mm:47:66: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:592:1: 'stringByAddingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/DevSupport/RCTInspectorDevServerHelper.mm:48:72: 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:592:1: 'stringByAddingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/Views/RCTWebView.m:250:18: 'stringByReplacingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByRemovingPercentEncoding instead, which always uses the recommended UTF-8 encoding.
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:593:1: 'stringByReplacingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here
React/Views/RCTWKWebView.m:83:21: 'mediaPlaybackRequiresUserAction' is deprecated: first deprecated in iOS 9.0
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/WebKit.framework/Headers/WKWebViewConfiguration.h:203:28: 'mediaPlaybackRequiresUserAction' has been explicitly marked deprecated here
React/Base/RCTBundleURLProvider.m:74:35: 'sendSynchronousRequest:returningResponse:error:' is deprecated: first deprecated in iOS 9.0 - Use [NSURLSession dataTaskWithRequest:completionHandler:] (see NSURLSession.h
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLConnection.h:401:1: 'sendSynchronousRequest:returningResponse:error:' has been explicitly marked deprecated here
React/Modules/RCTRedBox.m:455:40: 'sendDeviceEventWithName:body:' is deprecated: Subclass RCTEventEmitter instead
React/Base/RCTEventDispatcher.h:82:1: 'sendDeviceEventWithName:body:' has been explicitly marked deprecated here
Nullability Issue Group
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.h:17:16: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm:8:9: In file included from React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm:8:
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.h:17:16: Insert '_Nullable' if the pointer may be null
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.h:17:16: Insert '_Nonnull' if the pointer should never be null
Semantic Issue Group
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm:229:31: Unused parameter 'surface'
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm:236:31: Unused parameter 'surface'
React/Base/Surface/SurfaceHostingView/RCTSurfaceHostingView.mm:236:70: Unused parameter 'intrinsicSize'
React/DevSupport/RCTDevMenu.m:220:102: Unused parameter 'action'
React/DevSupport/RCTDevMenu.m:254:104: Unused parameter 'action'
React/Views/RCTWKWebViewManager.m:64:1: Unused parameter 'defaultView'
React/Views/RCTViewManager.h:83:84: Expanded from macro 'RCT_CUSTOM_VIEW_PROPERTY'
React/Views/RCTWKWebViewManager.m:68:1: Unused parameter 'defaultView'
React/Views/RCTViewManager.h:83:84: Expanded from macro 'RCT_CUSTOM_VIEW_PROPERTY'
React/Views/RCTWKWebViewManager.m:72:1: Unused parameter 'defaultView'
React/Views/RCTViewManager.h:83:84: Expanded from macro 'RCT_CUSTOM_VIEW_PROPERTY'
React/Views/RCTWKWebViewManager.m:138:43: Unused parameter 'webView'
React/DevSupport/RCTInspectorDevServerHelper.mm:94:25: Unused parameter 'data'
React/DevSupport/RCTInspectorDevServerHelper.mm:95:32: Unused parameter 'response'
React/Base/Surface/RCTSurface.mm:185:70: Unused parameter 'notification'
React/Base/Surface/RCTSurface.mm:508:45: Unused parameter 'rootShadowView'
React/Base/Surface/RCTSurface.mm:513:69: Unused parameter 'rootShadowView'
React/Base/Surface/RCTSurface.mm:520:69: Unused parameter 'rootShadowView'
React/Base/Surface/RCTSurface.mm:534:35: Unused parameter 'manager'
React/Base/Surface/RCTSurface.mm:550:53: Unused parameter 'manager'
React/Base/Surface/RCTSurface.mm:31:17: Method override for the designated initializer of the superclass '-init' not found
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/usr/include/objc/NSObject.h:63:1: Method marked as designated initializer of the class here
React/Views/SafeAreaView/RCTSafeAreaShadowView.m:36:29: Unused parameter 'value'
React/Views/SafeAreaView/RCTSafeAreaShadowView.m:37:33: Unused parameter 'value'
React/Views/SafeAreaView/RCTSafeAreaShadowView.m:38:34: Unused parameter 'value'
React/Views/SafeAreaView/RCTSafeAreaShadowView.m:39:32: Unused parameter 'value'
React/Views/SafeAreaView/RCTSafeAreaShadowView.m:40:35: Unused parameter 'value'
React/Views/RCTFont.mm:55:27: Comparison of integers of different signs: 'NSInteger' (aka 'long') and 'NSUInteger' (aka 'unsigned long')
React/Views/ScrollView/RCTScrollView.m:1117:44: 'UIScrollViewContentInsetAdjustmentBehavior' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollView.m:1117:1: Annotate 'setContentInsetAdjustmentBehavior:' with an availability attribute to silence this warning
React/Views/ScrollView/RCTScrollView.m:757:23: Comparison of integers of different signs: 'int' and 'NSUInteger' (aka 'unsigned long')
React/Views/ScrollView/RCTScrollView.m:1022:43: Unused parameter 'uiManager'
React/Views/ScrollView/RCTScrollView.m:1022:90: Unused parameter 'viewRegistry'
React/Views/ScrollView/RCTScrollView.m:1039:39: Unused parameter 'uiManager'
React/Views/ScrollView/RCTScrollView.m:1039:86: Unused parameter 'viewRegistry'
React/Views/ScrollView/RCTScrollViewManager.m:38:20: 'UIScrollViewContentInsetAdjustmentBehavior' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:38:1: Annotate 'UIScrollViewContentInsetAdjustmentBehavior:' with an availability attribute to silence this warning
React/Views/ScrollView/RCTScrollViewManager.m:39:19: 'UIScrollViewContentInsetAdjustmentAutomatic' is only available on iOS 11.0 or newer
React/Base/RCTConvert.h:231:15: Expanded from macro 'RCT_ENUM_CONVERTER'
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:39:19: Enclose 'UIScrollViewContentInsetAdjustmentAutomatic' in an @available check to silence this warning
React/Views/ScrollView/RCTScrollViewManager.m:40:24: 'UIScrollViewContentInsetAdjustmentScrollableAxes' is only available on iOS 11.0 or newer
React/Base/RCTConvert.h:231:15: Expanded from macro 'RCT_ENUM_CONVERTER'
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:40:24: Enclose 'UIScrollViewContentInsetAdjustmentScrollableAxes' in an @available check to silence this warning
React/Views/ScrollView/RCTScrollViewManager.m:41:15: 'UIScrollViewContentInsetAdjustmentNever' is only available on iOS 11.0 or newer
React/Base/RCTConvert.h:231:15: Expanded from macro 'RCT_ENUM_CONVERTER'
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:41:15: Enclose 'UIScrollViewContentInsetAdjustmentNever' in an @available check to silence this warning
React/Views/ScrollView/RCTScrollViewManager.m:42:16: 'UIScrollViewContentInsetAdjustmentAlways' is only available on iOS 11.0 or newer
React/Base/RCTConvert.h:231:15: Expanded from macro 'RCT_ENUM_CONVERTER'
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:42:16: Enclose 'UIScrollViewContentInsetAdjustmentAlways' in an @available check to silence this warning
React/Views/ScrollView/RCTScrollViewManager.m:43:5: 'UIScrollViewContentInsetAdjustmentNever' is only available on iOS 11.0 or newer
React/Base/RCTConvert.h:233:65: Expanded from macro 'RCT_ENUM_CONVERTER'
React/Base/RCTConvert.h:219:31: Expanded from macro '_RCT_CAST'
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/ScrollView/RCTScrollViewManager.m:43:5: Enclose 'UIScrollViewContentInsetAdjustmentNever' in an @available check to silence this warning
React/Modules/RCTRedBoxExtraDataViewController.m:184:39: Unused parameter 'tableView'
React/Modules/RCTRedBoxExtraDataViewController.m:189:37: Unused parameter 'tableView'
React/Modules/RCTRedBoxExtraDataViewController.m:189:83: Unused parameter 'section'
React/Modules/RCTRedBoxExtraDataViewController.m:194:38: Unused parameter 'tableView'
React/Modules/RCTRedBoxExtraDataViewController.m:240:57: Unused parameter 'tableView'
React/DevSupport/RCTPackagerConnection.mm:74:44: Unused parameter 'note'
React/DevSupport/RCTPackagerConnection.mm:201:66: Unused parameter 'webSocket'
React/DevSupport/RCTPackagerConnection.mm:262:67: Unused parameter 'webSocket'
React/Views/RCTWebView.m:55:60: 'UIScrollViewContentInsetAdjustmentNever' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/RCTWebView.m:55:60: Enclose 'UIScrollViewContentInsetAdjustmentNever' in an @available check to silence this warning
React/Views/RCTWebView.m:55:27: 'setContentInsetAdjustmentBehavior:' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:68:65: 'setContentInsetAdjustmentBehavior:' has been explicitly marked partial here
React/Views/RCTWebView.m:55:27: Enclose 'setContentInsetAdjustmentBehavior:' in an @available check to silence this warning
React/Views/RCTWKWebView.m:95:60: 'UIScrollViewContentInsetAdjustmentNever' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:35:28: 'UIScrollViewContentInsetAdjustmentBehavior' has been explicitly marked partial here
React/Views/RCTWKWebView.m:95:60: Enclose 'UIScrollViewContentInsetAdjustmentNever' in an @available check to silence this warning
React/Views/RCTWKWebView.m:95:27: 'setContentInsetAdjustmentBehavior:' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIScrollView.h:68:65: 'setContentInsetAdjustmentBehavior:' has been explicitly marked partial here
React/Views/RCTWKWebView.m:95:27: Enclose 'setContentInsetAdjustmentBehavior:' in an @available check to silence this warning
React/Views/RCTWKWebView.m:122:58: Unused parameter 'userContentController'
React/Views/RCTWKWebView.m:235:48: Unused parameter 'webView'
React/Views/RCTWKWebView.m:291:45: Unused parameter 'webView'
React/Views/RCTWKWebView.m:292:48: Unused parameter 'navigation'
React/Views/RCTWKWebView.m:321:50: Unused parameter 'webView'
React/Views/RCTWKWebView.m:351:36: Unused parameter 'webView'
React/Views/RCTWKWebView.m:352:39: Unused parameter 'navigation'
React/Views/RCTMaskedView.m:27:33: Unused parameter 'layer'
React/Views/RCTPicker.m:72:39: Unused parameter 'pickerView'
React/Views/RCTPicker.m:72:83: Unused parameter 'component'
React/Inspector/RCTInspectorPackagerConnection.m:198:37: Unused parameter 'webSocket'
React/Inspector/RCTInspectorPackagerConnection.m:210:37: Unused parameter 'webSocket'
React/Inspector/RCTInspectorPackagerConnection.m:231:37: Unused parameter 'webSocket'
React/Inspector/RCTInspectorPackagerConnection.m:231:75: Unused parameter 'code'
React/Inspector/RCTInspectorPackagerConnection.m:232:76: Unused parameter 'reason'
React/Inspector/RCTInspectorPackagerConnection.m:233:70: Unused parameter 'wasClean'
React/Views/SafeAreaView/RCTSafeAreaView.m:42:17: 'safeAreaInsets' is only available on iOS 11.0 or newer
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIView.h:264:45: 'safeAreaInsets' has been explicitly marked partial here
React/Views/SafeAreaView/RCTSafeAreaView.m:42:17: Enclose 'safeAreaInsets' in an @available check to silence this warning
React/Modules/RCTUIManager.m:1182:36: Unused parameter 'uiManager'
React/Modules/RCTUIManager.m:1207:36: Unused parameter 'uiManager'
third-party/folly-2018.10.22.00/folly/Memory.h:51:30: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/Memory.h:51:50: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/FBString.h:1881:72: Possible misuse of comma operator here
third-party/folly-2018.10.22.00/folly/Conv.h:1184:44: Possible misuse of comma operator here
Library/Developer/Xcode/DerivedData/RNTester-enfkflduwtadcufqojtousdlheev/Build/Products/Debug-iphonesimulator/include/cxxreact/JSExecutor.h:107:41: Unused parameter 'pressureLevel'
React/CxxBridge/RCTObjcExecutor.mm💯32: Unused parameter 'bundleId'
React/CxxBridge/RCTObjcExecutor.mm💯61: Unused parameter 'bundlePath'
ReactCommon/cxxreact/JSExecutor.h:107:41: Unused parameter 'pressureLevel'
React/CxxModule/DispatchMessageQueueThread.h:31:47: Unused parameter 'func'
React/CxxModule/RCTCxxUtils.mm:16:9: In file included from React/CxxModule/RCTCxxUtils.mm:16:
React/CxxBridge/RCTCxxBridge.mm:86:12: Moving a local object in a return statement prevents copy elision
React/CxxBridge/RCTCxxBridge.mm:86:12: Remove std::move call here
React/CxxBridge/RCTCxxBridge.mm:98:41: Unused parameter 'jsQueue'
React/CxxBridge/RCTCxxBridge.mm:122:113: Unused parameter 'tag'
Unused Entity Issue Group
React/Views/RCTTabBarItem.m:59:1: Ivar '_testID' which backs the property is not referenced in this property's accessor
React/Views/RCTTabBarItem.h:29:41: Property declared here
React/CxxModule/RCTNativeModule.mm:65:93: Lambda capture 'callId' is not used
React/CxxBridge/RCTCxxBridge.mm:1366:1: Ivar '_runtime' which backs the property is not referenced in this property's accessor
React/Base/RCTBridge+Private.h:152:29: Property declared here

</details>

<details>
<summary>
Target: RCTNetwork
</summary>

API Misuse (Apple) Group
Libraries/Network/RCTNetInfo.m:66:60: Dictionary value cannot be nil

</details>

<details>
<summary>
Target: RCTImage
</summary>

Core Foundation/Objective-C Group
Libraries/Image/RCTImageCache.m:41:3: Instance variable used while 'self' is not set to the result of '[(super or self) init...]'

</details>

# Extra Credit

Help track our progress and prevent regressions by logging the number of warnings produced by our Xcode projects. An increase in the number of warnings on a clean project should be considered a regression in CI.  You may consider adding a build script that [outputs the warnings to a file](https://stackoverflow.com/questions/20047112/export-all-warnings-in-file-in-xcode), and use our existing dangerbot infrastructure to flag PRs that regress. See [React's sizebot for an example](https://github.com/facebook/react/blob/master/dangerfile.js).
@hramos hramos referenced this issue Dec 11, 2018
5 of 5 tasks complete

@hramos hramos added this to To do in 🛠 Updated Tooling via automation Dec 14, 2018

@rafaellincoln rafaellincoln referenced this issue Jan 28, 2019
2 of 2 tasks complete

facebook-github-bot added a commit that referenced this issue Jan 28, 2019

Fix Warnings in Xcode (#23184)
Summary:
His PR is related to #22609

Changelog:
----------

[IOS][Changed] - Fix warning in RCTImage
[IOS][Changed] - Fix warning in RCTNetwork
Pull Request resolved: #23184

Differential Revision: D13838680

Pulled By: cpojer

fbshipit-source-id: 698303e44bb85a4819abff7d71e0b75936c09dc8
@rafaellincoln rafaellincoln referenced this issue Jan 29, 2019
2 of 2 tasks complete

facebook-github-bot added a commit that referenced this issue Jan 29, 2019

Fix warnings in JSI (#23201)
Summary:
His PR is related to #22609

There are still some warnings related to folly, but I plan to make the correction and send the PR to the repo of the folly.

Changelog:
[IOS][Changed] - Fix warning in JSCRuntime
Pull Request resolved: #23201

Differential Revision: D13859393

Pulled By: cpojer

fbshipit-source-id: 95df2b76b28b460f890d11e1395fddb6b1cc8fed

@hramos hramos moved this from To do to In progress in 🛠 Updated Tooling Feb 1, 2019

matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019

Fix Warnings in Xcode (facebook#23184)
Summary:
His PR is related to facebook#22609

Changelog:
----------

[IOS][Changed] - Fix warning in RCTImage
[IOS][Changed] - Fix warning in RCTNetwork
Pull Request resolved: facebook#23184

Differential Revision: D13838680

Pulled By: cpojer

fbshipit-source-id: 698303e44bb85a4819abff7d71e0b75936c09dc8

matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019

Fix warnings in JSI (facebook#23201)
Summary:
His PR is related to facebook#22609

There are still some warnings related to folly, but I plan to make the correction and send the PR to the repo of the folly.

Changelog:
[IOS][Changed] - Fix warning in JSCRuntime
Pull Request resolved: facebook#23201

Differential Revision: D13859393

Pulled By: cpojer

fbshipit-source-id: 95df2b76b28b460f890d11e1395fddb6b1cc8fed

matt-oakes pushed a commit to matt-oakes/react-native that referenced this issue Feb 7, 2019

Fix Warnings in Xcode (facebook#23184)
Summary:
His PR is related to facebook#22609

Changelog:
----------

[IOS][Changed] - Fix warning in RCTImage
[IOS][Changed] - Fix warning in RCTNetwork
Pull Request resolved: facebook#23184

Differential Revision: D13838680

Pulled By: cpojer

fbshipit-source-id: 698303e44bb85a4819abff7d71e0b75936c09dc8

@hramos hramos changed the title Warnings in Xcode ☂️ Resolve Warnings in Xcode Feb 20, 2019

facebook-github-bot added a commit that referenced this issue Feb 21, 2019

Fix xcode warnings (#23565)
Summary:
As part of #22609, this fixes yet more warnings.
- Adding more __unused to params.
- Refactors `isPackagerRunning` to use NSURLSession.
- Turns off suspicious comma warnings

[iOS] [Fixed] - Xcode Warnings
Pull Request resolved: #23565

Differential Revision: D14161151

Pulled By: cpojer

fbshipit-source-id: 339874711eca718fc6151e84737ccc975225d736

mbardauskas added a commit to mbardauskas/react-native that referenced this issue Feb 21, 2019

Fix xcode warnings (facebook#23565)
Summary:
As part of facebook#22609, this fixes yet more warnings.
- Adding more __unused to params.
- Refactors `isPackagerRunning` to use NSURLSession.
- Turns off suspicious comma warnings

[iOS] [Fixed] - Xcode Warnings
Pull Request resolved: facebook#23565

Differential Revision: D14161151

Pulled By: cpojer

fbshipit-source-id: 339874711eca718fc6151e84737ccc975225d736

facebook-github-bot added a commit that referenced this issue Feb 22, 2019

Fix RNTester warnings (#23584)
Summary:
Part of #22609. This brings the warning count down to 0 for the RNTester target, also adds a fancy new icon!

[General] [Fixed] - All RNTester warnings fixed
Pull Request resolved: #23584

Differential Revision: D14181197

Pulled By: cpojer

fbshipit-source-id: 4377a55cee6a2d87a7926f1c34663b8a070aef88
@cpojer

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

@hramos I ticked off what I believe has been done. Is it really everything and are the warnings gone or do we have warnings remaining?

As a next step, could we make warnings land blocking so that we don't end up introducing new warnings? There is no point in having these warnings if we don't act on them.

@pvinis

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

There is just one more Xcode 10.1 warning about the RNTester project.
It's warning: All interface orientations must be supported unless the app requires full screen. which should be solved with something from https://stackoverflow.com/questions/37168888/ios-9-warning-all-interface-orientations-must-be-supported-unless-the-app-req.

There are still some for React, yoga and third-party.
There are some yellow boxes popping up when we run RNTester.
Also, for Xcode 10.2 we can do a new PR when it's out of beta I guess?

@cpojer

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

There may be a few warnings here and there that are introduced, but overall we made great progress and got rid of almost all existing warnings. Let's make sure we don't introduce new warnings!

@cpojer cpojer closed this Mar 19, 2019

🛠 Updated Tooling automation moved this from In progress to Done Mar 19, 2019

@hramos

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@cpojer I have a PR that will fail CI builds on warnings: #24035

@cpojer

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Oh nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.