New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node 4] Prepare for Node 4 #2545

Closed
ide opened this Issue Sep 3, 2015 · 12 comments

Comments

Projects
None yet
9 participants
@ide
Collaborator

ide commented Sep 3, 2015

I believe the codebase is in good shape for Node 4.0. It's going to be much better when we can tell people just to get the latest version of Node without any of the io.js confusion.

Things that need to be done:

  • Update the documentation to tell people to install Node.js 4 or newer (#2546)
  • Update the version check message in the packager (#2547)
  • Test with Node 4.0 RC. Some of the native modules like the WebSockets library may break since V8 is probably being upgraded from 4.4 to 4.5 but I expect we're OK since NAN is designed to protect against this.
  • Upgrade the Travis CI tests to run against Node 4.0 (#2548)
  • Fix jest, which breaks when mocking bound functions (facebook/jest#488)

cc @vjeux and @cpojer I think you will be excited

@ide ide self-assigned this Sep 3, 2015

@cpojer

This comment has been minimized.

Show comment
Hide comment
@cpojer

cpojer Sep 3, 2015

Contributor
  • Does it have arrow functions like Chrome 45?
  • Where can I find the RC?
Contributor

cpojer commented Sep 3, 2015

  • Does it have arrow functions like Chrome 45?
  • Where can I find the RC?
@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Sep 3, 2015

Collaborator

The RC is potentially getting cut later today. If the V8 4.5 upgrade lands in time, then I believe it includes arrow functions (that aren't broken and behind a flag like in 3.x).

Collaborator

ide commented Sep 3, 2015

The RC is potentially getting cut later today. If the V8 4.5 upgrade lands in time, then I believe it includes arrow functions (that aren't broken and behind a flag like in 3.x).

@cpojer

This comment has been minimized.

Show comment
Hide comment
@cpojer

cpojer Sep 3, 2015

Contributor

They are now shipped natively in Chrome, and they are awesome.

Contributor

cpojer commented Sep 3, 2015

They are now shipped natively in Chrome, and they are awesome.

@vjeux

This comment has been minimized.

Show comment
Hide comment
@vjeux

vjeux Sep 4, 2015

Contributor

Me gusta

Contributor

vjeux commented Sep 4, 2015

Me gusta

@ide ide changed the title from Prepare for Node 4 to [Node 4] Prepare for Node 4 Sep 5, 2015

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Sep 5, 2015

Collaborator

Some good news: react-native installs fine with 4.0.0-rc.1. The packager, Chrome debugger, and React devtools all work with the UIExplorer. All of the jest tests pass except this one:

 FAIL  Libraries/Utilities/__tests__/MessageQueue-test.js
SyntaxError: react-native/Libraries/Utilities/__tests__/MessageQueue-test.js: react-native/Libraries/Utilities/MessageQueue.js: react-native/Libraries/JavaScriptAppEngine/System/JSTimers/JSTimersExecution.js: Unexpected identifier
  at Function (native)
  at makeComponent (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:157:15)
  at generateMock (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:222:16)
  at Object.generateFromMetadata (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:255:14)

jest bug opened here: facebook/jest#488. react-native tests pass with facebook/jest#489.

Collaborator

ide commented Sep 5, 2015

Some good news: react-native installs fine with 4.0.0-rc.1. The packager, Chrome debugger, and React devtools all work with the UIExplorer. All of the jest tests pass except this one:

 FAIL  Libraries/Utilities/__tests__/MessageQueue-test.js
SyntaxError: react-native/Libraries/Utilities/__tests__/MessageQueue-test.js: react-native/Libraries/Utilities/MessageQueue.js: react-native/Libraries/JavaScriptAppEngine/System/JSTimers/JSTimersExecution.js: Unexpected identifier
  at Function (native)
  at makeComponent (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:157:15)
  at generateMock (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:222:16)
  at Object.generateFromMetadata (react-native/node_modules/jest-cli/src/lib/moduleMocker.js:255:14)

jest bug opened here: facebook/jest#488. react-native tests pass with facebook/jest#489.

@cpojer

This comment has been minimized.

Show comment
Hide comment
@cpojer

cpojer Sep 5, 2015

Contributor

👍 I have a reasonably important bug to fix for jest, I'll do that on Tuesday and tag 0.5.2.

Contributor

cpojer commented Sep 5, 2015

👍 I have a reasonably important bug to fix for jest, I'll do that on Tuesday and tag 0.5.2.

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Sep 8, 2015

Collaborator

All tests are green! https://travis-ci.org/facebook/react-native/builds/79353110

@vjeux could you find someone to look at #2548 (upgrade jest + travis), #2547 (add message to the packager), and #2546 (update docs) in that order? Once #2548 is in, we can also cherry-pick 7f65971 over to 0.11-stable and ship Node 4.x support with 0.11 and not think about "io.js" any more.

EDIT: I went ahead with cherry-picking 7f65971

Collaborator

ide commented Sep 8, 2015

All tests are green! https://travis-ci.org/facebook/react-native/builds/79353110

@vjeux could you find someone to look at #2548 (upgrade jest + travis), #2547 (add message to the packager), and #2546 (update docs) in that order? Once #2548 is in, we can also cherry-pick 7f65971 over to 0.11-stable and ship Node 4.x support with 0.11 and not think about "io.js" any more.

EDIT: I went ahead with cherry-picking 7f65971

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Sep 8, 2015

Collaborator

@ide 😍

Collaborator

brentvatne commented Sep 8, 2015

@ide 😍

@alinz

This comment has been minimized.

Show comment
Hide comment
@alinz

alinz Sep 9, 2015

Contributor

👍

Contributor

alinz commented Sep 9, 2015

👍

@cyprusglobe

This comment has been minimized.

Show comment
Hide comment

👍

@brunoksato

This comment has been minimized.

Show comment
Hide comment

+1

@chirag04

This comment has been minimized.

Show comment
Hide comment
@chirag04

chirag04 Nov 26, 2015

Collaborator

Seems like everything is in place for node 4 now.

Collaborator

chirag04 commented Nov 26, 2015

Seems like everything is in place for node 4 now.

@chirag04 chirag04 closed this Nov 26, 2015

@hramos hramos referenced this issue May 11, 2018

Closed

[Node 8] Prepare for Node 8 #19226

11 of 11 tasks complete

@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.