Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch implementation does not support streams from the spec - needs implementation in React Native core #27741

Open
pcowgill opened this issue Jan 11, 2020 · 2 comments

Comments

@pcowgill
Copy link

@pcowgill pcowgill commented Jan 11, 2020

React Native has not implemented fetch on top of native APIs, and the fetch polyfill built on top of XHR does not support streams where response.body is a getter for a ReadableStream.

React Native version:

0.61.4

Steps To Reproduce

Use fetch and see that response.body is undefined rather than a getter for a ReadableStream according the the fetch spec.

Describe what you expected to happen:

I expected for response.body to be defined.

Related issues

#9629
#12912
github/fetch#746 (comment) (cc @MattiasBuelens)

@pcowgill pcowgill added the Bug label Jan 11, 2020
@pcowgill pcowgill changed the title fetch implementation does not support streams despite them being in the spec fetch implementation does not support streams from the spec - needs implementation in React Native core Jan 11, 2020
@pcowgill

This comment has been minimized.

Copy link
Author

@pcowgill pcowgill commented Jan 13, 2020

React Native also has a Canny board for feature requests I previously was unaware of. If you come across this GitHub issue and care about this feature being prioritized, please feel free to upvote it over there as well. Thanks!

https://react-native.canny.io/feature-requests/p/fetch-streaming-body

@pcowgill

This comment has been minimized.

Copy link
Author

@pcowgill pcowgill commented Jan 22, 2020

Let's create a fork of github/fetch under the Facebook org so we can open pull requests against it without worrying about breaking legacy browsers that are using github/fetch.

As discussed here github/fetch#746

cc @hugomrdias @cpojer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.