New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure the app that should open when starting debugging #5051

Closed
axemclion opened this Issue Dec 30, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@axemclion
Contributor

axemclion commented Dec 30, 2015

When trying to debug a ReactNative today, the ReactNative packager opens google-chrome. This is hard coded into packager.
Could we make this depend on an environment variable, just like we do for the editor ? This way, other tool chains can also be attached for debugging ReactNative apps.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Dec 30, 2015

Hey axemclion, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

facebook-github-bot commented Dec 30, 2015

Hey axemclion, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!
@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Dec 30, 2015

Contributor

I am working on Reactnative support for VSCode and we would like to attach VSCode as a debugging in ReactNative.

This was also briefly discussed on twitter with @tadeuzagallo

I could send in a PR if this looks like something we could do.

Contributor

axemclion commented Dec 30, 2015

I am working on Reactnative support for VSCode and we would like to attach VSCode as a debugging in ReactNative.

This was also briefly discussed on twitter with @tadeuzagallo

I could send in a PR if this looks like something we could do.

@tadeuzagallo

This comment has been minimized.

Show comment
Hide comment
@tadeuzagallo

tadeuzagallo Jan 12, 2016

Contributor

Hey, sorry for the delay, I was on holidays for a while, and am catching up now.

The reason I asked you to open an issue was that I wasn't sure how much of the environment could you control (preprocessor macros, environment variables, etc.) but if environment variables work for you, I think it'd be okay.

/cc @davidaurelio @martinbigio

Contributor

tadeuzagallo commented Jan 12, 2016

Hey, sorry for the delay, I was on holidays for a while, and am catching up now.

The reason I asked you to open an issue was that I wasn't sure how much of the environment could you control (preprocessor macros, environment variables, etc.) but if environment variables work for you, I think it'd be okay.

/cc @davidaurelio @martinbigio

@martinbigio

This comment has been minimized.

Show comment
Hide comment
@martinbigio

martinbigio Jan 12, 2016

Contributor

Sounds good to me! Thanks for working on this :)

Contributor

martinbigio commented Jan 12, 2016

Sounds good to me! Thanks for working on this :)

@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Jan 14, 2016

Contributor

We should be able to send in a pull request for this. I guess the only other piece of information that we would need is the root of the project. The debug is triggered from the packager, and a custom IDE connecting to this debugger cannot know just from the packager about the root of the project. We could send in a pull request with the changes for review.

Contributor

axemclion commented Jan 14, 2016

We should be able to send in a pull request for this. I guess the only other piece of information that we would need is the root of the project. The debug is triggered from the packager, and a custom IDE connecting to this debugger cannot know just from the packager about the root of the project. We could send in a pull request with the changes for review.

@jsierles

This comment has been minimized.

Show comment
Hide comment
@jsierles

jsierles Mar 20, 2016

Contributor

Closing as REACT_DEBUGGER was implemented in the accepted PR #5683. Thanks for bringing this up!

Contributor

jsierles commented Mar 20, 2016

Closing as REACT_DEBUGGER was implemented in the accepted PR #5683. Thanks for bringing this up!

@jsierles jsierles closed this Mar 20, 2016

ghost pushed a commit that referenced this issue Apr 7, 2016

Added support for JavaScript third-party debuggers
Summary:* Add ability to configure the app that should open when starting debugging

axemclion discussed this feature with tadeuzagallo and martinbigio on: #5051
Closes #5683

Reviewed By: martinbigio

Differential Revision: D2971497

Pulled By: mkonicek

fb-gh-sync-id: 91c3ce68feed989658124bb96cb61d03dd032599
fbshipit-source-id: 91c3ce68feed989658124bb96cb61d03dd032599

zebulgar added a commit to nightingale/react-native that referenced this issue Jun 18, 2016

Added support for JavaScript third-party debuggers
Summary:* Add ability to configure the app that should open when starting debugging

axemclion discussed this feature with tadeuzagallo and martinbigio on: facebook#5051
Closes facebook#5683

Reviewed By: martinbigio

Differential Revision: D2971497

Pulled By: mkonicek

fb-gh-sync-id: 91c3ce68feed989658124bb96cb61d03dd032599
fbshipit-source-id: 91c3ce68feed989658124bb96cb61d03dd032599

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.