[0.20] [Android] screenPhysicalPixels undefined

[mikefowler]

Changes in 228a1fe appear to have broken Android. The requiring of Dimensions throws the following error:

undefined is not an object (evaluating 'screenPhysicalPixels.width')

[facebook-github-bot]

Hey mikefowler, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

• If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
• If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
• We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

[ames89]

+1

I'm having the same issue, on the file react-native/Libraries/Utilities/Dimensions.js

in the object

dimensions.screen = {
width: screenPhysicalPixels.width / screenPhysicalPixels.scale,
height: screenPhysicalPixels.height / screenPhysicalPixels.scale,
scale: screenPhysicalPixels.scale,
fontScale: screenPhysicalPixels.fontScale,
};

[gre]

Just reached the same problem. Any workaround?

[gre]

Ok I think actually it's a caching bug. I've removed the app from my phone and it worked.
make sure you also npm install from scratch

[RyanMitchellWilson]

Just tried removing the app, installed fresh node modules and reinstalled the app to the emulator and I'm still getting the same error.

[mikefowler]

I've also repeated similar steps to no avail:

1. Removed app from device
2. Stopped packager
3. rm -rf $TMPDIR/react-* to clear packager cache
4. rm -rf node_modules && npm install to reinstall all dependencies
5. npm start
6. react-native run-android

Same error.

[southerneer]

Same here. Tried @mikefowler 's steps and same result.

[paulbao]

same Issue, my workaround is change it to:
// if (Platform.OS === 'android') {
// // Screen and window dimensions are different on android
// var screenPhysicalPixels = dimensions.screenPhysicalPixels;
// dimensions.screen = {
// width: screenPhysicalPixels.width / screenPhysicalPixels.scale,
// height: screenPhysicalPixels.height / screenPhysicalPixels.scale,
// scale: screenPhysicalPixels.scale,
// fontScale: screenPhysicalPixels.fontScale,
// };

// // delete so no callers rely on this existing
// delete dimensions.screenPhysicalPixels;
// } else {
dimensions.screen = dimensions.window;
// }

in 'Libraries/Utilities/Dimensions.js'

[rameshvishnoi90904]

@paulbao it worked.

[paulbao]

Could you please help to confirm if it works now?

[rameshvishnoi90904]

@paulbao i am using android device and its working fine along with react-native @0.20

[paulbao]

@rameshvishnoi90904 Yes, you are right mate. I just forget to change dependencies.
compile "com.facebook.react:react-native:0.20.+"
I guest we all made the same mistake.

[xfworld]

+1

[pppluto]

@rameshvishnoi90904 @paulbao you're right. 🍻

[RyanMitchellWilson]

@satya164 why was this closed? This hasn't been fixed yet and I'd really rather not have to dig into my node_modules and fix the code everytime I reinstall them.

[gre]

@RyanMitchellWilson actually there are no bugs. grep for 0.19, you probably have an old version somewhere.

[mikefowler]

Confirmed. Though it's unclear if we all did something wrong or if react-native upgrade failed to update the string in android/app/build.gradle.

[sreesharp]

Confirmed. Updating build.gradle works.

[paulbao]

@mikefowler I updated react-native manually and it's my mistake not to update build.gradle also.

[zxcpoiu]

confirmed.

At first, I update react native only by change dependency in packge.json then just npm install again, it did NOT update build.gradle for you. That's what I was doing wrong.

If you are just running example or simple project without any specific settings, maybe it's proper to use react-native upgrade, it will detect conflicts and ask your confirm to overwrite like:

 conflict .gitignore
? Overwrite .gitignore? do not overwrite
     skip .gitignore

 conflict ios/project.xcodeproj/project.pbxproj
? Overwrite ios/project.xcodeproj/project.pbxproj? overwrite
    force ios/project.xcodeproj/project.pbxproj

 conflict android/app/build.gradle
? Overwrite android/app/build.gradle? overwrite
    force android/app/build.gradle

 conflict android/app/proguard-rules.pro
? Overwrite android/app/proguard-rules.pro? overwrite
    force android/app/proguard-rules.pro

[kunkun12]

change android/app/build.gradle file compile "com.facebook.react:react-native:0.20.+" has solved

[aoriani]

Can someone point out which exact version of react-native fixes it? 0.20.1? Using + is discouraged and gives you a nice lint warning. I prefer to have a fixed version.

[aoriani]

Okay. I verified that compile 'com.facebook.react:react-native:0.20.1' does the job.