New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packager assume that every method named require is module loader function #5988

Closed
gorangajic opened this Issue Feb 17, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@gorangajic
Contributor

gorangajic commented Feb 17, 2016

I have tried to use primus.io with react-native and they are using Primus.require method wrapper so same lib can work in browser and in node.js. Packager throw error that was not able to find stream module but they have try/catch there with a fallback when stream module is not found. So packager should not preload that script and throw error

Unable to resolve module stream

There is a workaround and I have already created pull request there so it's not that urgent primus/primus#432

sorry if there is same issue already but was not able to find any.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Feb 17, 2016

Hey gorangajic, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!
@mkonicek

This comment has been minimized.

Contributor

mkonicek commented Jul 29, 2016

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/packager-assume-that-every-method-named-require-is-module-loader-function

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top

Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@mkonicek mkonicek closed this Jul 29, 2016

@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.