New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpg embeds not supported #646

Closed
debreuil opened this Issue Apr 3, 2015 · 7 comments

Comments

Projects
None yet
8 participants
@debreuil

debreuil commented Apr 3, 2015

Using 0.3.4 I am able to embed png files with the {image!...} syntax, however if there is a jpg referenced there it will crash with the Requiring unknown module {image!...} error. A workaround for now is to rename the jpg extension to png (no need to convert the actual file format, just the name).

It seems jpg files do no get written into the encoding format, at least they don't appear in the debugger. To reproduce I'm able to just convert an image in the UIExplorer sample to a jpg and re-embed it.

@pincheira

This comment has been minimized.

Show comment
Hide comment
@pincheira

pincheira Apr 14, 2015

Just checked it again, still happening. Current solution is still renaming from jpg to png.

Thanks @debreuil

pincheira commented Apr 14, 2015

Just checked it again, still happening. Current solution is still renaming from jpg to png.

Thanks @debreuil

@frantic frantic added the packager label Apr 14, 2015

@frantic frantic assigned frantic and amasad and unassigned frantic Apr 14, 2015

@amasad

This comment has been minimized.

Show comment
Hide comment
@amasad

amasad Apr 21, 2015

Contributor

This landed internally, should land here next sync.

Contributor

amasad commented Apr 21, 2015

This landed internally, should land here next sync.

@amasad

This comment has been minimized.

Show comment
Hide comment
@amasad

amasad Apr 27, 2015

Contributor

This should be landed. Reopen if it doesn't work

assetExts: ['png', 'jpeg', 'jpg']

Contributor

amasad commented Apr 27, 2015

This should be landed. Reopen if it doesn't work

assetExts: ['png', 'jpeg', 'jpg']

@amasad amasad closed this Apr 27, 2015

@yelled3

This comment has been minimized.

Show comment
Hide comment
@yelled3

yelled3 May 14, 2015

Contributor

@amasad I'm using version "0.4.2" and this is still happening...

image filename is grumpy.jpg

the asset name is grumpy

and loading it with:

var grumpyImage = require('image!grumpy');

ios simulator screen shot may 14 2015 5 28 17 pm

WDYT?

Contributor

yelled3 commented May 14, 2015

@amasad I'm using version "0.4.2" and this is still happening...

image filename is grumpy.jpg

the asset name is grumpy

and loading it with:

var grumpyImage = require('image!grumpy');

ios simulator screen shot may 14 2015 5 28 17 pm

WDYT?

@dvine-multimedia

This comment has been minimized.

Show comment
Hide comment
@dvine-multimedia

dvine-multimedia May 27, 2015

I have the same issue with 0.4.4

dvine-multimedia commented May 27, 2015

I have the same issue with 0.4.4

@amasad

This comment has been minimized.

Show comment
Hide comment
@amasad

amasad Jun 2, 2015

Contributor

Try the comment here #521 (comment)

Contributor

amasad commented Jun 2, 2015

Try the comment here #521 (comment)

@andersryanc

This comment has been minimized.

Show comment
Hide comment
@andersryanc

andersryanc Sep 22, 2015

Contributor

Same thing here, using react-native 0.11.0. Maybe the docs should be updated to mention this issue (similar to how there is a note under static resources about needing to rebuild after adding new images)?

screen shot 2015-09-22 at 9 36 07 am

Contributor

andersryanc commented Sep 22, 2015

Same thing here, using react-native 0.11.0. Maybe the docs should be updated to mention this issue (similar to how there is a note under static resources about needing to rebuild after adding new images)?

screen shot 2015-09-22 at 9 36 07 am

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.