fix memory leak in Chrome debugging #11341

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@EmingK
Contributor

EmingK commented Dec 7, 2016

RCTWebSocketExecutor saves every WebSocket callback when sending message to chrome, but does not clear them in a debug session until the JS bridge is reloaded, and there may be thousands of blocks saved in the callback table. This PR removes them after they are called.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Dec 7, 2016

By analyzing the blame information on this pull request, we identified @javache and @omeid to be potential reviewers.

By analyzing the blame information on this pull request, we identified @javache and @omeid to be potential reviewers.

@javache

This comment has been minimized.

Show comment
Hide comment
Member

javache commented Dec 7, 2016

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Dec 7, 2016

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mkonicek added a commit that referenced this pull request Dec 12, 2016

fix memory leak in Chrome debugging
Summary:
`RCTWebSocketExecutor` saves every WebSocket callback when sending message to chrome, but does not clear them in a debug session until the JS bridge is reloaded, and there may be thousands of blocks saved in the callback table. This PR removes them after they are called.
Closes #11341

Differential Revision: D4295710

Pulled By: javache

fbshipit-source-id: 29a02d1aba320115bbb97aee8981e34b89303c91

DanielMSchmidt added a commit to DanielMSchmidt/react-native that referenced this pull request Jan 4, 2017

fix memory leak in Chrome debugging
Summary:
`RCTWebSocketExecutor` saves every WebSocket callback when sending message to chrome, but does not clear them in a debug session until the JS bridge is reloaded, and there may be thousands of blocks saved in the callback table. This PR removes them after they are called.
Closes facebook#11341

Differential Revision: D4295710

Pulled By: javache

fbshipit-source-id: 29a02d1aba320115bbb97aee8981e34b89303c91

@EmingK EmingK deleted the EmingK:fix_iOSWebSocketLeak branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment