Apple TV support 6: Add tvOS target to react-native-cli template project #11591

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
3 participants
@dlowder-salesforce
Collaborator

dlowder-salesforce commented Dec 22, 2016

Motivation

New iOS project generation with react-native-cli should allow developers to build for Apple TV as well as iPhone/iPad.

Test plan

Added to scripts/run-ci-e2e-tests.js and .travis.yml to have the new tvOS target automatically built and tested in Travis CI.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Dec 22, 2016

By analyzing the blame information on this pull request, we identified @mkonicek and @javache to be potential reviewers.

By analyzing the blame information on this pull request, we identified @mkonicek and @javache to be potential reviewers.

@mkonicek

This comment has been minimized.

Show comment
Hide comment
@mkonicek

mkonicek Dec 31, 2016

Contributor

Thanks for adding it @dlowder-salesforce, including tests! I wonder if it should be behind a flag since not everyone will use the extra Xcode stuff to build for tvOS but it's not so much code so merging :)

Contributor

mkonicek commented Dec 31, 2016

Thanks for adding it @dlowder-salesforce, including tests! I wonder if it should be behind a flag since not everyone will use the extra Xcode stuff to build for tvOS but it's not so much code so merging :)

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Dec 31, 2016

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

DanielMSchmidt added a commit to DanielMSchmidt/react-native that referenced this pull request Jan 4, 2017

Apple TV support 6: Add tvOS target to react-native-cli template project
Summary:
**Motivation**

New iOS project generation with react-native-cli should allow developers to build for Apple TV as well as iPhone/iPad.

**Test plan**

Added to `scripts/run-ci-e2e-tests.js` and `.travis.yml` to have the new tvOS target automatically built and tested in Travis CI.
Closes facebook#11591

Differential Revision: D4375593

Pulled By: mkonicek

fbshipit-source-id: 4e241caa400a88e6b2f91416fa26b48ae01cb7b6

koenpunt added a commit to koenpunt/react-native that referenced this pull request Jan 7, 2017

Apple TV support 6: Add tvOS target to react-native-cli template project
Summary:
**Motivation**

New iOS project generation with react-native-cli should allow developers to build for Apple TV as well as iPhone/iPad.

**Test plan**

Added to `scripts/run-ci-e2e-tests.js` and `.travis.yml` to have the new tvOS target automatically built and tested in Travis CI.
Closes facebook#11591

Differential Revision: D4375593

Pulled By: mkonicek

fbshipit-source-id: 4e241caa400a88e6b2f91416fa26b48ae01cb7b6

kathawthorne pushed a commit to KetoThrive/react-native that referenced this pull request Feb 3, 2017

Apple TV support 6: Add tvOS target to react-native-cli template project
Summary:
**Motivation**

New iOS project generation with react-native-cli should allow developers to build for Apple TV as well as iPhone/iPad.

**Test plan**

Added to `scripts/run-ci-e2e-tests.js` and `.travis.yml` to have the new tvOS target automatically built and tested in Travis CI.
Closes facebook#11591

Differential Revision: D4375593

Pulled By: mkonicek

fbshipit-source-id: 4e241caa400a88e6b2f91416fa26b48ae01cb7b6

@dlowder-salesforce dlowder-salesforce deleted the dlowder-salesforce:local-cli-tvos branch Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment