Fix template release build: Add -ObjC and -lc++ to tests target #11889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @mkonicek and @dlowder-salesforce to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Jan 19, 2017
Summary: Fixes facebook#11861 - the release config is currently broken for projects created by `react-native init` in `master`, 0.40 and 0.39. I'm still investigating when and how this got broken but this seems to be a clean fix. I've added `-ObjC` as well to match the main target but I'm not sure yet whether that's necessary. To test: ``` react-native init fooproject --version react-native@rh389/react-native#missinglinkerflags ``` Open in XCode, Edit scheme (⌘<), Change `Build Configuration` to `Release`, build. Update: The `-lc++` flag became necessary when facebook@33deaad landed because of the libstdc++ dependencies of `RCTLog`. Still not sure about `-ObjC`. javache ? Closes facebook#11889 Differential Revision: D4421685 Pulled By: javache fbshipit-source-id: 954edaef773f8cef7b7ad671fa4d1f2bfc2f20f2
grabbou
pushed a commit
that referenced
this pull request
Feb 2, 2017
Summary: Fixes #11861 - the release config is currently broken for projects created by `react-native init` in `master`, 0.40 and 0.39. I'm still investigating when and how this got broken but this seems to be a clean fix. I've added `-ObjC` as well to match the main target but I'm not sure yet whether that's necessary. To test: ``` react-native init fooproject --version react-native@rh389/react-native#missinglinkerflags ``` Open in XCode, Edit scheme (⌘<), Change `Build Configuration` to `Release`, build. Update: The `-lc++` flag became necessary when 33deaad landed because of the libstdc++ dependencies of `RCTLog`. Still not sure about `-ObjC`. javache ? Closes #11889 Differential Revision: D4421685 Pulled By: javache fbshipit-source-id: 954edaef773f8cef7b7ad671fa4d1f2bfc2f20f2
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Fixes facebook/react-native#11861 - the release config is currently broken for projects created by `react-native init` in `master`, 0.40 and 0.39. I'm still investigating when and how this got broken but this seems to be a clean fix. I've added `-ObjC` as well to match the main target but I'm not sure yet whether that's necessary. To test: ``` react-native init fooproject --version react-native@rh389/react-native#missinglinkerflags ``` Open in XCode, Edit scheme (⌘<), Change `Build Configuration` to `Release`, build. Update: The `-lc++` flag became necessary when facebook/react-native@33deaad landed because of the libstdc++ dependencies of `RCTLog`. Still not sure about `-ObjC`. javache ? Closes facebook/react-native#11889 Differential Revision: D4421685 Pulled By: javache fbshipit-source-id: 954edaef773f8cef7b7ad671fa4d1f2bfc2f20f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11861 - the release config is currently broken for projects created by
react-native initinmaster, 0.40 and 0.39.I'm still investigating when and how this got broken but this seems to be a clean fix. I've added
-ObjCas well to match the main target but I'm not sure yet whether that's necessary.To test:
Open in XCode, Edit scheme (⌘<), Change
Build ConfigurationtoRelease, build.Update: The
-lc++flag became necessary when 33deaad landed because of the libstdc++ dependencies ofRCTLog. Still not sure about-ObjC. @javache ?