New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5688 onChangeVisibleRows for Android #11945

Closed
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@ptomasroos
Contributor

ptomasroos commented Jan 17, 2017

This PR includes a fix for the old missing feature of onChangeVisibleRows on Android.
Fixes #5688
Also reported on product pains https://productpains.com/post/react-native/listview-onchangevisiblerows-android-support

Test plan (required)

Test through UIExplorer which has a callback on the ListView Paging example and walking through rows + sections and making sure visible rows matches to whats visible.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Jan 17, 2017

By analyzing the blame information on this pull request, we identified @AaaChiuuu and @foghina to be potential reviewers.

@ptomasroos ptomasroos changed the title from On change visible rows for android to Fixes #5688 onChangeVisibleRows for Android Jan 18, 2017

@ptomasroos

This comment has been minimized.

Contributor

ptomasroos commented Jan 18, 2017

@ptomasroos

This comment has been minimized.

Contributor

ptomasroos commented Jan 26, 2017

@hramos Can we get someone to look at this ?

ptomasroos added some commits Jan 27, 2017

Merge scheduled updated to not miss frames
Since the ScrollEvent pool throttles updates before could be missed
in the case of very fast scrolling.

These scheduled update frames are now being merged in the case an
event is within the pool.

@ptomasroos ptomasroos closed this Jan 30, 2017

@johnnycopperstone

This comment has been minimized.

johnnycopperstone commented Feb 1, 2017

Does anyone know when this might be released please?

@vitorebatista

This comment has been minimized.

vitorebatista commented Feb 12, 2017

Why this PR is close?

@ptomasroos

This comment has been minimized.

Contributor

ptomasroos commented Feb 12, 2017

@johnnycopperstone

This comment has been minimized.

johnnycopperstone commented Feb 12, 2017

flatlist?

@philipheinser

This comment has been minimized.

Contributor

philipheinser commented Feb 14, 2017

@ptomasroos Can we use flat list in rn-0.42.0 or do we have to checkout master?

@dthuering

This comment has been minimized.

dthuering commented Feb 22, 2017

Would still be nice when that error would be fixed anyway.
When will flatlist be production ready?

@rborn

This comment has been minimized.

rborn commented Feb 22, 2017

@ptomasroos why can't this be merged? FlatList is still experimental and people still use the normal listview...
Thanks.

@ptomasroos

This comment has been minimized.

Contributor

ptomasroos commented Feb 22, 2017

No one took a look on it for quite some time. Feel free to copy the branch and open a PR if you need it! We've migrated to FlatList

@philipheinser

This comment has been minimized.

Contributor

philipheinser commented Feb 22, 2017

@ptomasroos How can I use FlatList right now? Do you use the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment