use https for bash links #12090
Closed
use https for bash links #12090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never a good idea to pipe a bash file from `http` into `sudo`
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@facebook-github-bot shipit |
|
@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
edmofro
pushed a commit
to edmofro/react-native
that referenced
this pull request
Feb 6, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 7, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
normanjoyner
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Feb 9, 2017
Summary: Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk. Closes facebook#12090 Differential Revision: D4474065 fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never a good idea to pipe a bash file from
httpintosudo. Usinghttpsmitigates some of this risk.