Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https for bash links #12090

Closed
wants to merge 1 commit into from
Closed

use https for bash links #12090

wants to merge 1 commit into from

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Jan 27, 2017

Never a good idea to pipe a bash file from http into sudo. Using https mitigates some of this risk.

Never a good idea to pipe a bash file from `http` into `sudo`
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 27, 2017
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ide
Copy link
Contributor

ide commented Jan 27, 2017

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2017

@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@xavdid xavdid deleted the patch-1 branch Jan 27, 2017
edmofro pushed a commit to edmofro/react-native that referenced this issue Feb 6, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 7, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
normanjoyner pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
Summary:
Never a good idea to pipe a bash file from `http` into `sudo`. Using `https` mitigates some of this risk.
Closes facebook#12090

Differential Revision: D4474065

fbshipit-source-id: 99d29ae112ae0edef5bd662d439b5da673c5c79f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants