New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for preventing swipe left or swipe right #14684

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@lprhodes
Contributor

lprhodes commented Jun 22, 2017

The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.

Support for preventing swipe left or swipe right
The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.
@lprhodes

This comment has been minimized.

Show comment
Hide comment
@lprhodes

lprhodes Jun 22, 2017

Contributor

I'd appreciate suggestions on how to provide a solid test plan for this...it's a pretty minor change.

Contributor

lprhodes commented Jun 22, 2017

I'd appreciate suggestions on how to provide a solid test plan for this...it's a pretty minor change.

@skevy skevy requested a review from sahrens Jul 8, 2017

@sahrens

sahrens approved these changes Jul 8, 2017

This doesn't seem ideal, but if this solves a problem for you it's fine.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Jul 8, 2017

@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented Jul 8, 2017

@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@migueloller

This comment has been minimized.

Show comment
Hide comment
@migueloller

migueloller Jul 8, 2017

There is already a way to prevent the "swipe to go back" functionality in React Navigation.

See gesturesEnabled.

migueloller commented Jul 8, 2017

There is already a way to prevent the "swipe to go back" functionality in React Navigation.

See gesturesEnabled.

@lprhodes

This comment has been minimized.

Show comment
Hide comment
@lprhodes

lprhodes Jul 8, 2017

Contributor

@migueloller That isn't the intention. Swipe to go back should still work when used in conjunction with the experimental swipe-able cells. That's not currently the case. Hold on approval though please. I'd like to double check no further amends were made to this.

Contributor

lprhodes commented Jul 8, 2017

@migueloller That isn't the intention. Swipe to go back should still work when used in conjunction with the experimental swipe-able cells. That's not currently the case. Hold on approval though please. I'd like to double check no further amends were made to this.

lprhodes added a commit to lprhodes/react-native that referenced this pull request Jul 8, 2017

Fixes unintended side effects caused by facebook#14684
I had fixed this locally but not updated the original pull request, sorry. This commit is working for us in production.
@lprhodes

This comment has been minimized.

Show comment
Hide comment
@lprhodes

lprhodes Jul 8, 2017

Contributor

Too late - @sahrens can you please look at and approve #14900. Apologies for the mess up.

Contributor

lprhodes commented Jul 8, 2017

Too late - @sahrens can you please look at and approve #14900. Apologies for the mess up.

facebook-github-bot added a commit that referenced this pull request Aug 1, 2017

Fixes unintended side effects caused by #14684
Summary:
I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production.
Closes #14900

Differential Revision: D5539787

Pulled By: hramos

fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74

grabbou added a commit that referenced this pull request Aug 16, 2017

Fixes unintended side effects caused by #14684
Summary:
I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production.
Closes #14900

Differential Revision: D5539787

Pulled By: hramos

fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment