New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set constructor properly in createReactNativeComponentClass #1471

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@sophiebits
Member

sophiebits commented May 31, 2015

Without this, the displayName property wasn't found when looking at
.constructor on a component instance. Fixes facebook/react-devtools#92.

Set constructor properly in createReactNativeComponentClass
Without this, the displayName property wasn't found when looking at
`.constructor` on a component instance. Fixes facebook/react-devtools#92.
@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne May 31, 2015

Collaborator

This fixed the issue for me, nice one @spicyj

It would be great to get this into 0.5.0 as it's a small bugfix so it seems like it might be appropriate cc @vjeux

Collaborator

brentvatne commented May 31, 2015

This fixed the issue for me, nice one @spicyj

It would be great to get this into 0.5.0 as it's a small bugfix so it seems like it might be appropriate cc @vjeux

@vjeux

This comment has been minimized.

Show comment
Hide comment
@vjeux

vjeux Jun 1, 2015

Contributor

@brentvatne: in order to get things to the rc, we have to go through fb internal cherry-pick process and i don't think this is worth it. The goal of the rc is to be as stable as possible and only cherry-pick bug fixes. Cherry-picking features like this makes it harder to figure out what is available in what version.

2 weeks is short enough that we can wait for the next version to get those safely

Contributor

vjeux commented Jun 1, 2015

@brentvatne: in order to get things to the rc, we have to go through fb internal cherry-pick process and i don't think this is worth it. The goal of the rc is to be as stable as possible and only cherry-pick bug fixes. Cherry-picking features like this makes it harder to figure out what is available in what version.

2 weeks is short enough that we can wait for the next version to get those safely

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Jun 1, 2015

Member

This is also not a regression (AFAIK) so that's another reason it can wait.

Member

sophiebits commented Jun 1, 2015

This is also not a regression (AFAIK) so that's another reason it can wait.

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Jun 1, 2015

Collaborator

Sounds good, thanks for the clarification

Collaborator

brentvatne commented Jun 1, 2015

Sounds good, thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment