New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional info for creating Swift modules #1548

Merged
merged 2 commits into from Jun 7, 2015

Conversation

Projects
None yet
3 participants
@kevindeleon
Copy link
Contributor

kevindeleon commented Jun 7, 2015

This may be common knowledge for most Swift/ObjC guys, but it took me quite a while to figure out why I was getting an error when creating/exporting my module. As a web guy coming to the "native" world, it was a bit confusing. I would imagine a lot of RCTN users will be in the same boat.

This is in regards to the following issue #1468

Adds additional info for creating Swift modules
This may be common knowledge for most Swift/ObjC guys, but it took me quite a while to figure out why I was getting an error when creating/exporting my module. As a web guy coming to the "native" world, it was a bit confusing. I would imagine a lot of RCTN users will be in the same boat.
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jun 7, 2015

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jun 7, 2015

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@brentvatne

This comment has been minimized.

Copy link
Collaborator

brentvatne commented Jun 7, 2015

Thanks @kevindeleon! This looks good to me.

brentvatne added a commit that referenced this pull request Jun 7, 2015

Merge pull request #1548 from kevindeleon/patch-1
Adds additional info for creating Swift modules

@brentvatne brentvatne merged commit e712306 into facebook:master Jun 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment