New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Text> module add textDecoration style attributes #1869

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@pcottle
Contributor

pcottle commented Jul 4, 2015

This is simply a rebased and squashed version of @KJlmfe's PR over at #845

It was actually already squashed into one commit, but for some reason that was hard to see from the original PR.

@pcottle

This comment has been minimized.

Show comment
Hide comment
@pcottle

pcottle Jul 4, 2015

Contributor
    ☂ -[UIExplorerTests testTextExampleSnapshot] (1208 ms) (0)

looks like the examples need to be re-recorded, justasec...

Contributor

pcottle commented Jul 4, 2015

    ☂ -[UIExplorerTests testTextExampleSnapshot] (1208 ms) (0)

looks like the examples need to be re-recorded, justasec...

@pcottle

This comment has been minimized.

Show comment
Hide comment
@pcottle

pcottle Jul 4, 2015

Contributor

Re-recorded tests, new image and results:

screen shot 2015-07-04 at 11 10 56 am

testtextexamplesnapshot_1 2x

Contributor

pcottle commented Jul 4, 2015

Re-recorded tests, new image and results:

screen shot 2015-07-04 at 11 10 56 am

testtextexamplesnapshot_1 2x

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Jul 5, 2015

Collaborator

Thanks @pcottle! This looks good to me

Collaborator

brentvatne commented Jul 5, 2015

Thanks @pcottle! This looks good to me

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Jul 6, 2015

Collaborator

It would be great to get this in for 0.8.0-rc if it's ready, we are planning on shipping that sometime in the new couple of days if possible @nicklockwood (#1864)

Collaborator

brentvatne commented Jul 6, 2015

It would be great to get this in for 0.8.0-rc if it's ready, we are planning on shipping that sometime in the new couple of days if possible @nicklockwood (#1864)

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Jul 6, 2015

Contributor

Should be OK - I'll just need to check there are no issues with Android compatibility since it's a shared component.

Contributor

nicklockwood commented Jul 6, 2015

Should be OK - I'll just need to check there are no issues with Android compatibility since it's a shared component.

@sahrens sahrens closed this in b57a14d Jul 9, 2015

aleclarson added a commit to aleclarson/react-native that referenced this pull request Sep 20, 2015

<Text> module add textDecoration style attributes
Summary:
This is simply a rebased and squashed version of @KJlmfe's PR over at facebook#845

It was actually already squashed into one commit, but for some reason that was hard to see from the original PR.
Closes facebook#1869
Github Author: KJlmfe <kjlmfe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment