Suppress lint errors in Dialog module. remove abortOnError=false #19740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Can you rebase? Tests are fine on master after I landed your other PR and the soloader revert. Just want to make sure they stay green before merging this. |
|
I did rebase with master. But CI is failing with with below error which is not related to code or tests.
|
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 15, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
added
✅Test Plan
Missing Changelog
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
…ebook#19740) Summary: Suppress lint errors in Dialog module. remove abortOnError=false. This might hide future problems, so removing it ``` gradle lintOptions { abortOnError false } ``` Builds locally just fine. But CI is failing for unknown reasons. https://circleci.com/gh/dulmandakh/react-native/265 RNTester will built without errors Closes facebook#19740 Differential Revision: D8450600 Pulled By: hramos fbshipit-source-id: faf508a0c546af18a05ee224628f88b02a38ab9f
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
…740)
Summary:
Suppress lint errors in Dialog module. remove abortOnError=false.
This might hide future problems, so removing it
``` gradle
lintOptions {
abortOnError false
}
```
Builds locally just fine. But CI is failing for unknown reasons. https://circleci.com/gh/dulmandakh/react-native/265
RNTester will built without errors
Closes facebook/react-native#19740
Differential Revision: D8450600
Pulled By: hramos
fbshipit-source-id: faf508a0c546af18a05ee224628f88b02a38ab9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress lint errors in Dialog module. remove abortOnError=false.
This might hide future problems, so removing it
lintOptions { abortOnError false }Builds locally just fine. But CI is failing for unknown reasons. https://circleci.com/gh/dulmandakh/react-native/265
Test Plan
RNTester will built without errors