[Image] Add examples to UIExplorer, fix some bugs #1987

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@ptmt
Contributor

ptmt commented Jul 14, 2015

Add two simple examples.
image

Also:

  • do not start the task at DownloadTaskWrapper (it starts from ImageDowloader if image isn't cached yet);
  • fire onLoadAbort event;
  • send more readable error.localizedDescription with onLoadError;
  • rename onLoaded to onLoadEnd
[Image] Add examples to UIExplorer, fix some bugs:
- do not resume task at DownloadTaskWrapper;
- fire loadAbort event;
- send more readable localizedDescription to onLoadError;
- rename 'onLoaded' to 'onLoadEnd'
@sahrens

This comment has been minimized.

Show comment
Hide comment
@sahrens

sahrens Jul 14, 2015

Contributor

Nice examples! More Image stuff for @nicklockwood :)

Contributor

sahrens commented Jul 14, 2015

Nice examples! More Image stuff for @nicklockwood :)

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
Contributor

nicklockwood commented Jul 14, 2015

lgtm. @facebook-github-bot import

@brentvatne

This comment has been minimized.

Show comment
Hide comment
@brentvatne

brentvatne Jul 14, 2015

Collaborator

Nice one @UnknownException!

Collaborator

brentvatne commented Jul 14, 2015

Nice one @UnknownException!

@sahrens sahrens closed this in 74f8055 Jul 15, 2015

dvcrn added a commit to dvcrn/react-native that referenced this pull request Jul 22, 2015

[Image] Add examples to UIExplorer, fix some bugs
Summary:
Add two simple examples.
![image](https://cloud.githubusercontent.com/assets/1004115/8674092/03052652-2a55-11e5-8531-8f01c7970af4.png)

Also:
- do not start the task at DownloadTaskWrapper (it starts from ImageDowloader if image isn't cached yet);
- fire `onLoadAbor`t event;
- send more readable `error.localizedDescription` with `onLoadError`;
- rename `onLoaded` to `onLoadEnd`
Closes facebook#1987
Github Author: Dmitriy Loktev <unknownliveid@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment