New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add missing tests for Animated.forkEvent #20111

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@slorber
Contributor

slorber commented Jul 9, 2018

forkEvent is generally used to intercept an existing listener and add a new js listener to it, considering the original listener can be null/js/Animated.event(). I added tests to ensure the 3 cases of the implementation are all covered.

Test Plan:

Tests are passing

Release Notes:

[INTERNAL] [ENHANCEMENT] [Animated] Add Animated.forkEvent tests for better coverage

@pull-bot

This comment has been minimized.

pull-bot commented Jul 9, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@janicduplessis

This comment has been minimized.

Collaborator

janicduplessis commented Jul 12, 2018

Looks good, thanks!

@janicduplessis

This comment has been minimized.

Collaborator

janicduplessis commented Jul 12, 2018

@facebook-github-bot

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment