Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Android - decouple TextInput cursorColor from selectionColor #20276
Basically I want my cursor to be the same color of the text. Which means obviously that selecting the text will make it invisibible (ie, red text on red selection rectangle)
Today, setting a selection color does set a cursor color, which may be a good default in some cases, but we don't always couple these 2 colors together.
I'd like to be able to set different colors for selection and cursor.
Not sure exactly this can be tested except manually. The initial commit did not introduce test for this method:
[ANDROID] [ENHANCEMENT] [TextInput] - Allow to set cursor color independently from highlight color
changed the title from
Expose TextInput cursorColor for android
Android - decouple TextInput cursorColor from selectionColor
Jul 18, 2018
@slorber I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.