New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - decouple TextInput cursorColor from selectionColor #20276

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@slorber
Contributor

slorber commented Jul 18, 2018

Basically I want my cursor to be the same color of the text. Which means obviously that selecting the text will make it invisibible (ie, red text on red selection rectangle)

Today, setting a selection color does set a cursor color, which may be a good default in some cases, but we don't always couple these 2 colors together.

See original commit of @janicduplessis ae57b25

I'd like to be able to set different colors for selection and cursor.

Test Plan:

Not sure exactly this can be tested except manually. The initial commit did not introduce test for this method:
ae57b25

Release Notes:

[ANDROID] [ENHANCEMENT] [TextInput] - Allow to set cursor color independently from highlight color

@slorber slorber changed the title from Expose TextInput cursorColor for android to Android - decouple TextInput cursorColor from selectionColor Jul 18, 2018

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Aug 17, 2018

@slorber I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment