New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[createReactClass] Remove createReactClass from ProgressBarAndroidExample #21874

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@exced
Copy link
Contributor

exced commented Oct 20, 2018

Related to #21581

This PR was already opened here #21600 but seems to be inactive.

Remove createReactClass from ProgressBarAndroidExample.

Test Plan:

  • yarn run flow && yarn run flow-check-android succeed.
  • RNTester app ProgressBarAndroidExample on Android.

Release Notes:

[GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass

@analysis-bot
Copy link

analysis-bot left a comment

Code analysis results:

  • eslint found some issues.
};

class MovingBar extends React.Component<MovingBarProps, MovingBarState> {
_intervalID: (null: ?IntervalID);

This comment has been minimized.

@analysis-bot

analysis-bot Oct 20, 2018

null: Parsing error: Unexpected token, expected ")"

27 |
28 | class MovingBar extends React.Component<MovingBarProps, MovingBarState> {

29 | _intervalID: (null: ?IntervalID);
| ^
30 |
31 | state = {
32 | progress: 0,

@RSNara RSNara changed the title Remove createReactClass from ProgressBarAndroidExample [createReactClass] Remove createReactClass from ProgressBarAndroidExample Oct 22, 2018

@TheSavior

This comment has been minimized.

Copy link
Member

TheSavior commented Oct 23, 2018

It looks like there are flow errors:

https://circleci.com/gh/facebook/react-native/57688

@exced

This comment has been minimized.

Copy link
Contributor Author

exced commented Oct 23, 2018

I fixed the ESLint issues. Besides I don't have any Flow errors locally, is the config different ?

@TheSavior

This comment has been minimized.

Copy link
Member

TheSavior commented Oct 23, 2018

You need to run with the Android config to check .android.js files.

yarn run flow-check-android
@exced

This comment has been minimized.

Copy link
Contributor Author

exced commented Oct 24, 2018

@TheSavior I updated Props to fit ProgressBarAndroid component. I also exported its props to make it handier for me

@andrew-pyle andrew-pyle referenced this pull request Oct 26, 2018

Closed

Convert components off of createReactClass #21581

15 of 15 tasks complete
@RSNara

RSNara approved these changes Oct 29, 2018

Copy link
Contributor

RSNara left a comment

Looks good! 🧐

@facebook-github-bot
Copy link

facebook-github-bot left a comment

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

react-native-bot commented Nov 2, 2018

@exced merged commit 81e5d64 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Nov 2, 2018

JunielKatarn added a commit to JunielKatarn/react-native that referenced this pull request Feb 11, 2019

Remove createReactClass from ProgressBarAndroidExample (facebook#21874)
Summary:
Related to facebook#21581

This PR was already opened here facebook#21600 but seems to be inactive.

Remove createReactClass from ProgressBarAndroidExample.

- `yarn run flow` && `yarn run flow-check-android` succeed.
- RNTester app ProgressBarAndroidExample on Android.

[GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass
Pull Request resolved: facebook#21874

Reviewed By: TheSavior

Differential Revision: D12827689

Pulled By: RSNara

fbshipit-source-id: 46c70ea67dddf5d928fe936a28ef4a0a929d127f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.