Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Escape #22047

Closed
wants to merge 1 commit into from
Closed

Accessibility Escape #22047

wants to merge 1 commit into from

Conversation

@rustle
Copy link
Contributor

@rustle rustle commented Oct 31, 2018

Test Plan:

Validated functionality using RNTester app and VoiceOver.

Release Notes:

[IOS] [ACCESSIBILITY] - Implements accessibility escape gesture prop

Copy link

@analysis-bot analysis-bot left a comment

Code analysis results:

  • eslint found some issues.

@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>

prettier/prettier: Replace ·onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')} with ⏎··········onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')}⏎·········

@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>

no-alert: Unexpected alert.

@pull-bot
Copy link

@pull-bot pull-bot commented Oct 31, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@rustle
Copy link
Contributor Author

@rustle rustle commented Oct 31, 2018

Copy link

@analysis-bot analysis-bot left a comment

Code analysis results:

  • eslint found some issues.

@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

no-alert: Unexpected alert.

Copy link
Contributor Author

@rustle rustle Oct 31, 2018

not sure what the expectation is here. this example code is consistent with the existing examples.

Copy link

@analysis-bot analysis-bot left a comment

Code analysis results:

  • eslint found some issues.

@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

no-alert: Unexpected alert.

@shergin
Copy link
Contributor

@shergin shergin commented Nov 14, 2018

@rustle Could you please rebase this on master?

@shergin
Copy link
Contributor

@shergin shergin commented Nov 14, 2018

... and make prettier happy?

Copy link

@analysis-bot analysis-bot left a comment

Code analysis results:

  • eslint found some issues.

@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

no-alert: Unexpected alert.

@rustle
Copy link
Contributor Author

@rustle rustle commented Nov 14, 2018

@rustle Could you please rebase this on master?

done

@rustle
Copy link
Contributor Author

@rustle rustle commented Nov 14, 2018

... and make prettier happy?

npm run prettier doesn't show any issues
npm run lint shows 22:37 warning Unexpected alert no-alert but it's not clear what's expected (to me)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Nov 21, 2018

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@estevaolucas
Copy link

@estevaolucas estevaolucas commented Dec 5, 2018

@rustle thanks for adding it. Hopefully, it can be merged "soon". 🤞
(I'm going to need it on my current project)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Contributor

@cpojer cpojer commented Dec 7, 2018

Thanks for working on this. I'm gonna land this PR :)

@react-native-bot
Copy link

@react-native-bot react-native-bot commented Dec 7, 2018

@rustle merged commit ee7c702 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 7, 2018
rozele pushed a commit to microsoft/react-native-windows that referenced this issue Jul 18, 2019
Summary: Pull Request resolved: facebook/react-native#22047

Differential Revision: D13146179

Pulled By: cpojer

fbshipit-source-id: b8a089114a5deafee47dd482e484d413c8c39137
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants