Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Escape #22047

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@rustle
Copy link
Contributor

commented Oct 31, 2018

Test Plan:

Validated functionality using RNTester app and VoiceOver.

Release Notes:

[IOS] [ACCESSIBILITY] - Implements accessibility escape gesture prop

@analysis-bot
Copy link

left a comment

Code analysis results:

  • eslint found some issues.
@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>

This comment has been minimized.

Copy link
@analysis-bot

analysis-bot Oct 31, 2018

prettier/prettier: Replace ·onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')} with ⏎··········onAccessibilityEscape={()·=>·alert('onAccessibilityEscape·success')}⏎·········

@@ -26,6 +26,9 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View onAccessibilityEscape={() => alert('onAccessibilityEscape success')} accessible={true}>

This comment has been minimized.

Copy link
@analysis-bot

analysis-bot Oct 31, 2018

no-alert: Unexpected alert.

@pull-bot

This comment has been minimized.

Copy link

commented Oct 31, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@rustle rustle referenced this pull request Oct 31, 2018

Merged

Accessibility Escape #655

@rustle

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@rustle rustle force-pushed the rustle:master branch from 2f73acf to b91aa8c Oct 31, 2018

@analysis-bot
Copy link

left a comment

Code analysis results:

  • eslint found some issues.
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

This comment has been minimized.

Copy link
@analysis-bot

analysis-bot Oct 31, 2018

no-alert: Unexpected alert.

This comment has been minimized.

Copy link
@rustle

rustle Oct 31, 2018

Author Contributor

not sure what the expectation is here. this example code is consistent with the existing examples.

@rustle rustle force-pushed the rustle:master branch from b91aa8c to d20efc6 Nov 12, 2018

@analysis-bot
Copy link

left a comment

Code analysis results:

  • eslint found some issues.
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

This comment has been minimized.

Copy link
@analysis-bot

analysis-bot Nov 12, 2018

no-alert: Unexpected alert.

@shergin

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

@rustle Could you please rebase this on master?

@shergin

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

... and make prettier happy?

@rustle rustle force-pushed the rustle:master branch from d20efc6 to 114a12d Nov 14, 2018

@analysis-bot
Copy link

left a comment

Code analysis results:

  • eslint found some issues.
@@ -26,6 +26,11 @@ class AccessibilityIOSExample extends React.Component<{}> {
<View onMagicTap={() => alert('onMagicTap success')} accessible={true}>
<Text>Accessibility magic tap example</Text>
</View>
<View
onAccessibilityEscape={() => alert('onAccessibilityEscape success')}

This comment has been minimized.

Copy link
@analysis-bot

analysis-bot Nov 14, 2018

no-alert: Unexpected alert.

@rustle

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@rustle Could you please rebase this on master?

done

@rustle

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

... and make prettier happy?

npm run prettier doesn't show any issues
npm run lint shows 22:37 warning Unexpected alert no-alert but it's not clear what's expected (to me)

@facebook-github-bot
Copy link

left a comment

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Nov 21, 2018

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@elucaswork

This comment has been minimized.

Copy link
Contributor

commented Dec 5, 2018

@rustle thanks for adding it. Hopefully, it can be merged "soon". 🤞
(I'm going to need it on my current project)

@facebook-github-bot
Copy link

left a comment

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

Thanks for working on this. I'm gonna land this PR :)

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

commented Dec 7, 2018

@rustle merged commit ee7c702 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.