Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set blob as default XMLHttpRequest header response type if supported #22063

Closed
wants to merge 1 commit into from

Conversation

@reime005
Copy link
Contributor

reime005 commented Nov 1, 2018

This is a problem that is discussed in issue #21092

Related issues: #21851 #19717

Found the code to eventually fix this issue here

Test Plan

  • Fetching an image locally and check if the blob is there, as well as its size > 0.

Release Notes:


Help reviewers and the release process by writing your own release notes. See below for an example.

[GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 1, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 1, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@farzd

This comment has been minimized.

Copy link

farzd commented Nov 7, 2018

This fixes the quoted issues, i've just patched manually and tested - Please merge

Copy link

facebook-github-bot left a comment

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer

This comment has been minimized.

Copy link
Contributor

cpojer commented Dec 11, 2018

Thank you for sending this PR. It makes me wonder though: what is the reason RN ships with its own copy of fetch?

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

react-native-bot commented Dec 11, 2018

@reime005 merged commit ddc3471 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 11, 2018
lnikkila added a commit to Boulevard/react-native that referenced this pull request Jan 21, 2019
…acebook#22063)

Summary:
This is a problem that is discussed in issue facebook#21092

Related issues: facebook#21851 facebook#19717

Found the code to eventually fix this issue [here](https://github.com/github/fetch/blob/899b155746630c32d83ee29a38642da16b314ecb/fetch.js#L486)

- [x] Fetching an image locally and check if the blob is there, as well as its size > 0.

___
Help reviewers and the release process by writing your own release notes. See below for an example.

[GENERAL] [ENHANCEMENT] [whatwg-fetch] - set blob as default XMLHttpRequest header response type if supported
Pull Request resolved: facebook#22063

Differential Revision: D13408797

Pulled By: cpojer

fbshipit-source-id: 9822d5a7e24bacd72838f3fc9a61b1a97b44484b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.