Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[iOS][TextInput] Apply the fix for CJK languages on single-line text fields. #22546
Follow-up to #19809
This fix generalizes the
Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!
The test app
Essentially, the steps to reproduce are described in the issue:
Behaviour before this fix
Behaviour after this fix (correct)
[IOS] [BUGFIX] [TextView] - Fix Korean/Chinese/Japanese input for single-line TextView on iOS.
referenced this pull request
Dec 6, 2018
shergin left a comment
Why can't we move all this logic inside
There is a huge reason for that desire: This module is the most complex module in the whole RN rendering subsystem. We have to push all logic that might be considered as "improvements of core UIKit components" down to subclasses dedicated for that. The reason is that our RN-specific model of the world implies that our expectations about how UIKit works are correct. That's really challenging to implement the ideal modal itself, so we cannot afford polluting that with UIKit specific fixes. We have to decouple them in subclasses that "fix" UIKit stuff for us.