Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][DevSupport] Add Network Security Config file (fixes #22375) #23105

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@Salakar
Copy link
Collaborator

commented Jan 22, 2019

This fixes #22375. Android API level 28 and above now blocks all clear text requests unless a network configuration rule is added to exclude it specifically.

The packager falls into this category and therefore gets blocked; resulting in the app being unable to connect to it.

Domains/IPs for the config have been taken from here.

This change only adds to DevSupport android resources - so won't affect builds without DevSupport, e.g. release builds.

Changelog:

[ANDROID] [DevSupport] add Network Security Config file to allow access to packager via cleartext requests in Android API 28 and above. (fixes #22375)

Test Plan:

Built an app API 28 Android App with RN Android building from source, prior to this change the packager would not connect and show the following Error in Android logs;

image

After applying this change the connection is now successful.

@pull-bot

This comment has been minimized.

Copy link

commented Jan 22, 2019

Warnings
⚠️

📋 Changelog - This PR may have incorrectly formatted Changelog.

Generated by 🚫 dangerJS

@cpojer

cpojer approved these changes Jan 23, 2019

@facebook-github-bot
Copy link

left a comment

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Thanks for this PR!

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

commented Jan 23, 2019

@Salakar merged commit 3b0b7ce into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 23, 2019

grabbou added a commit that referenced this pull request Jan 23, 2019

Add Network Security Config file (fixes #22375) (#23105)
Summary:
This fixes #22375. Android API level 28 and above now blocks all [clear text requests](https://developer.android.com/training/articles/security-config#CleartextTrafficPermitted) unless a network configuration rule is added to exclude it specifically.

The packager falls into this category and therefore gets blocked; resulting in the app being unable to connect to it.

Domains/IPs for the config have been taken from [here](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.java#L20-L22).

This change only adds to DevSupport android resources - so won't affect builds without DevSupport, e.g. release builds.

Changelog:
----------

[ANDROID] [DevSupport] add Network Security Config file to allow access to packager via cleartext requests in Android API 28 and above. (fixes #22375)
Pull Request resolved: #23105

Differential Revision: D13781516

Pulled By: cpojer

fbshipit-source-id: f7574f3e1b0fe6984efe1d0598ef631385c245bc

matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019

Add Network Security Config file (fixes facebook#22375) (facebook#23105)
Summary:
This fixes facebook#22375. Android API level 28 and above now blocks all [clear text requests](https://developer.android.com/training/articles/security-config#CleartextTrafficPermitted) unless a network configuration rule is added to exclude it specifically.

The packager falls into this category and therefore gets blocked; resulting in the app being unable to connect to it.

Domains/IPs for the config have been taken from [here](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.java#L20-L22).

This change only adds to DevSupport android resources - so won't affect builds without DevSupport, e.g. release builds.

Changelog:
----------

[ANDROID] [DevSupport] add Network Security Config file to allow access to packager via cleartext requests in Android API 28 and above. (fixes facebook#22375)
Pull Request resolved: facebook#23105

Differential Revision: D13781516

Pulled By: cpojer

fbshipit-source-id: f7574f3e1b0fe6984efe1d0598ef631385c245bc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.