Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
adds type checking to Animated toValue and iterations key values to m… #23812
…ake sure Android does not crash from bad params when using useNativeDriver
Android apps crash when using Animated useNativeDriver: true and the toValue is not a number. See issue here with test case. Issue
[Android] [fixed] - Fix crash when using Animated with useNativeDriver and a non Number toValue
Run Snack code with patched React Native core. Malformed parameters will no longer crash Android app.
My motivation for fixing this is that the JS bug is in one of possibly 100 different dependency libraries. Showing a warning might help focus attention on which library is the culprit or where in the internal project code the developer went awry. On the other hand, it might be another yellow box warning that gets silenced because the 3rd party lib is unsupported and the developer is tired of getting nagged about it.
Personally, I would probably want to see a warning and have the option of silencing it or fixing the library.