Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Extended Accessibility Actions Support #24695
This is a reconstitution of #24190. It extends accessibility actions to include both a name and user facing label. These extensions support both standard and custom actions.
We've also added actions support on Android, and added examples to RNTester showing how both standard and custom accessibility actions are used.
[general] [changed] - Enhanced accessibility actions support
Added RNTester examples of both standard and custom actions, and verified that all examples work properly on Android with TalkBack and iOS with VoiceOver.
blavalla left a comment
Overall the Android Implementation looks good to me. I had one inline comment about the expected behavior when setting both an "activate" handler and a standard click handler, but other than that this looks great.
There is another outstanding PR that was adding "focus" and "blur" actions, which you might want to take a look at (#24642). I think your approach here is more generalizable so is the preferred approach, and it should be pretty easy to incorporate focus and blur into
I'll comment on their PR as well to make sure they are aware of your changes here.
referenced this pull request
May 10, 2019
I have disabled focus/blur support for now. I tried them both using accessibility actions, as well as by trapping the appropriate accessibility events as was done in #24642. And in both cases, I couldn't get blur working properly. And I suspect focus without blur support isn't terribly useful.
I'd prefer to separate those into a separate PR and sort them out there.
Anything still needing addressing with this PR?
Check out the link next to the failed