Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][A11y] AccessibilityInfo.announceForAccessibility #24746

Closed
wants to merge 3 commits into from
Closed

[Android][A11y] AccessibilityInfo.announceForAccessibility #24746

wants to merge 3 commits into from

Conversation

@adkenyon
Copy link
Contributor

@adkenyon adkenyon commented May 7, 2019

Summary

AccessibilityInfo.announceForAccessibility is currently only available on iOS. I've added the Android specific implementation, updated RNTester, and the documentation.

Changelog

[Android] [Added] - Added AccessibilityInfo.announceForAccessibility for Android
[General] [Added] - RNTester example for AccessibilityInfo.announceForAccessibility

Test Plan

Copy link

@analysis-bot analysis-bot left a comment

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
cpojer
cpojer approved these changes May 8, 2019
Copy link
Contributor

@cpojer cpojer left a comment

That's awesome! Thank you so much for making sure Android and iOS are consistent and for adding accessibility features :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@react-native-bot react-native-bot commented May 8, 2019

This pull request was successfully merged by @adkenyon in 09f17a4.

When will my fix make it into a release? | Upcoming Releases

@estevaolucas
Copy link

@estevaolucas estevaolucas commented May 8, 2019

really awesome 💪 👏 @adkenyon.

@adkenyon adkenyon deleted the android-accessibility-info-announce-for-accessibility branch May 8, 2019
AKB48 pushed a commit to UnPourTous/react-native that referenced this issue Apr 21, 2020
AKB48 pushed a commit to UnPourTous/react-native that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants