Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change new app screen greeting #24785

Conversation

Projects
None yet
5 participants
@eliperkins
Copy link
Contributor

commented May 9, 2019

We're all friends here, right? 馃挆

Summary

Related to conversation in #24783: #24783 (comment)

We're just making React run on phones, right?

Changelog

[General] [Changed] - Updated new app greeting screen title 馃挆

Test Plan

馃槄

@retyui

This comment has been minimized.

Copy link

commented May 9, 2019

袨褔械薪褜 褋屑械褕薪芯 馃幆
小 写薪褢屑 锌芯斜械写褘

@cpojer

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Could you rebase this PR?

Change new app screen greeting
We're all friends here, right? 馃挆

@eliperkins eliperkins force-pushed the eliperkins:i-for-one-welcome-our-react-overlords branch from d3a61ea to 80f4478 May 9, 2019

@eliperkins

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Rebased!

@cpojer

cpojer approved these changes May 9, 2019

Copy link
Contributor

left a comment

What would you do if you weren't afraid?

@facebook-github-bot
Copy link

left a comment

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

This pull request was successfully merged by @eliperkins in e7085cd.

When will my fix make it into a release? | Upcoming Releases

@eliperkins eliperkins deleted the eliperkins:i-for-one-welcome-our-react-overlords branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.