Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextInput] returnKeyType, enablesReturnKeyAutomatically, secureTextEntry, more keyboardTypes #265

Closed
wants to merge 1 commit into from

Conversation

@ide
Copy link
Contributor

ide commented Mar 26, 2015

This diff completes adding support for the following UITextField properties:

  • returnKeyType: what the return key on the keyboard says
  • enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
  • secureTextEntry: obscure passwords
  • keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.

…ntry more keyboardTypes

This diff completes adding support for the following UITextField properties:

returnKeyType: what the return key on the keyboard says
enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
secureTextEntry: obscure passwords
keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.
@ide
Copy link
Contributor Author

ide commented Mar 26, 2015

Fixes the secure text field request in #245

@a2
Copy link
Contributor

a2 commented Mar 26, 2015

I CANT USE PHABRICATOR MACROS HERE MY POWERS ARE USELESS
But actually this looks good to me star ship it.

@ide
Copy link
Contributor Author

ide commented Mar 26, 2015

@a2 awesometown

I would be 80% serious if I said to move the code review off of GitHub and onto Phabricator. Phacility has done a really great job making the flow intuitive compared to other products.

@sophiebits
Copy link
Contributor

sophiebits commented Mar 26, 2015

@ide Yeah, hhvm uses Phabricator (reviews.facebook.net) now and it's something we could look at doing here and on React too.

@vjeux
Copy link
Contributor

vjeux commented Mar 28, 2015

This has been requested many times, need to merge it asap

@tadeuzagallo
Copy link
Contributor

tadeuzagallo commented Mar 31, 2015

Landed internally, will be out on the next sync

@ide
Copy link
Contributor Author

ide commented Mar 31, 2015

Thanks for the code review guys

@ide ide deleted the ide:textfield-props branch Mar 31, 2015
vjeux pushed a commit to vjeux/react-native that referenced this pull request Apr 13, 2015
…ntry, more keyboardTypes

Summary:
This diff completes adding support for the following UITextField properties:

- returnKeyType: what the return key on the keyboard says
- enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
- secureTextEntry: obscure passwords
- keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.
Closes facebook#265
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@mrtom
Copy link

mrtom commented Apr 14, 2015

@ide, @a2 any idea when this will be in a released version of reactive-native?

@a2
Copy link
Contributor

a2 commented Apr 14, 2015

It should have been synced by now?

@tadeuzagallo
Copy link
Contributor

tadeuzagallo commented Apr 14, 2015

Yes, it was synced on 9a4ee17

@mrtom
Copy link

mrtom commented Apr 14, 2015

But that's not been pushed out via NPM, right?

@mrtom
Copy link

mrtom commented Apr 14, 2015

Ignore me, I'm being a muppet... Sorry!

vjeux pushed a commit to vjeux/react-native that referenced this pull request Apr 14, 2015
…ntry, more keyboardTypes

Summary:
This diff completes adding support for the following UITextField properties:

- returnKeyType: what the return key on the keyboard says
- enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
- secureTextEntry: obscure passwords
- keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.
Closes facebook#265
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this pull request Apr 15, 2015
…ntry, more keyboardTypes

Summary:
This diff completes adding support for the following UITextField properties:

- returnKeyType: what the return key on the keyboard says
- enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously.
- secureTextEntry: obscure passwords
- keyboardType: added all the keyboard types, they are useful in different scenarios

There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.

Added examples to the UIExplorer.
Closes facebook#265
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@billinghamj
Copy link

billinghamj commented Oct 27, 2015

Any chance you guys could work publicly on github rather than syncing from an internal repo?

@sophiebits
Copy link
Contributor

sophiebits commented Oct 27, 2015

Internal commits are now synced out within minutes so there's not a huge difference.

rozele pushed a commit to rozele/react-native that referenced this pull request Apr 11, 2016
feat(ReactPickerView): Add ReactPickerView
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
* Added <InputAccessoryView> blog post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.