Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Generate test results in a discoverable location #27435

Closed
wants to merge 3 commits into from

Conversation

@hramos
Copy link
Contributor

hramos commented Dec 6, 2019

Summary

Test results were being written to ~/reports/, while Circle CI was configured to look for these in ~/react-native/reports/.

This simple fix makes it so that Circle CI's test result tab can now display line-by-line results without the need to dig through log spew to understand which tests failed.

Changelog

[Internal] [Fixed] - Generate test results in discoverable location (CI)

Test Plan

See https://app.circleci.com/jobs/github/hramos/react-native/7112/tests
Compare with any other run, where this tab would show an error message due to lack of test results.

hramos added 2 commits Dec 11, 2019
Copy link

facebook-github-bot left a comment

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

react-native-bot commented Dec 20, 2019

This pull request was successfully merged by @hramos in d07b164.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.