Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Flipper in RNTester on Android #27631

Open
wants to merge 5 commits into
base: master
from

Conversation

@safaiyeh
Copy link
Contributor

safaiyeh commented Dec 29, 2019

Summary

0.62 Flipper Support items: #27565
Made RNTester's Android Flipper implementation consistent with the template.
Added Flipper to the iOS build.
Screen Shot 2019-12-28 at 7 06 42 PM

Changelog

[Internal] [Added] - RNTester Android Fipper updates

Test Plan

Run RNTester and see if it connects to Flipper.

RNTester/Podfile Outdated Show resolved Hide resolved
@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Jan 10, 2020

Could you rebase and take a look at the failures?

@rickhanlonii rickhanlonii force-pushed the safaiyeh:flipper-RNTester branch from 4212ff9 to aa009e7 Jan 10, 2020
@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Jan 10, 2020

I rebased onto master and tested iOS

Screen Shot 2020-01-10 at 11 08 37 AM

@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Jan 10, 2020

Seems like the failing tests are failing on master as well so unrelated

Copy link

facebook-github-bot left a comment

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy
passy approved these changes Jan 10, 2020
Copy link
Member

passy left a comment

Android side LGTM!

@safaiyeh safaiyeh changed the title [RNTester][Flipper] Make Android consistent with 0.62 template. Add Flipper to iOS [RNTester][Flipper] Make Android consistent with 0.62 template Jan 15, 2020
@safaiyeh

This comment has been minimized.

Copy link
Contributor Author

safaiyeh commented Jan 15, 2020

Reverted iOS changes in favor of #27762, @priteshrnandgaonkar solved the use_frameworks! issue.

This just makes the updates to Android to be consistent with the template app

cc @rickhanlonii

@rickhanlonii rickhanlonii changed the title [RNTester][Flipper] Make Android consistent with 0.62 template Integrate Flipper in RNTester on Android Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.