Skip to content

fix: Add missing intents to RNTester AndroidManifest#32986

Closed
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:fix/rn-tester-linking
Closed

fix: Add missing intents to RNTester AndroidManifest#32986
gabrieldonadel wants to merge 1 commit into
facebook:mainfrom
gabrieldonadel:fix/rn-tester-linking

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

Summary

Partially resolves #32962 by adding required intents to RNTester AndroidManifest.

As we're now using SDK 31 as the targetSdkVersion for RNTester we must manually specify the intents for the schemes we want to handle due to changes in Package visibility on Android 11.

This PR updates RNTester AndroidManifest in order to support canOpenURL with the url types:

  • http/https urls
  • phone numbers
  • geolocation
  • facebook app uri

Changelog

[Internal] [Fixed] - Add missing intents to RNTester AndroidManifest

Test Plan

  1. Run ./scripts/test-manual-e2e.sh, choose Android and then Hermes
  2. Head to the APIs example, Linking -> "Open external URLs"
Screen.Recording.2022-01-28.at.01.21.50.mov

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 28, 2022
@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d3a0c41
Branch: main

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,299,092 +26
android hermes armeabi-v7a 7,636,198 +18
android hermes x86 8,772,376 +20
android hermes x86_64 8,709,439 +11
android jsc arm64-v8a 9,784,615 +125
android jsc armeabi-v7a 8,769,913 +143
android jsc x86 9,750,483 +135
android jsc x86_64 10,346,427 +137

Base commit: d3a0c41
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gabrieldonadel in b897db0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 28, 2022
@gabrieldonadel gabrieldonadel deleted the fix/rn-tester-linking branch January 28, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External Linking on RNTester is broken

4 participants