Fix ESLint and Typescript-ESLint disagreeing about function spacing#33453
Fix ESLint and Typescript-ESLint disagreeing about function spacing#33453joeframbach wants to merge 1 commit into
Conversation
Summary: Fixes facebook#33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript. Changelog: [General][Fixed] - Update function spacing linting rules See facebook#33452 - Existing function spacing linting should pass as expected.
|
Hi @joeframbach! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: d63bf4a |
Base commit: d63bf4a |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @joeframbach in 8650220. When will my fix make it into a release? | Upcoming Releases |
…acebook#33453) Summary: Fixes facebook#33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript. Changelog: [General][Fixed] - Update function spacing linting rules See facebook#33452 - Existing function spacing linting should pass as expected. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [CATEGORY] [TYPE] - Message Pull Request resolved: facebook#33453 Reviewed By: lunaleaps, cortinico Differential Revision: D35011944 Pulled By: GijsWeterings fbshipit-source-id: 441650045d89a01a9114103da0c080643f9cb82c
Summary:
Fixes #33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript.
Changelog: [General][Fixed] - Update function spacing linting rules
See #33452 - Existing function spacing linting should pass as expected.
Summary
Changelog
[CATEGORY] [TYPE] - Message
Test Plan