Skip to content

Fix ESLint and Typescript-ESLint disagreeing about function spacing#33453

Closed
joeframbach wants to merge 1 commit into
facebook:mainfrom
joeframbach:fix-typescript-eslint-function-spacing
Closed

Fix ESLint and Typescript-ESLint disagreeing about function spacing#33453
joeframbach wants to merge 1 commit into
facebook:mainfrom
joeframbach:fix-typescript-eslint-function-spacing

Conversation

@joeframbach

Copy link
Copy Markdown
Contributor

Summary:
Fixes #33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript.

Changelog: [General][Fixed] - Update function spacing linting rules

See #33452 - Existing function spacing linting should pass as expected.

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

Summary:
Fixes facebook#33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript.

Changelog: [General][Fixed] - Update function spacing linting rules

See facebook#33452 - Existing function spacing linting should pass as expected.
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @joeframbach!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d63bf4a
Branch: main

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,950,994 +0
android hermes armeabi-v7a 7,546,203 +0
android hermes x86 8,305,328 +0
android hermes x86_64 8,257,133 +0
android jsc arm64-v8a 9,619,582 +0
android jsc armeabi-v7a 8,599,208 +0
android jsc x86 9,570,002 +0
android jsc x86_64 10,165,945 +0

Base commit: d63bf4a
Branch: main

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 19, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @joeframbach in 8650220.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 1, 2022
@joeframbach joeframbach deleted the fix-typescript-eslint-function-spacing branch April 7, 2022 18:04
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
…acebook#33453)

Summary:
Fixes facebook#33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript.

Changelog: [General][Fixed] - Update function spacing linting rules

See facebook#33452 - Existing function spacing linting should pass as expected.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[CATEGORY] [TYPE] - Message

Pull Request resolved: facebook#33453

Reviewed By: lunaleaps, cortinico

Differential Revision: D35011944

Pulled By: GijsWeterings

fbshipit-source-id: 441650045d89a01a9114103da0c080643f9cb82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier and @typescript-eslint disagree on function types in generics

5 participants