Skip to content

Blacklist sdks/hermes from Metro resolution#34452

Closed
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D38856931
Closed

Blacklist sdks/hermes from Metro resolution#34452
cortinico wants to merge 1 commit into
facebook:mainfrom
cortinico:export-D38856931

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:
This will unblock the RN test_android CI Job as currently two versions
of hermes-parser are picked up during package resolution.

Changelog:
[Internal] [Fixed] - Blacklist sdks/hermes from Metro resolution

Differential Revision: D38856931

Summary:
This will unblock the RN `test_android` CI Job as currently two versions
of `hermes-parser` are picked up during package resolution.

Changelog:
[Internal] [Fixed] - Blacklist sdks/hermes from Metro resolution

Differential Revision: D38856931

fbshipit-source-id: 2f86eba1c27122edd2aafee5059168bdebf482f9
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 19, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D38856931

@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,615,166 +310
android hermes armeabi-v7a 7,030,150 +365
android hermes x86 7,915,638 +49
android hermes x86_64 7,889,604 +294
android jsc arm64-v8a 9,494,197 +412
android jsc armeabi-v7a 8,272,050 +389
android jsc x86 9,432,261 +380
android jsc x86_64 10,025,334 +417

Base commit: 4eec473
Branch: main

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in bc84ec4.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 19, 2022
@analysis-bot

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4eec473
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants