Make bounds and resizeMode of gif network images respond to styles #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CGImageRef firstFrame = (__bridge CGImageRef)animation.values.firstObject; | ||
| self.layer.bounds = CGRectMake(0, 0, CGImageGetWidth(firstFrame), CGImageGetHeight(firstFrame)); | ||
| self.layer.contentsScale = 1.0; | ||
| self.layer.bounds = CGRectMake(0, 0, self.bounds.size.width, self.bounds.size.height); |
There was a problem hiding this comment.
Good point, removed
| self.layer.bounds = CGRectMake(0, 0, CGImageGetWidth(firstFrame), CGImageGetHeight(firstFrame)); | ||
| self.layer.contentsScale = 1.0; | ||
| self.layer.bounds = CGRectMake(0, 0, self.bounds.size.width, self.bounds.size.height); | ||
| self.layer.contentsScale = RCTScreenScale(); |
There was a problem hiding this comment.
I think this line is unnecessary but I may be wrong.
There was a problem hiding this comment.
If I remove it then the image does not show up at all, so it seems necessary
|
@a2 - thanks for the feedback, let me know if there's anything else you'd like me to do here! |
| self.layer.bounds = CGRectMake(0, 0, CGImageGetWidth(firstFrame), CGImageGetHeight(firstFrame)); | ||
| self.layer.contentsScale = 1.0; | ||
| self.layer.contentsGravity = kCAGravityResizeAspect; | ||
| self.layer.contentsScale = RCTScreenScale(); |
There was a problem hiding this comment.
Basically we don't currently support @2x or @3x GIFs so maybe change the contentsScale to 1.0? Or, if you want to keep RCTScreenScale(), we need to add that support, maybe by checking the filename suffix before the extension.
There was a problem hiding this comment.
@a2 - good point, let's just make this 1.0 and we can open a separate issue for @2x+ support if you like
|
👍 |
brentvatne
changed the title
|
Merged internally and synced. |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: @vjeux and I were discussing this in irc an discovered that network gif images did not respond how they should to width, height or flex properties. Along the way I also noticed that the scale was not changing depending on the device. This PR fixes that, so now you can do `flex: 1` on a gif image to have it stretch to the whole screen. [Minimum reproducible example here](https://gist.github.com/brentvatne/f745377b0789162a28df) - try this without and then with the changes of this PR to see. Closes facebook#353 Github Author: Brent Vatne <brent.vatne@madriska.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 14, 2015
Summary: @vjeux and I were discussing this in irc an discovered that network gif images did not respond how they should to width, height or flex properties. Along the way I also noticed that the scale was not changing depending on the device. This PR fixes that, so now you can do `flex: 1` on a gif image to have it stretch to the whole screen. [Minimum reproducible example here](https://gist.github.com/brentvatne/f745377b0789162a28df) - try this without and then with the changes of this PR to see. Closes facebook#353 Github Author: Brent Vatne <brent.vatne@madriska.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 15, 2015
Summary: @vjeux and I were discussing this in irc an discovered that network gif images did not respond how they should to width, height or flex properties. Along the way I also noticed that the scale was not changing depending on the device. This PR fixes that, so now you can do `flex: 1` on a gif image to have it stretch to the whole screen. [Minimum reproducible example here](https://gist.github.com/brentvatne/f745377b0789162a28df) - try this without and then with the changes of this PR to see. Closes facebook#353 Github Author: Brent Vatne <brent.vatne@madriska.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
This was referenced Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vjeux and I were discussing this in irc an discovered that network gif images did not respond how they should to width, height or flex properties. This PR fixes that, so now you can do
flex: 1on a gif image to have it stretch to the whole screen. Minimum reproducible example here - try this without and then with the changes of this PR to see.