-
Notifications
You must be signed in to change notification settings - Fork 24.6k
remove hermes note #35555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hermes note #35555
Conversation
Base commit: ea9e78d |
Base commit: ea9e78d |
PR build artifact for a7cff29 is ready. |
PR build artifact for a7cff29 is ready. |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @dcangulo in 032bed4. When will my fix make it into a release? | Upcoming Releases |
Summary: This note was added when upgrading from 0.69x to 0.70.x when `hermes_enabled` is explicitly set to `true`. <img width="669" alt="Screenshot 2022-12-05 at 11 26 15" src="https://user-images.githubusercontent.com/36528176/205543104-b4a72c1c-57c0-422b-881e-8a0cb9d5c2a1.png"> But on 0.71, we are now using `get_default_flags` again which makes the note obsolete. ## Changelog [Internal] [Removed] - removed hermes note Pull Request resolved: facebook#35555 Test Plan: N/A Reviewed By: dmytrorykun Differential Revision: D41731004 Pulled By: cortinico fbshipit-source-id: d5f377062bf94fa73bc6e73d1f108e37ad68c715
Summary
This note was added when upgrading from 0.69x to 0.70.x when
hermes_enabled
is explicitly set totrue
.But on 0.71, we are now using
get_default_flags
again which makes the note obsolete.Changelog
[Internal] [Removed] - removed hermes note
Test Plan
N/A