Skip to content

remove hermes note #35555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove hermes note #35555

wants to merge 1 commit into from

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Dec 5, 2022

Summary

This note was added when upgrading from 0.69x to 0.70.x when hermes_enabled is explicitly set to true.

Screenshot 2022-12-05 at 11 26 15

But on 0.71, we are now using get_default_flags again which makes the note obsolete.

Changelog

[Internal] [Removed] - removed hermes note

Test Plan

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,104,305 +283
android hermes armeabi-v7a 6,473,067 +219
android hermes x86 7,522,581 +448
android hermes x86_64 7,381,008 +601
android jsc arm64-v8a 8,971,778 +0
android jsc armeabi-v7a 7,703,208 +0
android jsc x86 9,034,387 +0
android jsc x86_64 9,511,779 +0

Base commit: ea9e78d
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ea9e78d
Branch: main

@pull-bot
Copy link

pull-bot commented Dec 5, 2022

PR build artifact for a7cff29 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Dec 5, 2022

PR build artifact for a7cff29 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This pull request was successfully merged by @dcangulo in 032bed4.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Dec 5, 2022
@dcangulo dcangulo deleted the chore/remove-note branch December 5, 2022 13:10
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
This note was added when upgrading from 0.69x to 0.70.x when `hermes_enabled` is explicitly set to `true`.

<img width="669" alt="Screenshot 2022-12-05 at 11 26 15" src="https://user-images.githubusercontent.com/36528176/205543104-b4a72c1c-57c0-422b-881e-8a0cb9d5c2a1.png">

But on 0.71, we are now using  `get_default_flags` again which makes the note obsolete.

## Changelog

[Internal] [Removed] - removed hermes note

Pull Request resolved: facebook#35555

Test Plan: N/A

Reviewed By: dmytrorykun

Differential Revision: D41731004

Pulled By: cortinico

fbshipit-source-id: d5f377062bf94fa73bc6e73d1f108e37ad68c715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants