From 0ff82dfd09155eea1b1d1e802a5219b5094624a5 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 6 Jan 2023 07:19:02 -0800 Subject: [PATCH 1/3] Remove unused .netrc file from CircleCI (#35785) Summary: Removing a stale configuration that was configuring username/password before publishing to NPM. This is effectively unused + the Github Token there is invalid therefore can be removed. ## Changelog [INTERNAL] - Remove unused .netrc file from CircleCI Pull Request resolved: https://github.com/facebook/react-native/pull/35785 Test Plan: n/a Reviewed By: cipolleschi Differential Revision: D42385163 Pulled By: cortinico fbshipit-source-id: 0dbbf44459d59f792da4221d6100800a2f4efda2 --- .circleci/config.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7345fe18dc74e7..82eb9c39380de4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1496,10 +1496,6 @@ jobs: - equal: [ "nightly", << parameters.release_type >> ] steps: - run: echo "//registry.npmjs.org/:_authToken=${CIRCLE_NPM_TOKEN}" > ~/.npmrc - - run: | - git config --global user.email "react-native-bot@users.noreply.github.com" - git config --global user.name "npm Deployment Script" - echo "machine github.com login react-native-bot password $GITHUB_TOKEN" > ~/.netrc # END: Stables and nightlies - run: node ./scripts/publish-npm.js --<< parameters.release_type >> From 9f82b9cdd8551d134429161a1ef15f99ad615508 Mon Sep 17 00:00:00 2001 From: LeoTM <1881059+leotm@users.noreply.github.com> Date: Fri, 25 Nov 2022 06:44:21 -0800 Subject: [PATCH 2/3] Bump node version from 16 to 18 (#35443) Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - https://github.com/facebook/react-native/pull/34171 - https://github.com/facebook/react-native/pull/32980 Ref - https://github.com/react-native-community/docker-android/pull/187 cc ramonmedel cortinico gengjiawen ## Changelog [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: https://github.com/facebook/react-native/pull/35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308 --- .circleci/config.yml | 6 +++--- .node-version | 2 +- template/_node-version | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 82eb9c39380de4..403311fdf94e42 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -51,8 +51,8 @@ references: # ------------------------- dependency_versions: xcode_version: &xcode_version "14.0.1" - nodelts_image: &nodelts_image "cimg/node:16.14" - nodeprevlts_image: &nodeprevlts_image "cimg/node:14.19" + nodelts_image: &nodelts_image "cimg/node:18.12.1" + nodeprevlts_image: &nodeprevlts_image "cimg/node:16.18.1" # ------------------------- # Cache Key Anchors @@ -612,7 +612,7 @@ jobs: - run: name: Configure Environment Variables command: | - echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV + echo 'export PATH=/usr/local/opt/node@18/bin:$PATH' >> $BASH_ENV source $BASH_ENV - run: diff --git a/.node-version b/.node-version index b6a7d89c68e0ca..3c032078a4a21c 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -16 +18 diff --git a/template/_node-version b/template/_node-version index b6a7d89c68e0ca..3c032078a4a21c 100644 --- a/template/_node-version +++ b/template/_node-version @@ -1 +1 @@ -16 +18 From 938257915fd0ba43b2eca8cfbe12007aef32cac1 Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin Date: Wed, 25 Jan 2023 21:52:19 +0000 Subject: [PATCH 3/3] fix(setup-verdaccio): save auth token for verdaccio before bootstrapping it --- scripts/setup-verdaccio.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/setup-verdaccio.js b/scripts/setup-verdaccio.js index 3dc32a261dbe60..26e8559e74eb40 100644 --- a/scripts/setup-verdaccio.js +++ b/scripts/setup-verdaccio.js @@ -28,6 +28,10 @@ function setupVerdaccio( ); } + execSync('echo "//localhost:4873/:_authToken=secretToken" > .npmrc', { + cwd: reactNativeRootPath, + }); + const verdaccioProcess = spawn( 'npx', ['verdaccio@5.16.3', '--config', verdaccioConfigPath], @@ -37,11 +41,7 @@ function setupVerdaccio( const VERDACCIO_PID = verdaccioProcess.pid; execSync('npx wait-on@6.0.1 http://localhost:4873'); - execSync('npm set registry http://localhost:4873'); - execSync('echo "//localhost:4873/:_authToken=secretToken" > .npmrc', { - cwd: reactNativeRootPath, - }); return VERDACCIO_PID; }